Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use constraints values in @platforms instead of @bazel_tools//platfor… #781

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

limdor
Copy link
Contributor

@limdor limdor commented Sep 12, 2022

…ms bazelbuild/bazel#8622

PiperOrigin-RevId: 452387904
(cherry picked from commit e5f2601)

@google-cla
Copy link

google-cla bot commented Sep 12, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@limdor
Copy link
Contributor Author

limdor commented Sep 12, 2022

The CLA failure is because the initial author is the Protobuf Team and there is no CLA for the Protobuf Team.

@limdor
Copy link
Contributor Author

limdor commented Sep 18, 2022

@haberman @ericsalo could any of you support with this cherry pick? Would it be fine if I take the changes manually without a cherry pick?

@limdor
Copy link
Contributor Author

limdor commented Sep 23, 2022

Thanks for approving, will you take care also of merging. It would be cool if could be done soon with this way we can bump the version from Bazel before Bazel 6.

@haberman haberman merged commit a547704 into protocolbuffers:21.x Sep 23, 2022
@limdor
Copy link
Contributor Author

limdor commented Sep 23, 2022

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants