Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev (with 7739 update fixes) to main for deployment #219

Closed
wants to merge 39 commits into from
Closed

Conversation

filmakarov
Copy link
Collaborator

Merge dev (with 7739 update fixes) to main for deployment

Copy link

openzeppelin-code bot commented Nov 21, 2024

Merge dev (with 7739 update fixes) to main for deployment

Generated at commit: 26acfa54e9bba22eacad8fb119a3d0c23ff4afe8

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
6
27
35

For more details view the full report in OpenZeppelin Code Inspector

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 84.45%. Comparing base (72ed2b8) to head (93241d2).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
contracts/Nexus.sol 50.00% 9 Missing ⚠️
contracts/modules/validators/K1Validator.sol 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
- Coverage   85.68%   84.45%   -1.24%     
==========================================
  Files          14       13       -1     
  Lines         922      849      -73     
  Branches      253      268      +15     
==========================================
- Hits          790      717      -73     
  Misses        117      117              
  Partials       15       15              
Files with missing lines Coverage Δ
contracts/base/BaseAccount.sol 97.36% <ø> (ø)
contracts/utils/NexusBootstrap.sol 100.00% <ø> (ø)
contracts/modules/validators/K1Validator.sol 70.12% <50.00%> (-0.25%) ⬇️
contracts/Nexus.sol 82.41% <50.00%> (-2.64%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc5d4bf...93241d2. Read the comment docs.

---- 🚨 Try these New Features:

Copy link

github-actions bot commented Nov 21, 2024

Changes to gas cost

Generated at commit: 566be15a404244dfb48e2d525ae0a13001bafe0d, compared to commit: fd4db096db1e9e73329966e5ca9f57967e13be09

🧾 Summary (5% most significant diffs)

Contract Method Avg (+/-) %
Nexus validateUserOp +6 ❌ +0.04%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
Nexus 4,762,675 (+37,085) validateUserOp 13,865 (+6) +0.04% 15,436 (+6) +0.04% 13,865 (+6) +0.04% 42,634 (+6) +0.01% 347 (0)
MockPaymaster 1,063,705 (+187)
MockValidator 990,635 (+22,622)
HelperConfig 7,039,537 (+3,257,672)

@filmakarov filmakarov closed this Nov 21, 2024
Copy link

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - locked-ether (1 results) (Medium)

locked-ether

🟡 Impact: Medium
🔴 Confidence: High

utils/NexusBootstrap.sol#L33-L165

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L10

factory/RegistryFactory.sol#L39

_This comment was automatically generated by the GitHub Actions workflow._

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants