Update Aabb on Sprite::custom_size changed.
#10587
Labels
A-Rendering
Drawing game state to the screen
C-Bug
An unexpected or incorrect behavior
D-Trivial
Nice and easy! A great choice to get started with Bevy
Comments
Selene-Amanita
added
C-Feature
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 18, 2023
…11016) # Objective - Fixes #10587, where the `Aabb` component of entities with `Sprite` and `Handle<Image>` components was not automatically updated when `Sprite::custom_size` changed. ## Solution - In the query for entities with `Sprite` components in `calculate_bounds_2d`, use the `Changed` filter to detect for `Sprites` that changed as well as sprites that do not have `Aabb` components. As noted in the issue, this will cause the `Aabb` to be recalculated when other fields of the `Sprite` component change, but calculating the `Aabb` for sprites is trivial. --- ## Changelog - Modified query for entities with `Sprite` components in `calculate_bounds_2d`, so that entities with `Sprite` components that changed will also have their AABB recalculated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Motivation
This PR is a subset of #4294 : the
Aabbcomponent is never automatically updated after it is added to an entity, even when it should be (for example the Mesh vertices positions are updated).To fix #4294 integrally, #5069 needs to be solved, as we need to rely on asset change detection for most of the cases.
From Bevy 0.11.0, frustum culling was added for 2D entities, and an
Aabbcomponent is automatically added to entities with aSpriteandHandle<Image>component (bycalculate_bounds_2d), and never updated. To update it automatically, in the case whereSprite::custom_sizeisNone, we would require the image asset change detection. However, whenSpriteis changed andcustom_sizeis set toSome, we could update theAabbin the current state of Bevy.Note
Simply detecting
Spritechange could trigger false positives, like when another field thancustom_sizeoranchoris changed, theAabbwould still be needlessly recalculated in this case. I don't think it is a big problem as Aabb calculation is trivial in that case. If it is,custom_sizecould be isolated in a separate component.The text was updated successfully, but these errors were encountered: