Update AABB when Sprite component changes in calculate_bounds_2d() #11016
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Aabb
onSprite::custom_size
changed. #10587, where theAabb
component of entities withSprite
andHandle<Image>
components was not automatically updated whenSprite::custom_size
changed.Solution
Sprite
components incalculate_bounds_2d
, use theChanged
filter to detect forSprites
that changed as well as sprites that do not haveAabb
components. As noted in the issue, this will cause theAabb
to be recalculated when other fields of theSprite
component change, but calculating theAabb
for sprites is trivial.Changelog
Sprite
components incalculate_bounds_2d
, so that entities withSprite
components that changed will also have their AABB recalculated.