Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame unstable in many_foxes example #11787

Closed
re0312 opened this issue Feb 9, 2024 · 7 comments · Fixed by #11805
Closed

Frame unstable in many_foxes example #11787

re0312 opened this issue Feb 9, 2024 · 7 comments · Fixed by #11805
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Needs-Investigation This issue requires detective work to figure out what's going wrong

Comments

@re0312
Copy link
Contributor

re0312 commented Feb 9, 2024

Bevy version

main(#11781 )

[Optional] Relevant system information

windows AMD R7-4800H NV 2060

What you did

Run example "many_foxes"

What went wrong

fps jump between 90- and 150+

Additional information

Frame Time show
image

prepare_windows will block a long time sometimes
strangely, this phenomenon is intermittent(with an interval about 1 second in my computer)
image

Seems introduced by #10268

@re0312 re0312 added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Feb 9, 2024
@NthTensor
Copy link
Contributor

Could this be contention with other applications? Can you reproduce this issue on examples, or is it many_foxes?

@re0312
Copy link
Contributor Author

re0312 commented Feb 9, 2024

Could this be contention with other applications? Can you reproduce this issue on examples, or is it many_foxes?

looks like not application contention, I can reproduce this issue in example many_foxes after pr #10268

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen S-Needs-Investigation This issue requires detective work to figure out what's going wrong and removed S-Needs-Triage This issue needs to be labelled labels Feb 9, 2024
@alice-i-cecile
Copy link
Member

@re0312 did you bisect to determine that #10628 the exact cause of this?

@re0312
Copy link
Contributor Author

re0312 commented Feb 9, 2024

@re0312 did you bisect to determine that #10628 the exact cause of this?

yeah, but 10628(x) 10268(√), I restart my computer and close unnecessary apps just now, It still happens to me after 10268,TBH,the issue is reallly weird and I checked it for several times but got the same result . It would be greatly appreciated if anyone could try to reproduce it with other computer to provide convincing proof that this is a real bug versus an environmental fluke.

@NthTensor
Copy link
Contributor

I have tried running many_foxes on current main and have not been able to reproducethis. Linux intel APU laptop.

@superdump
Copy link
Contributor

Is that a laptop? Are you always running on AC power and with GPU clock frequencies locked?

@re0312
Copy link
Contributor Author

re0312 commented Feb 10, 2024

Is that a laptop? Are you always running on AC power and with GPU clock frequencies locked?

yeah,laptop with the power supply plugged in but without manually locking the GPU clock speed(default performance mod) , this issue only happens when I checkout branch after 10268 .

github-merge-queue bot pushed a commit that referenced this issue Feb 10, 2024
This was causing a severe performance regression when light probes were
enabled.

Fixes #11787.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Needs-Investigation This issue requires detective work to figure out what's going wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants