Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alien_cake_addict example lighting issues #15729

Closed
LiamGallagher737 opened this issue Oct 8, 2024 · 2 comments · Fixed by #16281
Closed

alien_cake_addict example lighting issues #15729

LiamGallagher737 opened this issue Oct 8, 2024 · 2 comments · Fixed by #16281
Assignees
@BenjaminBrienen
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@LiamGallagher737
Copy link
Member

LiamGallagher737 commented Oct 8, 2024 •
edited
Loading

Bevy version

e7b83ac

Relevant system information

SystemInfo { os: "Linux 24.05 NixOS", kernel: "6.6.34", cpu: "AMD Ryzen 7 5800X 8-Core Processor", core_count: "8", memory: "31.2 GiB" }
AdapterInfo { name: "NVIDIA GeForce RTX 3060 Ti", vendor: 4318, device: 9353, device_type: DiscreteGpu, driver: "NVIDIA", driver_info: "550.78", backend: Vulkan }

What you did

cargo r --example alien_cake_addict

What went wrong

At first the lighting is fine, but after losing the game and starting again by pressing space on the game over screen the lighting is messed up.

Here is a video showing it: https://youtu.be/dLpKSMGyS-M
@LiamGallagher737 LiamGallagher737 added A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples labels Oct 8, 2024
@LiamGallagher737
Copy link
Member Author

LiamGallagher737 commented Oct 8, 2024 •
edited
Loading

The offending commit is 56f8e52 from #15320.

@LiamGallagher737 LiamGallagher737 added the P-Regression Functionality that used to work but no longer does. Add a test for this! label Oct 8, 2024
@BenjaminBrienen BenjaminBrienen added the S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! label Oct 30, 2024
@BenjaminBrienen
Copy link
Contributor

Image

@BenjaminBrienen BenjaminBrienen self-assigned this Nov 7, 2024
@BenjaminBrienen BenjaminBrienen mentioned this issue Nov 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2024
@BenjaminBrienen
Fix alien_cake_addict example (#16281)
94f2fe3 
# Objective

Fixes #15729

## Solution

Use the state-scoped pattern.

## Testing

Tested manually. See the showcase.

---

## Showcase



https://github.com/user-attachments/assets/14ffefca-40c6-4c7e-b15b-f92466a2b0a5
mockersf pushed a commit that referenced this issue Nov 11, 2024
@BenjaminBrienen @mockersf
Fix alien_cake_addict example (#16281)
c53e733 
# Objective

Fixes #15729

## Solution

Use the state-scoped pattern.

## Testing

Tested manually. See the showcase.

---

## Showcase



https://github.com/user-attachments/assets/14ffefca-40c6-4c7e-b15b-f92466a2b0a5
ecoskey pushed a commit to ecoskey/bevy that referenced this issue Dec 2, 2024
@BenjaminBrienen @ecoskey
Fix alien_cake_addict example (bevyengine#16281)
276bf90 
# Objective

Fixes bevyengine#15729

## Solution

Use the state-scoped pattern.

## Testing

Tested manually. See the showcase.

---

## Showcase



https://github.com/user-attachments/assets/14ffefca-40c6-4c7e-b15b-f92466a2b0a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenjaminBrienen BenjaminBrienen

Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix alien_cake_addict example BenjaminBrienen/bevy
2 participants
@BenjaminBrienen @LiamGallagher737