Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons on example animation_masks does not work on main (624f573443f6bd6bb8bcf716fb1289d66a15b35b) #15995

Closed
hukasu opened this issue Oct 18, 2024 · 1 comment · Fixed by #15996
Closed

Buttons on example animation_masks does not work on main (624f573443f6bd6bb8bcf716fb1289d66a15b35b) #15995

hukasu opened this issue Oct 18, 2024 · 1 comment · Fixed by #15996
Labels
C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@hukasu
Copy link
Contributor

hukasu commented Oct 18, 2024

Bevy version

Bevy 0.15-dev (624f573)

[Optional] Relevant system information

2024-10-18T22:09:30.313408Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "Linux 24.05 NixOS", kernel: "6.6.51", cpu: "Intel(R) Core(TM) i7-14700KF", core_count: "20", memory: "31.2 GiB" }
2024-10-18T22:09:30.503436Z  INFO bevy_render::renderer: AdapterInfo { name: "NVIDIA GeForce RTX 4060 Ti", vendor: 4318, device: 10243, device_type: DiscreteGpu, driver: "NVIDIA", driver_info: "550.78", backend: Vulkan }

What you did

Ran animation_masks example.

What went wrong

Buttons do not work.

Additional information

I added 2 dbg! on handle_button_toggles, one on line 431 dbg!(animation_nodes), and one on line 437 dbg!(*interaction), the first dbg! outputs Some(...), but the second dbg! does no print anything.
@hukasu hukasu added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Oct 18, 2024
@rparrett rparrett mentioned this issue Oct 18, 2024
Merged
@rparrett rparrett added D-Trivial Nice and easy! A great choice to get started with Bevy C-Examples An addition or correction to our examples and removed S-Needs-Triage This issue needs to be labelled labels Oct 18, 2024
@rparrett
Copy link
Contributor

Thanks for the report.

Opened a PR to fix: #15996

github-merge-queue bot pushed a commit that referenced this issue Oct 19, 2024
@rparrett
Fix animation_masks example's buttons (#15996)
c65f292 
# Objective

Fixes #15995

## Solution

Corrects a mistake made during the example migration in #15591.

`AnimationControl` was meant to be on the parent, not the child. So the
query in `update_ui` was no longer matching.

## Testing

`cargo run --example animation_masks`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix animation_masks example's buttons rparrett/bevy
2 participants
@rparrett @hukasu