Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix animation_masks example's buttons #15996

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Fix animation_masks example's buttons #15996

merged 1 commit into from
Oct 19, 2024

Conversation

rparrett
Copy link
Contributor

@rparrett rparrett commented Oct 18, 2024 •
edited
Loading

Objective

Fixes #15995

Solution

Corrects a mistake made during the example migration in #15591.

AnimationControl was meant to be on the parent, not the child. So the query in update_ui was no longer matching.

Testing

cargo run --example animation_masks

@rparrett rparrett changed the title Fix animation_masks buttons Fix animation_masks example's buttons Oct 18, 2024
@rparrett rparrett added D-Trivial Nice and easy! A great choice to get started with Bevy C-Examples An addition or correction to our examples A-Animation Make things move and change over time C-Bug An unexpected or incorrect behavior labels Oct 18, 2024
@rparrett rparrett mentioned this pull request Oct 18, 2024
Closed
@tim-blackbird tim-blackbird added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 18, 2024
@mockersf mockersf added this pull request to the merge queue Oct 18, 2024
Merged via the queue into bevyengine:main with commit c65f292 Oct 19, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@mockersf mockersf mockersf approved these changes

@mweatherley mweatherley mweatherley approved these changes

Assignees
No one assigned
Labels
A-Animation Make things move and change over time C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buttons on example animation_masks does not work on main (624f573443f6bd6bb8bcf716fb1289d66a15b35b)
4 participants
@rparrett @mweatherley @mockersf @tim-blackbird