Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GamepadLobby a built-in type #3245

Closed
alice-i-cecile opened this issue Dec 4, 2021 · 0 comments
Closed

Make GamepadLobby a built-in type #3245

alice-i-cecile opened this issue Dec 4, 2021 · 0 comments
Labels
A-Input Player input via keyboard, mouse, gamepad, and more C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@alice-i-cecile
Copy link
Member

What problem does this solve or what need does it fill?

As shown in https://github.com/bevyengine/bevy/blob/main/examples/input/gamepad_input.rs, we need to track when gamepads connect.

The GamepadLobby shown there is a common and useful abstraction: external crates should be able to coordinate around its existence (and end users shouldn't have to copy boilerplate from examples).

What solution would you like?

Make GamepadLobby a built-in Bevy type and export it.

Add connection_system from that example to CoreStage::PreUpdate as part of the appropriate plugin.

Update the examples to use this new type.
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-Input Player input via keyboard, mouse, gamepad, and more C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Dec 4, 2021
@CrazyRoka CrazyRoka mentioned this issue Dec 5, 2021
Closed
bors bot pushed a commit that referenced this issue Dec 8, 2021
@CrazyRoka @cart
Add Gamepads resource (#3257)
b896294 
# Objective

Fixes #3245 

## Solution

- Move GamepadLobby to lib
- Add connection_system to InputPlugin
- Updated gamepad_input example


Co-authored-by: CrazyRoka <rokarostuk@gmail.com>
Co-authored-by: Carter Anderson <mcanders1@gmail.com>
@bors bors bot closed this as completed in 01e2141 Dec 8, 2021
@alice-i-cecile alice-i-cecile mentioned this issue Dec 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Input Player input via keyboard, mouse, gamepad, and more C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Add Gamepads resource CrazyRoka/bevy
1 participant
@alice-i-cecile