Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform propagation after adding GlobalTransform #9075

Closed
Shatur opened this issue Jul 8, 2023 · 3 comments · Fixed by #9081
Closed

Transform propagation after adding GlobalTransform #9075

Shatur opened this issue Jul 8, 2023 · 3 comments · Fixed by #9081
Labels
A-Transform Translations, rotations and scales C-Bug An unexpected or incorrect behavior

Comments

@Shatur
Copy link
Contributor

Shatur commented Jul 8, 2023

Bevy version

v0.10

What you did

I added an entity that have only Transform to hierarchy. And on the next update I added GlobalTransform.

What went wrong

I would expect GlobalTransform to be updated with Transform. But it's not. I think we should look not only for Transform change, but also for GlobalTransform add.
@Shatur Shatur added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jul 8, 2023
@SkiFire13
Copy link
Contributor

Is there a reason you're not adding the GlobalTransform together with the Transform?

@Shatur
Copy link
Contributor Author

Shatur commented Jul 8, 2023

Because of deserialization. I serialize and deserialze only necessary components and automatically insert complement ones like GlobalTransform.

@Selene-Amanita Selene-Amanita added A-Transform Translations, rotations and scales and removed S-Needs-Triage This issue needs to be labelled labels Jul 9, 2023
@Shatur Shatur mentioned this issue Jul 9, 2023
Merged
@Shatur
Copy link
Contributor Author

Shatur commented Jul 9, 2023

Opened #9081.

github-merge-queue bot pushed a commit that referenced this issue Jul 10, 2023
@Shatur
Update GlobalTransform on insertion (#9081)
c71ae26 
# Objective

`GlobalTransform` after insertion will be updated only on `Transform` or
hierarchy change.

Fixes #9075

## Solution

Update `GlobalTransform` after insertion too.

---

## Changelog

- `GlobalTransform` is now updated not only on `Transform` or hierarchy
change, but also on insertion.
ickshonpe added a commit to ickshonpe/bevy that referenced this issue Jul 12, 2023
@ickshonpe
Update GlobalTransform on insertion (bevyengine#9081)
b2492d6 
# Objective

`GlobalTransform` after insertion will be updated only on `Transform` or
hierarchy change.

Fixes bevyengine#9075

## Solution

Update `GlobalTransform` after insertion too.

---

## Changelog

- `GlobalTransform` is now updated not only on `Transform` or hierarchy
change, but also on insertion.
cart pushed a commit that referenced this issue Aug 10, 2023
@Shatur @cart
Update GlobalTransform on insertion (#9081)
25c64ec 
# Objective

`GlobalTransform` after insertion will be updated only on `Transform` or
hierarchy change.

Fixes #9075

## Solution

Update `GlobalTransform` after insertion too.

---

## Changelog

- `GlobalTransform` is now updated not only on `Transform` or hierarchy
change, but also on insertion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Transform Translations, rotations and scales C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update GlobalTransform on insertion projectharmonia/bevy
3 participants
@SkiFire13 @Shatur @Selene-Amanita