Update GlobalTransform on insertion
#9081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shatur
force-pushed
the
update-global-transform-insert
branch
from
80c2204 to
1a585be
Compare
Selene-Amanita
added
C-Bug
Selene-Amanita
approved these changes
Jul 9, 2023
paul-hansen
approved these changes
Jul 9, 2023
Selene-Amanita
added
the
S-Ready-For-Final-Review
james7132
approved these changes
Jul 10, 2023
ickshonpe
added a commit
to ickshonpe/bevy
that referenced
this pull request
Jul 12, 2023
# Objective `GlobalTransform` after insertion will be updated only on `Transform` or hierarchy change. Fixes bevyengine#9075 ## Solution Update `GlobalTransform` after insertion too. --- ## Changelog - `GlobalTransform` is now updated not only on `Transform` or hierarchy change, but also on insertion.
cart
pushed a commit
that referenced
this pull request
Aug 10, 2023
# Objective `GlobalTransform` after insertion will be updated only on `Transform` or hierarchy change. Fixes #9075 ## Solution Update `GlobalTransform` after insertion too. --- ## Changelog - `GlobalTransform` is now updated not only on `Transform` or hierarchy change, but also on insertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
GlobalTransformafter insertion will be updated only onTransformor hierarchy change.Fixes #9075
Solution
Update
GlobalTransformafter insertion too.Changelog
GlobalTransformis now updated not only onTransformor hierarchy change, but also on insertion.