Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alignment on ios simulator #10178

Merged
merged 5 commits into from
Oct 21, 2023
Merged

Fix alignment on ios simulator #10178

merged 5 commits into from
Oct 21, 2023

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Oct 18, 2023 •
edited
Loading

Objective

  • Fix iOS 17 mobile example simulator crash. #10165
  • On iOS simulator on apple silicon Macs, shader validation is going through the host, but device limits are reported for the device. They sometimes differ, and cause the validation to crash on something that should work
-[MTLDebugRenderCommandEncoder validateCommonDrawErrors:]:5775: failed assertion `Draw Errors Validation
Fragment Function(fragment_): the offset into the buffer _naga_oil_mod_MJSXM6K7OBRHEOR2NVSXG2C7OZUWK527MJUW4ZDJNZTXG_memberfog that is bound at buffer index 6 must be a multiple of 256 but was set to 448.

Solution

  • Add a custom flag when building for the simulator and override the buffer alignment

@mockersf mockersf added A-Rendering Drawing game state to the screen O-iOS Specific to the iOS mobile operating system labels Oct 18, 2023
@mockersf mockersf added this to the 0.12 milestone Oct 18, 2023
silvestrpredko
silvestrpredko reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@silvestrpredko silvestrpredko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working for me.

superdump
superdump approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mockersf I think this is fine but up to you if you want to merge or find a better way of dealing with the environment variable.

@superdump
Copy link
Contributor

@james7132 @mockersf good to merge now?

@superdump superdump added this pull request to the merge queue Oct 21, 2023
Merged via the queue into bevyengine:main with commit c362724 Oct 21, 2023
21 checks passed
robtfm pushed a commit to robtfm/bevy that referenced this pull request Oct 23, 2023
@mockersf @robtfm
Fix alignment on ios simulator (bevyengine#10178)
cd5680f 
# Objective

- Fix bevyengine#10165 
- On iOS simulator on apple silicon Macs, shader validation is going
through the host, but device limits are reported for the device. They
sometimes differ, and cause the validation to crash on something that
should work
```
-[MTLDebugRenderCommandEncoder validateCommonDrawErrors:]:5775: failed assertion `Draw Errors Validation
Fragment Function(fragment_): the offset into the buffer _naga_oil_mod_MJSXM6K7OBRHEOR2NVSXG2C7OZUWK527MJUW4ZDJNZTXG_memberfog that is bound at buffer index 6 must be a multiple of 256 but was set to 448.
```

## Solution

- Add a custom flag when building for the simulator and override the
buffer alignment
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@mockersf @ameknite
Fix alignment on ios simulator (bevyengine#10178)
0e3f7b9 
# Objective

- Fix bevyengine#10165 
- On iOS simulator on apple silicon Macs, shader validation is going
through the host, but device limits are reported for the device. They
sometimes differ, and cause the validation to crash on something that
should work
```
-[MTLDebugRenderCommandEncoder validateCommonDrawErrors:]:5775: failed assertion `Draw Errors Validation
Fragment Function(fragment_): the offset into the buffer _naga_oil_mod_MJSXM6K7OBRHEOR2NVSXG2C7OZUWK527MJUW4ZDJNZTXG_memberfog that is bound at buffer index 6 must be a multiple of 256 but was set to 448.
```

## Solution

- Add a custom flag when building for the simulator and override the
buffer alignment
@mockersf mockersf mentioned this pull request Nov 23, 2023
Closed
@NiklasEi NiklasEi mentioned this pull request Jan 6, 2024
Closed
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@mockersf
Fix alignment on ios simulator (bevyengine#10178)
bd9882b 
# Objective

- Fix bevyengine#10165 
- On iOS simulator on apple silicon Macs, shader validation is going
through the host, but device limits are reported for the device. They
sometimes differ, and cause the validation to crash on something that
should work
```
-[MTLDebugRenderCommandEncoder validateCommonDrawErrors:]:5775: failed assertion `Draw Errors Validation
Fragment Function(fragment_): the offset into the buffer _naga_oil_mod_MJSXM6K7OBRHEOR2NVSXG2C7OZUWK527MJUW4ZDJNZTXG_memberfog that is bound at buffer index 6 must be a multiple of 256 but was set to 448.
```

## Solution

- Add a custom flag when building for the simulator and override the
buffer alignment
@sampettersson sampettersson mentioned this pull request Feb 22, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 23, 2024
@sampettersson
FIX: iOS Simulator not rendering due to missing CUBE_ARRAY_TEXTURES (#…
caa7ec6 
…12052)

This PR closes #11978

# Objective

Fix rendering on iOS Simulators.

iOS Simulator doesn't support the capability CUBE_ARRAY_TEXTURES, since
0.13 this started to make iOS Simulator not render anything with the
following message being outputted:

```
2024-02-19T14:59:34.896266Z ERROR bevy_render::render_resource::pipeline_cache: failed to create shader module: Validation Error

Caused by:
    In Device::create_shader_module
    
Shader validation error: 


    Type [40] '' is invalid
    Capability Capabilities(CUBE_ARRAY_TEXTURES) is required
```

## Solution

- Split up NO_ARRAY_TEXTURES_SUPPORT into both NO_ARRAY_TEXTURES_SUPPORT
and NO_CUBE_ARRAY_TEXTURES_SUPPORT and correctly apply
NO_ARRAY_TEXTURES_SUPPORT for iOS Simulator using the cfg flag
introduced in #10178.

---

## Changelog

### Fixed
- Rendering on iOS Simulator due to missing CUBE_ARRAY_TEXTURES support.

---------

Co-authored-by: Sam Pettersson <sam.pettersson@geoguessr.com>
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
@sampettersson @msvbg
FIX: iOS Simulator not rendering due to missing CUBE_ARRAY_TEXTURES (b…
86fd543 
…evyengine#12052)

This PR closes bevyengine#11978

# Objective

Fix rendering on iOS Simulators.

iOS Simulator doesn't support the capability CUBE_ARRAY_TEXTURES, since
0.13 this started to make iOS Simulator not render anything with the
following message being outputted:

```
2024-02-19T14:59:34.896266Z ERROR bevy_render::render_resource::pipeline_cache: failed to create shader module: Validation Error

Caused by:
    In Device::create_shader_module
    
Shader validation error: 


    Type [40] '' is invalid
    Capability Capabilities(CUBE_ARRAY_TEXTURES) is required
```

## Solution

- Split up NO_ARRAY_TEXTURES_SUPPORT into both NO_ARRAY_TEXTURES_SUPPORT
and NO_CUBE_ARRAY_TEXTURES_SUPPORT and correctly apply
NO_ARRAY_TEXTURES_SUPPORT for iOS Simulator using the cfg flag
introduced in bevyengine#10178.

---

## Changelog

### Fixed
- Rendering on iOS Simulator due to missing CUBE_ARRAY_TEXTURES support.

---------

Co-authored-by: Sam Pettersson <sam.pettersson@geoguessr.com>
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
@sampettersson @msvbg
FIX: iOS Simulator not rendering due to missing CUBE_ARRAY_TEXTURES (b…
cba2592 
…evyengine#12052)

This PR closes bevyengine#11978

# Objective

Fix rendering on iOS Simulators.

iOS Simulator doesn't support the capability CUBE_ARRAY_TEXTURES, since
0.13 this started to make iOS Simulator not render anything with the
following message being outputted:

```
2024-02-19T14:59:34.896266Z ERROR bevy_render::render_resource::pipeline_cache: failed to create shader module: Validation Error

Caused by:
    In Device::create_shader_module
    
Shader validation error: 


    Type [40] '' is invalid
    Capability Capabilities(CUBE_ARRAY_TEXTURES) is required
```

## Solution

- Split up NO_ARRAY_TEXTURES_SUPPORT into both NO_ARRAY_TEXTURES_SUPPORT
and NO_CUBE_ARRAY_TEXTURES_SUPPORT and correctly apply
NO_ARRAY_TEXTURES_SUPPORT for iOS Simulator using the cfg flag
introduced in bevyengine#10178.

---

## Changelog

### Fixed
- Rendering on iOS Simulator due to missing CUBE_ARRAY_TEXTURES support.

---------

Co-authored-by: Sam Pettersson <sam.pettersson@geoguessr.com>
mockersf pushed a commit that referenced this pull request Feb 27, 2024
@sampettersson @mockersf
FIX: iOS Simulator not rendering due to missing CUBE_ARRAY_TEXTURES (#…
a8fa1f7 
…12052)

This PR closes #11978

# Objective

Fix rendering on iOS Simulators.

iOS Simulator doesn't support the capability CUBE_ARRAY_TEXTURES, since
0.13 this started to make iOS Simulator not render anything with the
following message being outputted:

```
2024-02-19T14:59:34.896266Z ERROR bevy_render::render_resource::pipeline_cache: failed to create shader module: Validation Error

Caused by:
    In Device::create_shader_module
    
Shader validation error: 


    Type [40] '' is invalid
    Capability Capabilities(CUBE_ARRAY_TEXTURES) is required
```

## Solution

- Split up NO_ARRAY_TEXTURES_SUPPORT into both NO_ARRAY_TEXTURES_SUPPORT
and NO_CUBE_ARRAY_TEXTURES_SUPPORT and correctly apply
NO_ARRAY_TEXTURES_SUPPORT for iOS Simulator using the cfg flag
introduced in #10178.

---

## Changelog

### Fixed
- Rendering on iOS Simulator due to missing CUBE_ARRAY_TEXTURES support.

---------

Co-authored-by: Sam Pettersson <sam.pettersson@geoguessr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvestrpredko silvestrpredko silvestrpredko left review comments

@robtfm robtfm robtfm approved these changes

@james7132 james7132 james7132 approved these changes

@superdump superdump superdump approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen O-iOS Specific to the iOS mobile operating system
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.

iOS 17 mobile example simulator crash.
5 participants
@mockersf @superdump @james7132 @silvestrpredko @robtfm