Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use previous ubuntu version in validation jobs #11135

Closed
wants to merge 2 commits into from

Conversation

cart
Copy link
Member

@cart cart commented Dec 29, 2023

Objective

xvfb is failing to start, likely due to a Mesa update. This has happened before: #6810

https://github.com/bevyengine/bevy/actions/runs/7359665469/job/20034758381

Solution

Swap ubuntu-latest for ubuntu-20.04 (the previous ubuntu version) for the failing jobs. Lets hope this works!

We should revert this once ubuntu-latest is working again.

@cart cart added C-Bug An unexpected or incorrect behavior A-Build-System Related to build systems or continuous integration labels Dec 29, 2023
@cart
Copy link
Member Author

cart commented Dec 29, 2023

I've cherry-picked the commit from this PR because clippy is also broken: https://github.com/bevyengine/bevy/pull/11123/commits

@cart cart enabled auto-merge December 29, 2023 23:58
@cart
Copy link
Member Author

cart commented Dec 29, 2023

Enabling auto-merge because the validation jobs run in the merge queue

@cart cart added this pull request to the merge queue Dec 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 30, 2023
@alice-i-cecile
Copy link
Member

Adoption of #11123

@stepancheg
Copy link
Contributor

stepancheg commented Dec 30, 2023

I suspect we need something like this:

xvfb-run --error-file=$TMPDIR/xvfb-run.log ... || cat $TMPDIR/xvfb-run.log

(The default is /dev/null.)

@hymm
Copy link
Contributor

hymm commented Dec 30, 2023

could try pinning the mesa versions. Maybe something like this?

sudo apt install -y xvfb libegl1-mesa=23.3.1~kisak1~f libgl1-mesa-dri=23.3.1~kisak1~f libxcb-xfixes0-dev mesa-vulkan-drivers=23.3.1~kisak1~f

@alice-i-cecile alice-i-cecile added the P-Critical This must be fixed immediately or contributors or users will be severely impacted label Dec 30, 2023
@hymm
Copy link
Contributor

hymm commented Dec 30, 2023

Alternative #11143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior P-Critical This must be fixed immediately or contributors or users will be severely impacted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants