Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - gltf loader: do not use the taskpool for only one task #3577

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - gltf loader: do not use the taskpool for only one task #3577

wants to merge 4 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Jan 6, 2022

Objective

Solution

  • Do not use the task pool when there is only one texture to load

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jan 6, 2022
@alice-i-cecile alice-i-cecile added A-Assets Load files from disk to use for things like images, models, and sounds C-Performance A change motivated by improving speed, memory usage or compile times and removed S-Needs-Triage This issue needs to be labelled labels Jan 6, 2022
@cart
Copy link
Member

cart commented Jan 7, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jan 7, 2022
@mockersf
gltf loader: do not use the taskpool for only one task (#3577)
015da72 
# Objective

- Fix the case mentioned in #2725 (comment).
- On a machine with 4 cores, so 1 thread for assets, loading a gltf with only one textures hangs all asset loading

## Solution

- Do not use the task pool when there is only one texture to load


Co-authored-by: François <8672791+mockersf@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jan 7, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title gltf loader: do not use the taskpool for only one task [Merged by Bors] - gltf loader: do not use the taskpool for only one task Jan 7, 2022
@bors bors bot closed this Jan 7, 2022
@mockersf mockersf mentioned this pull request Jan 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Performance A change motivated by improving speed, memory usage or compile times
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @cart @alice-i-cecile