Update icosphere dependency and add a limit to subdivisions. #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
reviewed
Aug 28, 2020
crates/bevy_render/src/mesh/mesh.rs
Outdated
| let temp_sphere = Hexasphere::new(sphere.subdivisions, |_| ()); | ||
|
|
||
| panic!( | ||
| "Cannot create an icosphere of {} subdivisions due to there being more than 2¹⁶ vertices being generated: {} (Limited to 65535 vertices or 79 subdivisions)", |
There was a problem hiding this comment.
I don't know if that message using the unicode ¹⁶ is potentially a compatability hazard. It might be worth saying 2¹⁶ (65536). Also I imagine we can only actually have 65535 vertices anyway.
There was a problem hiding this comment.
I don't think it's necessary to include the 2^16 anyway. I think that just sticking to the extra note at the end which remarks there being a limit is the correct call.
|
Awesome. Thanks! |
mrk-its
pushed a commit
to mrk-its/bevy
that referenced
this pull request
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newest version of
hexasphereis essentially the same as the one being used currently, it just happens to be that I made an error when publishing0.1.7and had to yank it. Unfortunately, the theoretical0.1.8would've broken compatibility for standalone users of0.1.7(but not0.1.6), so I decided to bump it to1.0.0.The limit to subdivisions occurs because subdivision 80 produces 65612 vertices, which is more than currently supported by the 16 bit indices (which caps out at 65535 vertices).