Resource change tracking #388
Conversation
karroffel
added
A-ECS
|
It may be more user friendly that |
…esources will only be called if all fetched Resources are Some(). This is done to implement ChangedRes, which is Some iff the Resource has been changed.
|
I'm taking a look at this now. Thanks for your patience! |
|
I accidentally submitted the review too early (im trying out the VSCode pull request extension). I'd say don't make any of the suggested changes yet, I'm still forming opinions. I'll respond here when im finished. |
There was a problem hiding this comment.
It may be more user friendly that FetchResource::get() always return an Option, that ChangedRes returns Some only if the resource has changed, and that in into_system the systems are called only if the resources are all Some.
Returning an Option does seem like a cleaner/more user friendly approach. It looks like you implemented that and reverted it. What motivated that?
To implement OrRes, I had to be able to get data even in the None case. But it is better now by separating get() into get() and is_some(). |
|
Yeah that seems reasonable to me. For now, this seems good. In general Option vs is_some is abstracted out from user code, so I'm cool with using this for now / seeing how people feel about it. |
* Add mutated tracker on resources and ChangedRes query for added or mutated resources. * ResMut:::new() now takes a reference to a 'mutated' flag in its archetype. * Change FetchResource so that get() returns an Option. Systems using Resources will only be called if all fetched Resources are Some(). This is done to implement ChangedRes, which is Some iff the Resource has been changed. * Add OrRes for a logical or in tuples of Resource queries. * Separate resource query get() in is_some() and get() methods for clarity * Remove unneeded unsafe * Change ResMut::new()
Add mutated tracker on resources and ChangedRes query for added or mutated resources.
#62
The ChangedRes<T: Resource> query yields Option<&T>, with None if the resource has not been added or mutated.