Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Make MaterialPipelineKey<T> fields public #4508

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Make MaterialPipelineKey<T> fields public #4508

wants to merge 1 commit into from

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Apr 17, 2022 •
edited
Loading

Objective

Fixes #4507. This comment provides a very good explanation: #4507 (comment).

Solution

Make MaterialPipelineKey fields public.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Apr 17, 2022
@Shatur Shatur mentioned this pull request Apr 17, 2022
Closed
@superdump superdump added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use P-Regression Functionality that used to work but no longer does. Add a test for this! and removed S-Needs-Triage This issue needs to be labelled labels Apr 17, 2022
superdump
superdump approved these changes Apr 17, 2022
View reviewed changes
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see what harm this could do, and I do see the use cases it prevents. I'm for it.

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 17, 2022
@cart
Copy link
Member

cart commented Apr 17, 2022

bors r+

bors bot pushed a commit that referenced this pull request Apr 17, 2022
@Shatur
Make MaterialPipelineKey<T> fields public (#4508)
83e2774 
# Objective

Fixes #4507. This comment provides a very good explanation: #4507 (comment).

## Solution

Make `MaterialPipelineKey` fields public.
@bors
Copy link
Contributor

bors bot commented Apr 17, 2022

Timed out.

@superdump
Copy link
Contributor

bors retry

bors bot pushed a commit that referenced this pull request Apr 18, 2022
@Shatur
Make MaterialPipelineKey<T> fields public (#4508)
06d709b 
# Objective

Fixes #4507. This comment provides a very good explanation: #4507 (comment).

## Solution

Make `MaterialPipelineKey` fields public.
@bors
Copy link
Contributor

bors bot commented Apr 18, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Make MaterialPipelineKey<T> fields public [Merged by Bors] - Make MaterialPipelineKey<T> fields public Apr 18, 2022
@bors bors bot closed this Apr 18, 2022
@Shatur Shatur mentioned this pull request Apr 19, 2022
Closed
@mockersf mockersf mentioned this pull request Jul 5, 2022
Closed
MonaMayrhofer pushed a commit to MonaMayrhofer/bevy that referenced this pull request Jul 29, 2022
@Shatur @MonaMayrhofer
Make MaterialPipelineKey<T> fields public (bevyengine#4508)
cb05b57 
# Objective

Fixes bevyengine#4507. This comment provides a very good explanation: bevyengine#4507 (comment).

## Solution

Make `MaterialPipelineKey` fields public.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@Shatur @ItsDoot
Make MaterialPipelineKey<T> fields public (bevyengine#4508)
f956102 
# Objective

Fixes bevyengine#4507. This comment provides a very good explanation: bevyengine#4507 (comment).

## Solution

Make `MaterialPipelineKey` fields public.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@superdump superdump superdump approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MaterialPipelineKey should have public fields
4 participants
@Shatur @cart @superdump @mockersf