Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add more tests to input.rs #4522

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Add more tests to input.rs #4522

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 18, 2022

Objective

Solution

  • Add more tests to input.rs inside of bevy_input.

Note

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Apr 18, 2022
@ghost ghost added A-Input Player input via keyboard, mouse, gamepad, and more C-Testing A change that impacts how we test Bevy or how users test their apps and removed S-Needs-Triage This issue needs to be labelled labels Apr 18, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 20, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 25, 2022
Add more tests to input.rs (#4522)
c64f2a1 
# Objective

- Part of the splitting process of #3692.

## Solution

- Add more tests to `input.rs` inside of `bevy_input`.

## Note

- The tests would now catch a change like #4410 and fail accordingly.
@bors
Copy link
Contributor

bors bot commented Apr 25, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add more tests to input.rs [Merged by Bors] - Add more tests to input.rs Apr 25, 2022
@bors bors bot closed this Apr 25, 2022
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
@exjam
Add more tests to input.rs (bevyengine#4522)
27f9744 
# Objective

- Part of the splitting process of bevyengine#3692.

## Solution

- Add more tests to `input.rs` inside of `bevy_input`.

## Note

- The tests would now catch a change like bevyengine#4410 and fail accordingly.
@ghost ghost deleted the add_input_tests branch August 7, 2022 08:27
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@ItsDoot
Add more tests to input.rs (bevyengine#4522)
2776899 
# Objective

- Part of the splitting process of bevyengine#3692.

## Solution

- Add more tests to `input.rs` inside of `bevy_input`.

## Note

- The tests would now catch a change like bevyengine#4410 and fail accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Input Player input via keyboard, mouse, gamepad, and more C-Testing A change that impacts how we test Bevy or how users test their apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alice-i-cecile @IceSentry