Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix lifetime bound on From impl for NonSendMut -> Mut #5560

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix lifetime bound on From impl for NonSendMut -> Mut #5560

wants to merge 1 commit into from

Conversation

maccesch
Copy link
Contributor

@maccesch maccesch commented Aug 3, 2022

Objective

Fixes #5456

@alice-i-cecile
Copy link
Member

Can you change the PR title to "Fix bound on From impl for NonSendMut -> Mut" so then it's more legible in the commit history? :)

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it C-Bug An unexpected or incorrect behavior labels Aug 3, 2022
@maccesch maccesch changed the title Fixes #5456 Fix lifetime bound on From impl for NonSendMut -> Mut Aug 3, 2022
@maccesch
Copy link
Contributor Author

maccesch commented Aug 3, 2022

Oh I see! Sorry for the lazy title

djeedai
djeedai approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@djeedai djeedai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@alice-i-cecile alice-i-cecile added this to the Bevy 0.8.1 milestone Aug 3, 2022
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Aug 3, 2022 •
edited
Loading

Added to the milestone as this is trivially correct. I wouldn't cut a release for it though.

EDIT: consensus is against me :p

@alice-i-cecile alice-i-cecile removed this from the Bevy 0.8.1 milestone Aug 3, 2022
@cart
Copy link
Member

cart commented Aug 4, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 4, 2022
@maccesch
Fix lifetime bound on From impl for NonSendMut -> Mut (#5560)
765e8d7 
# Objective

Fixes #5456
@bors
Copy link
Contributor

bors bot commented Aug 4, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix lifetime bound on From impl for NonSendMut -> Mut [Merged by Bors] - Fix lifetime bound on From impl for NonSendMut -> Mut Aug 4, 2022
@bors bors bot closed this Aug 4, 2022
@maccesch maccesch deleted the fix/lifetime-typo branch August 4, 2022 23:44
maccesch added a commit to Synphonyte/bevy that referenced this pull request Aug 5, 2022
@maccesch
Fix lifetime bound on From impl for NonSendMut -> Mut (bevyengi…
02b0915 
…ne#5560)

# Objective

Fixes bevyengine#5456
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@maccesch @james7132
Fix lifetime bound on From impl for NonSendMut -> Mut (bevyengi…
8ddb54b 
…ne#5560)

# Objective

Fixes bevyengine#5456
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@maccesch @ItsDoot
Fix lifetime bound on From impl for NonSendMut -> Mut (bevyengi…
11db0b6 
…ne#5560)

# Objective

Fixes bevyengine#5456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@djeedai djeedai djeedai approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

From<NonSendMut<'a, T>> for Mut<'a, T> has wrong trait bound Resource instead of 'static
5 participants
@maccesch @alice-i-cecile @cart @djeedai @mockersf