Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

From<NonSendMut<'a, T>> for Mut<'a, T> has wrong trait bound Resource instead of 'static #5456

Closed
djeedai opened this issue Jul 25, 2022 · 2 comments
Closed

From<NonSendMut<'a, T>> for Mut<'a, T> has wrong trait bound Resource instead of 'static #5456

djeedai opened this issue Jul 25, 2022 · 2 comments
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@djeedai
Copy link
Contributor

djeedai commented Jul 25, 2022

Copy/paste typo in #5438 led to Resource trait bound instead of 'static. Fix:

- impl<'a, T: Resource> From<NonSendMut<'a, T>> for Mut<'a, T> {
+ impl<'a, T: 'static> From<NonSendMut<'a, T>> for Mut<'a, T> {

My bad!
@djeedai djeedai added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jul 25, 2022
@djeedai djeedai mentioned this issue Jul 25, 2022
Closed
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events and removed S-Needs-Triage This issue needs to be labelled labels Jul 25, 2022
@alice-i-cecile
Copy link
Member

Ah right, I'd forgotten that we haven't changed that yet... Make a follow-up PR and we'll get it merged.

@alice-i-cecile alice-i-cecile added the D-Trivial Nice and easy! A great choice to get started with Bevy label Jul 25, 2022
maccesch added a commit to Synphonyte/bevy that referenced this issue Aug 3, 2022
@maccesch
fixes bevyengine#5456
a60bde1
@maccesch maccesch mentioned this issue Aug 3, 2022
Closed
@alice-i-cecile
Copy link
Member

bevy/crates/bevy_ecs/src/change_detection.rs

Line 220 in 6a1ba9c

impl<'a, T: Resource> From<NonSendMut<'a, T>> for Mut<'a, T> {

maccesch added a commit to Synphonyte/bevy that referenced this issue Aug 3, 2022
@maccesch
fixes bevyengine#5456
fab1793
@maccesch maccesch mentioned this issue Aug 3, 2022
Closed
@bors bors bot closed this as completed in 765e8d7 Aug 4, 2022
maccesch added a commit to Synphonyte/bevy that referenced this issue Aug 5, 2022
@maccesch
Fix lifetime bound on From impl for NonSendMut -> Mut (bevyengi…
02b0915 
…ne#5560)

# Objective

Fixes bevyengine#5456
james7132 pushed a commit to james7132/bevy that referenced this issue Oct 28, 2022
@maccesch @james7132
Fix lifetime bound on From impl for NonSendMut -> Mut (bevyengi…
8ddb54b 
…ne#5560)

# Objective

Fixes bevyengine#5456
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@maccesch @ItsDoot
Fix lifetime bound on From impl for NonSendMut -> Mut (bevyengi…
11db0b6 
…ne#5560)

# Objective

Fixes bevyengine#5456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Fix lifetime bound on From impl for NonSendMut -> Mut Synphonyte/bevy
2 participants
@alice-i-cecile @djeedai