Update ahash requirement from 0.7.0 to 0.8.0 #5700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [ahash](https://github.com/tkaitchuck/ahash) to permit the latest version. - [Release notes](https://github.com/tkaitchuck/ahash/releases) - [Commits](tkaitchuck/aHash@v0.7.6...v0.8.0) --- updated-dependencies: - dependency-name: ahash dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
C-Dependencies
|
This is blocked on |
|
This seems to be unblocked now, since |
|
closing in favour of #8623 |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
alice-i-cecile
pushed a commit
that referenced
this pull request
May 23, 2023
# Objective - Update `ahash` and `hashbrown` - Alternative to #5700 and #7420 ## Solution - Update the dependencies This is a breaking change because we were creating two fixed hashers with [`AHasher::new_with_keys`](https://docs.rs/ahash/0.7.6/ahash/struct.AHasher.html#method.new_with_keys), which was a method that existed only for testing purpose and has been removed from public. I replaced it with [`RandomState::with_seeds`](https://docs.rs/ahash/0.8.3/ahash/random_state/struct.RandomState.html#method.with_seeds) which is the proper way to get a fixed hasher (see [this table](https://docs.rs/ahash/0.8.3/ahash/random_state/struct.RandomState.html)). This means that hashes won't be the same across versions --- ## Migration Guide - If you were using hashes to an asset or using one of the fixed hasher exposed by Bevy with a previous version, you will have to update the hashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on ahash to permit the latest version.
Release notes
Sourced from ahash's releases.
Commits
24491f6Simplify interface (#121)76dd8d2Issue #117: Support compiling without min_specialization and stdsimd4c340f5fix aes acceleration on aarch64 (#116)cc927daUpdate LICENSE-MITfbd7485Improve codegen for mixing in length (#112)e745544Merge branch 'master' of github.com:tkaitchuck/aHash2c1daf1More pre-mixing to guard against partially weak keysf2aecc0Implement deserialize_in_place() in Deserialize for AHashMap and AHashSet (#110)5e55048Add type-alias feature to make it more of a drop in replacement for std Hash[...c069bdcAdded From<array> for AHashSet & AHashMap. (#109)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)