Update ahash requirement from 0.7.0 to 0.8.3 #7420
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [ahash](https://github.com/tkaitchuck/ahash) to permit the latest version. - [Release notes](https://github.com/tkaitchuck/ahash/releases) - [Commits](tkaitchuck/aHash@v0.7.6...v0.8.3) --- updated-dependencies: - dependency-name: ahash dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
C-Dependencies
|
Since they reduced the visibility of Old#[inline]
fn build_hasher(&self) -> AHasher {
AHasher::new_with_keys(
0b1001010111101110000001001100010000000011001001101011001001111000,
0b1100111101101011011110001011010100000100001111100011010011010101,
)
}New#[inline]
fn build_hasher(&self) -> AHasher {
let mut hasher = BuildHasher::build_hasher(self);
hasher.write_u64(1001010111101110000001001100010000000011001001101011001001111000);
hasher.write_u64(0b1100111101101011011110001011010100000100001111100011010011010101);
return hasher;
}(I don't know a lot about hashing, I'm just trying to solve a dependency issue 😅) |
|
No it's not the same. Maybe trying with https://docs.rs/ahash/latest/ahash/random_state/struct.RandomState.html#method.with_seeds ? |
|
The with_seeds method almost has the same behaviour, the question is whether one needs the exactly same behaviour. I'm guessing not. The old version did the following with_seeds does this What's the difference? Well, the old version xors the keys with the PI constant, while the new version uses the PI2 constant. |
|
closing in favour of #8623 |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
# Objective - Update `ahash` and `hashbrown` - Alternative to #5700 and #7420 ## Solution - Update the dependencies This is a breaking change because we were creating two fixed hashers with [`AHasher::new_with_keys`](https://docs.rs/ahash/0.7.6/ahash/struct.AHasher.html#method.new_with_keys), which was a method that existed only for testing purpose and has been removed from public. I replaced it with [`RandomState::with_seeds`](https://docs.rs/ahash/0.8.3/ahash/random_state/struct.RandomState.html#method.with_seeds) which is the proper way to get a fixed hasher (see [this table](https://docs.rs/ahash/0.8.3/ahash/random_state/struct.RandomState.html)). This means that hashes won't be the same across versions --- ## Migration Guide - If you were using hashes to an asset or using one of the fixed hasher exposed by Bevy with a previous version, you will have to update the hashes
Updates the requirements on ahash to permit the latest version.
Release notes
Sourced from ahash's releases.
Commits
f9acd50Bump version for 0.8.3 releasedba4099Add more robust quality test (#151)fa13fafFix benches (#142)2ae75f6Add missing #[inline] to get_fixed_seeds (#149)ac1fa3cFix build status badge (#150)d9d24afBump version for release4019a16Reverting tkaitchuck/aHash#129 (#145)673c17cBump version for release2f39c89Improve documentation around keys (#139)2c1a088Run smhasher test with weaker keysYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)