[Merged by Bors] - run clear trackers on render world #6878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should probably add some docs to sub apps that they need to add clear_trackers to the sub app too or just call it for every sub app world somewhere, but not sure there's a good place for that. |
james7132
added
A-Rendering
james7132
approved these changes
Dec 7, 2022
Aceeri
approved these changes
Dec 7, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
would it be better to call it here: bevy/crates/bevy_app/src/app.rs Line 154 in 530be10 and add sub_app.app.world.clear_trackers(); |
|
That works. Last night I was a little worried what that would mean for pipelined rendering, but I can put it in the sub app run function in that pr. |
hymm
force-pushed
the
clear-trackers-on-render-world
branch
from
a971b74 to
9b13f4d
Compare
|
Moved the call to clear_trackers into It does bring up the question of whether I should move the call for the main world into |
hymm
added a commit
to hymm/bevy
that referenced
this pull request
Dec 7, 2022
Probably should since it's currently only found via a runtime addition to |
hymm
added
the
M-Needs-Migration-Guide
james7132
reviewed
Dec 7, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 11, 2022
# Objective - Fixes #6417 ## Solution - clear_trackers was not being called on the render world. This causes the removed components vecs to continuously grow. This PR adds clear trackers to the end of RenderStage::Cleanup ## Migration Guide The call to `clear_trackers` in `App` has been moved from the schedule to App::update for the main world and calls to `clear_trackers` have been added for sub_apps in the same function. This was due to needing stronger guarantees. If clear_trackers isn't called on a world it can lead to memory leaks in `RemovedComponents`.
bors
bot
changed the title
hymm
added a commit
to hymm/bevy
that referenced
this pull request
Dec 12, 2022
hymm
added a commit
to hymm/bevy
that referenced
this pull request
Dec 15, 2022
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective - Fixes bevyengine#6417 ## Solution - clear_trackers was not being called on the render world. This causes the removed components vecs to continuously grow. This PR adds clear trackers to the end of RenderStage::Cleanup ## Migration Guide The call to `clear_trackers` in `App` has been moved from the schedule to App::update for the main world and calls to `clear_trackers` have been added for sub_apps in the same function. This was due to needing stronger guarantees. If clear_trackers isn't called on a world it can lead to memory leaks in `RemovedComponents`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Fixes bevyengine#6417 ## Solution - clear_trackers was not being called on the render world. This causes the removed components vecs to continuously grow. This PR adds clear trackers to the end of RenderStage::Cleanup ## Migration Guide The call to `clear_trackers` in `App` has been moved from the schedule to App::update for the main world and calls to `clear_trackers` have been added for sub_apps in the same function. This was due to needing stronger guarantees. If clear_trackers isn't called on a world it can lead to memory leaks in `RemovedComponents`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Migration Guide
The call to
clear_trackersinApphas been moved from the schedule to App::update for the main world and calls toclear_trackershave been added for sub_apps in the same function. This was due to needing stronger guarantees. If clear_trackers isn't called on a world it can lead to memory leaks inRemovedComponents. If you were ordering systems with clear_trackers this is no longer possible.