[Merged by Bors] - Cascaded shadow maps. #7064

danchia · 2022-12-30T10:35:30Z

Co-authored-by: Robert Swain robert.swain@gmail.com

Objective

Implements cascaded shadow maps for directional lights, which produces better quality shadows without needing excessively large shadow maps.

Fixes #3629

Before

After

Solution

Rather than rendering a single shadow map for directional light, the view frustum is divided into a series of cascades, each of which gets its own shadow map. The correct cascade is then sampled for shadow determination.

Changelog

Directional lights now use cascaded shadow maps for improved shadow quality.

Migration Guide

You no longer have to manually specify a shadow_projection for a directional light, and these settings should be removed. If customization of how cascaded shadow maps work is desired, modify the CascadeShadowConfig component instead.

mockersf · 2022-12-30T17:58:29Z

Nice!

Your branch is 78 commits late from main and has conflicts, could you resolve those?

danchia · 2022-12-30T23:47:10Z

Nice!

Your branch is 78 commits late from main and has conflicts, could you resolve those?

Rebased + fixed a bug to do with shader indexing.

superdump

Initial pass.

crates/bevy_pbr/src/bundle.rs

crates/bevy_pbr/src/render/depth.wgsl

crates/bevy_pbr/src/render/mesh_view_types.wgsl

crates/bevy_pbr/src/light.rs

crates/bevy_pbr/src/render/light.rs

superdump · 2022-12-31T09:31:52Z

crates/bevy_pbr/src/render/light.rs


    let spot_light_shadow_maps_count = point_lights
        .iter()
        .filter(|(_, light)| light.shadows_enabled && light.spot_light_angles.is_some())
        .count()
-        .min(max_texture_array_layers - directional_shadow_maps_count);
+        .min(max_texture_array_layers - directional_shadow_enabled_count * MAX_CASCADES_PER_LIGHT);


This is being conservative, right? If the MAX_CASCADES_PER_LIGHT is higher than the actual then we're leaving some array layers empty, potentially. This is fine, just want to check my understanding.

Yes this is conservative. I think it's addressable, but the PR is relatively large already so I will try and tackle in a follow up.

crates/bevy_pbr/src/render/light.rs

examples/tools/scene_viewer/scene_viewer_plugin.rs

superdump · 2022-12-31T10:33:12Z

Performance seems to be very poor on this PR with shadows enabled even on a fairly simple scene like the flight helmet using the scene_viewer example without any arguments.

danchia · 2022-12-31T10:41:59Z

Performance seems to be very poor on this PR with shadows enabled even on a fairly simple scene like the flight helmet using the scene_viewer example without any arguments.

Interesting, I will take a closer look as to why

superdump · 2022-12-31T13:59:06Z

As a note, this is on an M1 Max. I'm continuing investigations on Discord as it will be noisy to spam random findings here. :)

superdump · 2023-01-01T17:48:19Z

With changes like those in #7069 also for the scope of this PR we were able to keep performance in check. :)

danchia · 2023-01-01T18:18:57Z

I made changes to the shader to follow what #7069 did specifically for directional shadowing code that I modified, left the rest of the optimizations to that PR.

superdump · 2023-01-01T18:19:42Z

I'll give this another review pass when I can.

# Objective - The #7064 PR had poor performance on an M1 Max in MacOS due to significant overuse of registers resulting in 'register spilling' where data that would normally be stored in registers on the GPU is instead stored in VRAM. The latency to read from/write to VRAM instead of registers incurs a significant performance penalty. - Use of registers is a limiting factor in shader performance. Assignment of a struct from memory to a local variable can incur copies. Passing a variable that has struct type as an argument to a function can also incur copies. As such, these two cases can incur increased register usage and decreased performance. ## Solution - Remove/avoid a number of assignments of light struct type data to local variables. - Remove/avoid a number of passing light struct type variables/data as value arguments to shader functions.

mockersf · 2023-01-03T10:46:43Z

I tried comparing example lighting for main and this pr

output.mp4

Shadow borders are sometime less clean, and there's something strange happening in the back at 5 seconds

superdump · 2023-01-03T11:06:23Z

Good catch @mockersf ! The aliased edges is a cascade bound tweaking issue. By default we're configuring 4 cascades with the first cascade far bound at 5 units, and the last at 1000 units. This scene is small so 1000 units is way too much. But also we probably just want to adjust a bit to something that looks good out of the box with the current 2x2 Percentage Closer Filtering (using multiple samples of the shadow map to filter the edges).

However, the bug in the back behind the wall is something we will need to fix. It looks like the red and blue light are making it through the wall...

The red and blue lights are point lights.

mockersf · 2023-01-03T12:41:46Z

WASM also has something funny:

cascaded-wasm.mp4

danchia · 2023-01-03T17:14:26Z

WASM also has something funny:

cascaded-wasm.mp4

Ah, for WASM (which I assume uses the webgl feature) we should probably change the default cascade config to only 1 cascade, and some more reasonable far bound that 1000. webgl doesn't have texture arrays, so we can only use one cascade.

But I think WASM users are going to have to manually configure the far bound for best results still. since achieving a tight bound is important for quality vs shadow map resolution.

danchia · 2023-01-03T17:26:45Z

I will look into what's going on with the point lights bleeding through the wall.

danchia · 2023-01-08T10:14:55Z

Fixed the weird shadow light bleeding problems. Turns out my depth clamp (as written) only works on ortho matrices, so I changed the code to only turn on the clamping for directional lights.
Updating lighting example to show how / when to customize the cascades config
Updated the default cascades config for webgl to only use 1 cascade, covering a smaller shadow distance.

app.2023-01-08.02-11-37.mp4

superdump

This looks pretty good to me. I'm going to do a bit more testing locally but my finger is hovering over approval. We can rebase after #6284 is merged.

crates/bevy_pbr/src/light.rs

crates/bevy_pbr/src/render/depth.wgsl

crates/bevy_pbr/src/render/shadows.wgsl

superdump · 2023-01-18T19:15:39Z

examples/3d/load_gltf.rs

@@ -21,18 +21,8 @@ fn setup(mut commands: Commands, asset_server: Res<AssetServer>) {
        transform: Transform::from_xyz(0.7, 0.7, 1.0).looking_at(Vec3::new(0.0, 0.3, 0.0), Vec3::Y),
        ..default()
    });
-    const HALF_SIZE: f32 = 1.0;
    commands.spawn(DirectionalLightBundle {
        directional_light: DirectionalLight {


Probably also tweak the cascades here so this one looks good. It's kind of the fanciest-looking in-repo PBR example.

rparrett · 2023-01-18T23:19:04Z

Should there be a warning or something when CascadeShadowConfig has num_cascades > MAX_CASCADES_PER_LIGHT?

In a test scene where the camera was pretty far from the action, bumping that value up resulted in shadows mysteriously disappearing (as only the first 4 cascades were used?).

danchia · 2023-01-19T00:06:24Z

Should there be a warning or something when CascadeShadowConfig has num_cascades > MAX_CASCADES_PER_LIGHT?

In a test scene where the camera was pretty far from the action, bumping value up that resulted in shadows mysteriously disappearing (as only the first 4 cascades were used?).

That's a good idea, will look into it.

danchia · 2023-01-22T07:19:10Z

I've tweaked load_gltf to shrink the distances which improves quality, and have rebased.

rparrett · 2023-01-22T15:44:36Z

I have a couple doc suggestions.

In a scenario like a 2.5d/3d strategy game where the camera is potentially very far away from the action, is my only option for increasing shadow map waste tweaking nearest_bound?

And am I right that this is effectively only pushing the end of the first cascade, potentially covering my objects with more cascades, but still wasting the entire first cascade?

Maybe this diagram will help:

Camera | C1 | C2   | C3      | C4        | shadow_maximum_distance
Camera | C1          | C2 | C3  | C4     | shadow_maximum_distance (nearest_bound tweaked)
                     <<Things           >>

As a user, it feels a bit unintuitive. The docs aren't incorrect or anything, but i feel like spelling out the fact that nearest_bound is not minimum_shadow_distance more explicitly might have helped me.
On WASM, or when there's otherwise only 1 cascade, nearest_bound is ignored and this doesn't seem to be mentioned anywhere.

(Don't need to block on this)

edit: A previous version of this comment had the cascade sizes reversed in the diagram.

rparrett · 2023-01-22T15:57:38Z

Also, is there some reason I'm missing for why we can't and/or don't really need to configure a hypothetical shadow_minimum_distance?

…ngine#7069) # Objective - The bevyengine#7064 PR had poor performance on an M1 Max in MacOS due to significant overuse of registers resulting in 'register spilling' where data that would normally be stored in registers on the GPU is instead stored in VRAM. The latency to read from/write to VRAM instead of registers incurs a significant performance penalty. - Use of registers is a limiting factor in shader performance. Assignment of a struct from memory to a local variable can incur copies. Passing a variable that has struct type as an argument to a function can also incur copies. As such, these two cases can incur increased register usage and decreased performance. ## Solution - Remove/avoid a number of assignments of light struct type data to local variables. - Remove/avoid a number of passing light struct type variables/data as value arguments to shader functions.

robtfm · 2023-01-23T15:01:26Z

Also, is there some reason I'm missing for why we can't and/or don't really need to configure a hypothetical shadow_minimum_distance?

i think the camera projection near plane could be used for that. i haven't tested it but the cascades are built from frustum corners which will depend on the near plane.

rparrett · 2023-01-23T15:04:22Z

That makes sense, thanks. I do think the docs could be a bit clearer on this.

superdump · 2023-01-25T09:41:16Z

In a scenario like a 2.5d/3d strategy game where the camera is potentially very far away from the action, is my only option for increasing shadow map waste tweaking nearest_bound?

CascadeShadowConfig's members are public. You can construct the far bounds of the cascades however you like. It's just a Vec<f32>. However, the new() aims to be a useful convenience constructor given the usual concern of trading off performance and quality via the number of cascades and the shadow far distance. Setting the far bound of the nearest cascade is to avoid spending a bunch of cascades on very small distance ranges close to the camera.

I hear you that for a top-down/isometric type game, a different approach might indeed be useful. However, I think given there is low distribution of objects over camera depth versus distribution in screen space, the only thing that will really matter for such cases would be shadow map resolution. Then you could use a single cascade and higher shadow map texture resolution.

And am I right that this is effectively only pushing the end of the first cascade, potentially covering my objects with more cascades, but still wasting the entire first cascade?

Maybe this diagram will help:
Camera | C1 | C2   | C3      | C4        | shadow_maximum_distance
Camera | C1          | C2 | C3  | C4     | shadow_maximum_distance (nearest_bound tweaked)
                     <<Things           >>

That is what adjusting the nearest bound would do, yes.

1. As a user, it feels a bit unintuitive. The docs aren't incorrect or anything, but i feel like spelling out the fact that `nearest_bound` is not `minimum_shadow_distance` more explicitly might have helped me.

Good point. And perhaps we could elaborate with suggestions of when to use multiple cascades and exceptions of when to use fewer or one or so.

2. On WASM, or when there's otherwise only 1 cascade, `nearest_bound` is ignored and this doesn't seem to be mentioned anywhere.

Also a good point, thanks for the feedback!

superdump · 2023-01-25T10:56:12Z

I suppose with an isometric-type view with the camera high above the action, the closest object to the camera would be at a greater distance from the camera and then as you pointed out, it would be good to not try to encompass the camera origin in the shadow mapping. Which then goes to what robtfm was saying about moving the projection's near plane, which defines the view frustum. It is probably worth someone making a test case for it and trying to put together something that works well. It's not completely clear what the recommendation would be though and I don't really want to hold up this PR. We can iterate on documentation I think.

superdump

@robtfm if you're ok with this then I think we can merge it.

robtfm

@superdump r+

superdump · 2023-01-25T12:35:09Z

I’ll open an issue about improving the documentation for different cases.

superdump · 2023-01-25T12:35:21Z

bors r+

Co-authored-by: Robert Swain <robert.swain@gmail.com> # Objective Implements cascaded shadow maps for directional lights, which produces better quality shadows without needing excessively large shadow maps. Fixes #3629 Before ![image](https://user-images.githubusercontent.com/1222141/210061203-bbd965a4-8d11-4cec-9a88-67fc59d0819f.png) After ![image](https://user-images.githubusercontent.com/1222141/210061334-2ff15334-e6d7-4a31-9314-f34a7805cac6.png) ## Solution Rather than rendering a single shadow map for directional light, the view frustum is divided into a series of cascades, each of which gets its own shadow map. The correct cascade is then sampled for shadow determination. --- ## Changelog Directional lights now use cascaded shadow maps for improved shadow quality. ## Migration Guide You no longer have to manually specify a `shadow_projection` for a directional light, and these settings should be removed. If customization of how cascaded shadow maps work is desired, modify the `CascadeShadowConfig` component instead.

bors · 2023-01-25T12:56:13Z

Pull request successfully merged into main.

Build succeeded:

…ngine#7069) # Objective - The bevyengine#7064 PR had poor performance on an M1 Max in MacOS due to significant overuse of registers resulting in 'register spilling' where data that would normally be stored in registers on the GPU is instead stored in VRAM. The latency to read from/write to VRAM instead of registers incurs a significant performance penalty. - Use of registers is a limiting factor in shader performance. Assignment of a struct from memory to a local variable can incur copies. Passing a variable that has struct type as an argument to a function can also incur copies. As such, these two cases can incur increased register usage and decreased performance. ## Solution - Remove/avoid a number of assignments of light struct type data to local variables. - Remove/avoid a number of passing light struct type variables/data as value arguments to shader functions.

Co-authored-by: Robert Swain <robert.swain@gmail.com> # Objective Implements cascaded shadow maps for directional lights, which produces better quality shadows without needing excessively large shadow maps. Fixes bevyengine#3629 Before ![image](https://user-images.githubusercontent.com/1222141/210061203-bbd965a4-8d11-4cec-9a88-67fc59d0819f.png) After ![image](https://user-images.githubusercontent.com/1222141/210061334-2ff15334-e6d7-4a31-9314-f34a7805cac6.png) ## Solution Rather than rendering a single shadow map for directional light, the view frustum is divided into a series of cascades, each of which gets its own shadow map. The correct cascade is then sampled for shadow determination. --- ## Changelog Directional lights now use cascaded shadow maps for improved shadow quality. ## Migration Guide You no longer have to manually specify a `shadow_projection` for a directional light, and these settings should be removed. If customization of how cascaded shadow maps work is desired, modify the `CascadeShadowConfig` component instead.

@cart

## How This Works For the Bevy 0.10 release blog post (and for the first time ever), I'm publicly opening the doors to other people writing blog post sections. Specifically, if you worked on a feature in a substantial way and are interested in presenting it, you can now ask to claim a section by leaving a comment in this PR. If you claim a section, submit a pull request to the `release-0.10.0` branch in this repo. For the next week, we will be filling in sections (the release target is Saturday March 4th). Please don't claim a section if you don't plan on completing it within that timeline. Also don't claim a section if you weren't an active participant in the design and implementation of the change (unless you are a Maintainer or SME). I will claim any unclaimed sections. Try to match the style of previous release blog posts as much as possible. 1. Show, don't tell. Don't bombard people with information. Avoid large walls of text _and_ large walls of code. Prefer the pattern "byte sized description of one thing" -> "example code/picture/video contextualizing that one thing" -> repeat. Take readers on a journey step by simple step. 2. Don't use up reader's "mental bandwidth" without good reason. We can't afford page-long descriptions of minor bug fixes. If it isn't a "headliner change", keep the description short and sweet. If a change is self describing, let it do that (ex: We now support this new mesh shape primitive ... this is what it looks like). If it is a "headliner change", still try to keep it reasonable. We always have a lot to cover. 3. In slight competition with point (2), don't omit interesting technical information when it is truly fun and engaging. A good chunk of our users are highly technical and enjoy learning how the sausage is made. Try to strike a balance between "terse and simple" and "nerdy details". 4. When relevant, briefly describe the problem being solved first, then describe the solution we chose. This contextualizes the change and gives the feature value and purpose. 5. When possible, provide visuals. They create interest / keep people hooked / break up the monotony. 6. Record images and videos at the default bevy resolution (1280x720) 7. Provide an accurate listing of authors that meaningfully contributed to the feature. Try to sort in order of "contribution scale". This is hard to define, but try to be fair. When in doubt, ask other contributors, SMEs, and/or maintainers. 8. Provide numbers and graphs where possible. If something is faster, use numbers to back it up. We don't (yet) have automated graph generation in blog post style, so send data / info to me (@cart) if you want a graph made. ## Headliners Headliners are our "big ticket high importance / high profile" changes. They are listed briefly at the beginning of the blog post, their entries are roughly sorted "to the top", and they are given priority when it comes to "space in the blog post". If you think we missed something (or didn't prioritize something appropriately), let us know. * ECS Schedule v3 (previously known as "stageless") * Partial Android Support * Depth and Normal Prepass * Environment Map Lighting * Cascaded Shadow Maps * Distance and Atmospheric Fog * Smooth Skeletal Animation Transitions * Enable Parallel Pipelined Rendering * Windows as Entities * Renderer Optimizations * ECS Optimizations ## Sections These are the sections we will cover in the blog post. If a section has been claimed, it will have `(claimed by X)` in the title. If it is unclaimed it will have `(unclaimed)` in the title. Let us know if we missed a section. We don't cover every feature, but we should cover pretty much everything that would be interesting to users. Note that what is interesting or challenging to implement is not necessarily something that is relevant to our blog post readers. And sometimes the reverse is true! If you believe a section should be split up or reorganized, just bring it up here and we can discuss it. ### ~~Schedule V3 (claimed by @alice-i-cecile)~~ * [Migrate engine to Schedule v3][7267] * [Add `bevy_ecs::schedule_v3` module][6587] * [Stageless: fix unapplied systems][7446] * [Stageless: move final apply outside of spawned executor][7445] * Sets * Base Sets * [Base Sets][7466] * Reporting * [Report sets][7756] * [beter cycle reporting][7463] * Run Conditions * [Add condition negation][7559] * [And/Or][7605] * [Add more common run conditions][7579] * States * [States derive macro][7535] * System Piping Flexibility * [Support piping exclusive systems][7023] * [Allow piping run conditions][7547] ### ~~Depth and Normal Prepass (claimed by @IceSentry)~~ * [Add depth and normal prepass][6284] * [Move prepass functions to prepass_utils][7354] ### ~~Distance and Atmospheric Fog (claimed by @coreh)~~ * [Add Distance and Atmospheric Fog support][6412] ### ~~Cascaded Shadow Maps (claimed by @cart)~~ * [Cascaded shadow maps.][7064] * [Better cascades config defaults + builder, tweak example configs][7456] ### ~~Environment Map Lighting (claimed by @cart)~~ * [EnvironmentMapLight, BRDF Improvements][7051] * [Webgl2 support][7737] ### ~~Tonemapping options (claimed by @cart)~~ * [Initial tonemapping options][7594] ### ~~Android support + unification (claimed by @mockersf)~~ * [IOS, Android... same thing][7493] ### ~~Windows as Entities (claimed by @Aceeri)~~ * [Windows as Entities][5589] * [break feedback loop when moving cursor][7298] * [Fix `Window` feedback loop between the OS and Bevy][7517] ### ~~Enable Parallel Pipelined Rendering (claimed by @james7132)~~ * [Pipelined Rendering][6503] * [Stageless: add a method to scope to always run a task on the scope thread][7415] * [Separate Extract from Sub App Schedule][7046] ### ~~Smooth Skeletal Animation Transitions (claimed by @james7132)~~ * [Smooth Transition between Animations][6922] ### ~~Spatial Audio (claimed by @harudagondi)~~ * [Spatial Audio][6028] ### ~~Shader Processor Features (claimed by @cart)~~ * [Shader defs can now have a value][5900] * [Shaders can now have #else ifdef chains][7431] * [Define shader defs in shader][7518] ### ~~Shader Flexibility Improvements (claimed by @cart)~~ * [add ambient lighting hook][5428] * [Refactor Globals and View structs into separate shaders][7512] ### ~~Renderer Optimizations (claimed by @james7132)~~ * [bevy_pbr: Avoid copying structs and using registers in shaders][7069] * [Flatten render commands][6885] * [Replace UUID based IDs with a atomic-counted ones][6988] * [improve compile time by type-erasing wgpu structs][5950] * [Shrink DrawFunctionId][6944] * [Shrink ComputedVisibility][6305] * [Reduce branching in TrackedRenderPass][7053] * [Make PipelineCache internally mutable.][7205] * [Improve `Color::hex` performance][6940] * [Support recording multiple CommandBuffers in RenderContext][7248] * [Parallelized transform propagation][4775] * [Introduce detailed_trace macro, use in TrackedRenderPass][7639] * [Optimize color computation in prepare_uinodes][7311] * [Directly extract joints into SkinnedMeshJoints][6833] * [Parallelize forward kinematics animation systems][6785] * [Move system_commands spans into apply_buffers][6900] * [Reduce the use of atomics in the render phase][7084] ### ~~ECS Optimizations (claimed by @james7132 )~~ * [Remove redundant table and sparse set component IDs from Archetype][4927] * [Immutable sparse sets for metadata storage][4928] * [Replace BlobVec's swap_scratch with a swap_nonoverlapping][4853] * [Use T::Storage::STORAGE_TYPE to optimize out unused branches][6800] * [Remove unnecessary branching from bundle insertion][6902] * [Split Component Ticks][6547] * [use bevy_utils::HashMap for better performance. TypeId is predefined …][7642] * [Extend EntityLocation with TableId and TableRow][6681] * [Basic adaptive batching for parallel quer- [Speed up `CommandQueue` by storing commands more densely][6391]y iteration][4777] ### ~~Reflect Improvements (claimed by @cart)~~ * [bevy_reflect: Add `ReflectFromReflect` (v2)][6245] * [Add reflection support for VecDeque][6831] * [reflect: add `insert` and `remove` methods to `List`][7063] * [Add `remove` method to `Map` reflection trait.][6564] * [bevy_reflect: Fix binary deserialization not working for unit structs][6722] * [Add `TypeRegistrationDeserializer` and remove `BorrowedStr`][7094] * [bevy_reflect: Add simple enum support to reflection paths][6560] * [Enable deriving Reflect on structs with generic types][7364] * [bevy_reflect: Support tuple reflection paths][7324] * [bevy_reflect: Pre-parsed paths][7321] * [bevy_ecs: ReflectComponentFns without World][7206] ### ~~AsBindGroup Improvements (claimed by @cart)~~ * [Support storage buffers in derive `AsBindGroup`][6129] * [Support raw buffers in AsBindGroup][7701] ### ~~Cylinder Shape (claimed by @cart)~~ * [Add cylinder shape][6809] ### ~~Subdividable Plane Shape (claimed by @cart)~~ * [added subdivisions to shape::Plane][7546] ### ~~StandardMaterial Blend Modes (claimed by @coreh)~~ * [Standard Material Blend Modes][6644] ### ~~Configurable Visibility Component (claimed by @cart)~~ * [enum `Visibility` component][6320] ### Task Improvements (claimed by @cart) * [Fix panicking on another scope][6524] * [Add thread create/destroy callbacks to TaskPool][6561] * [Thread executor for running tasks on specific threads.][7087] * [await tasks to cancel][6696] * [Stageless: move MainThreadExecutor to schedule_v3][7444] * [Stageless: close the finish channel so executor doesn't deadlock][7448] ### ~~Upgrade to wgpu 0.15 (claimed by @cart)~~ * [Wgpu 0.15][7356] ### ~~Expose Bindless / Non-uniform Indexing Support (claimed by @cart)~~ * [Request WGPU Capabilities for Non-uniform Indexing][6995] ### ~~Cubic Spline (claimed by @aevyrie)~~ * [Bezier][7653] ### ~~Revamp Bloom (claimed by @JMS55)~~ * [Revamp bloom](bevyengine/bevy#6677) ### ~~Use Prepass Shaders for Shadows (claimed by @superdump)~~ * [use prepass shaders for shadows](bevyengine/bevy#7784) ### ~~AccessKit (claimed by @alice-i-cecile)~~ * [accesskit](bevyengine/bevy#6874) ### ~~Camera Output Modes (claimed by @cart)~~ * [camera output modes](bevyengine/bevy#7671) ### ~~SystemParam Improvements (claimed by @JoJoJet)~~ * [Make the `SystemParam` derive macro more flexible][6694] * [Add a `SystemParam` primitive for deferred mutations; allow `#[derive]`ing more types of SystemParam][6817] ### ~~Gamepad Improvements (claimed by @cart)~~ * [Gamepad events refactor][6965] * [add `Axis::devices` to get all the input devices][5400] ### ~~Input Methods (claimed by @cart)~~ * [add Input Method Editor support][7325] ### ~~Color Improvements (claimed by @cart)~~ * [Add LCH(ab) color space to `bevy_render::color::Color`][7483] * [Add a more familiar hex color entry][7060] ### ~~Split Up CorePlugin (claimed by @cart)~~ * [Break `CorePlugin` into `TaskPoolPlugin`, `TypeRegistrationPlugin`, `FrameCountPlugin`.][7083] ### ~~ExtractComponent Derive (claimed by @cart)~~ * [Extract component derive][7399] ### ~~Added OpenGL and DX11 Backends By Default (claimed by @cart)~~ * [add OpenGL and DX11 backends][7481] ### ~~UnsafeWorldCell (claimed by @BoxyUwU)~~ * [Move all logic to `UnsafeWorldCell`][7381] * [Rename `UnsafeWorldCellEntityRef` to `UnsafeEntityCell`][7568] ### ~~Entity Commands (claimed by @cart)~~ * [Add a trait for commands that run for a given `Entity`][7015] * [Add an extension trait to `EntityCommands` to update hierarchy while preserving `GlobalTransform`][7024] * [Add ReplaceChildren and ClearChildren EntityCommands][6035] ### ~~Iterate EntityRef (claimed by @james7132)~~ * [Allow iterating over with EntityRef over the entire World][6843] ### ~~Ref Queries (@JoJoJet)~~ * [Added Ref to allow immutable access with change detection][7097] ### ~~Taffy Upgrade (claimed by @cart)~~ * [Upgrade to Taffy 0.2][6743] ### ~~Relative Cursor Position (claimed by @cart)~~ * [Relative cursor position][7199] ### ~~Const UI Config (claimed by @cart)~~ * [Add const to methods and const defaults to bevy_ui][5542] ### ~~Examples (claimed by @cart)~~ * [Add pixelated Bevy to assets and an example][6408] * [Organized scene_viewer into plugins for reuse and organization][6936] ### ~~CI Improvements (claimed by @cart)~~ * [add rust-version for MSRV and CI job to check][6852] * [msrv: only send a message on failure during the actual msrv part][7532] * [Make CI friendlier][7398] * [Fix CI welcome message][7428] * [add an action to ask for a migration guide when one is missing][7507] ### ~~SMEs (@cart)~~ This was already covered in another blog post. Just briefly call out what they are and that this is the first release that used them. Link to the other blog post. * [Subject Matter Experts and new Bevy Org docs][7185] [4775]: bevyengine/bevy#4775 [4777]: bevyengine/bevy#4777 [4853]: bevyengine/bevy#4853 [4927]: bevyengine/bevy#4927 [4928]: bevyengine/bevy#4928 [5400]: bevyengine/bevy#5400 [5428]: bevyengine/bevy#5428 [5542]: bevyengine/bevy#5542 [5589]: bevyengine/bevy#5589 [5900]: bevyengine/bevy#5900 [5950]: bevyengine/bevy#5950 [6028]: bevyengine/bevy#6028 [6035]: bevyengine/bevy#6035 [6129]: bevyengine/bevy#6129 [6179]: bevyengine/bevy#6179 [6245]: bevyengine/bevy#6245 [6284]: bevyengine/bevy#6284 [6305]: bevyengine/bevy#6305 [6320]: bevyengine/bevy#6320 [6391]: bevyengine/bevy#6391 [6408]: bevyengine/bevy#6408 [6412]: bevyengine/bevy#6412 [6503]: bevyengine/bevy#6503 [6524]: bevyengine/bevy#6524 [6547]: bevyengine/bevy#6547 [6557]: bevyengine/bevy#6557 [6560]: bevyengine/bevy#6560 [6561]: bevyengine/bevy#6561 [6564]: bevyengine/bevy#6564 [6587]: bevyengine/bevy#6587 [6644]: bevyengine/bevy#6644 [6649]: bevyengine/bevy#6649 [6681]: bevyengine/bevy#6681 [6694]: bevyengine/bevy#6694 [6696]: bevyengine/bevy#6696 [6722]: bevyengine/bevy#6722 [6743]: bevyengine/bevy#6743 [6785]: bevyengine/bevy#6785 [6800]: bevyengine/bevy#6800 [6802]: bevyengine/bevy#6802 [6809]: bevyengine/bevy#6809 [6817]: bevyengine/bevy#6817 [6831]: bevyengine/bevy#6831 [6833]: bevyengine/bevy#6833 [6843]: bevyengine/bevy#6843 [6852]: bevyengine/bevy#6852 [6885]: bevyengine/bevy#6885 [6900]: bevyengine/bevy#6900 [6902]: bevyengine/bevy#6902 [6922]: bevyengine/bevy#6922 [6926]: bevyengine/bevy#6926 [6936]: bevyengine/bevy#6936 [6940]: bevyengine/bevy#6940 [6944]: bevyengine/bevy#6944 [6965]: bevyengine/bevy#6965 [6988]: bevyengine/bevy#6988 [6995]: bevyengine/bevy#6995 [7015]: bevyengine/bevy#7015 [7023]: bevyengine/bevy#7023 [7024]: bevyengine/bevy#7024 [7046]: bevyengine/bevy#7046 [7051]: bevyengine/bevy#7051 [7053]: bevyengine/bevy#7053 [7060]: bevyengine/bevy#7060 [7063]: bevyengine/bevy#7063 [7064]: bevyengine/bevy#7064 [7069]: bevyengine/bevy#7069 [7083]: bevyengine/bevy#7083 [7084]: bevyengine/bevy#7084 [7087]: bevyengine/bevy#7087 [7094]: bevyengine/bevy#7094 [7097]: bevyengine/bevy#7097 [7185]: bevyengine/bevy#7185 [7199]: bevyengine/bevy#7199 [7205]: bevyengine/bevy#7205 [7206]: bevyengine/bevy#7206 [7248]: bevyengine/bevy#7248 [7267]: bevyengine/bevy#7267 [7298]: bevyengine/bevy#7298 [7311]: bevyengine/bevy#7311 [7321]: bevyengine/bevy#7321 [7324]: bevyengine/bevy#7324 [7325]: bevyengine/bevy#7325 [7354]: bevyengine/bevy#7354 [7356]: bevyengine/bevy#7356 [7364]: bevyengine/bevy#7364 [7381]: bevyengine/bevy#7381 [7398]: bevyengine/bevy#7398 [7399]: bevyengine/bevy#7399 [7415]: bevyengine/bevy#7415 [7428]: bevyengine/bevy#7428 [7431]: bevyengine/bevy#7431 [7444]: bevyengine/bevy#7444 [7445]: bevyengine/bevy#7445 [7446]: bevyengine/bevy#7446 [7448]: bevyengine/bevy#7448 [7456]: bevyengine/bevy#7456 [7463]: bevyengine/bevy#7463 [7466]: bevyengine/bevy#7466 [7481]: bevyengine/bevy#7481 [7483]: bevyengine/bevy#7483 [7493]: bevyengine/bevy#7493 [7507]: bevyengine/bevy#7507 [7510]: bevyengine/bevy#7510 [7512]: bevyengine/bevy#7512 [7517]: bevyengine/bevy#7517 [7518]: bevyengine/bevy#7518 [7532]: bevyengine/bevy#7532 [7535]: bevyengine/bevy#7535 [7546]: bevyengine/bevy#7546 [7547]: bevyengine/bevy#7547 [7559]: bevyengine/bevy#7559 [7568]: bevyengine/bevy#7568 [7579]: bevyengine/bevy#7579 [7594]: bevyengine/bevy#7594 [7605]: bevyengine/bevy#7605 [7639]: bevyengine/bevy#7639 [7642]: bevyengine/bevy#7642 [7653]: bevyengine/bevy#7653 [7701]: bevyengine/bevy#7701 [7737]: bevyengine/bevy#7737 [7756]: bevyengine/bevy#7756 Co-authored-by: François <mockersf@gmail.com> Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: Mike <mike.hsu@gmail.com> Co-authored-by: Boxy <supbscripter@gmail.com> Co-authored-by: IceSentry <c.giguere42@gmail.com> Co-authored-by: JoJoJet <21144246+JoJoJet@users.noreply.github.com> Co-authored-by: Aevyrie <aevyrie@gmail.com> Co-authored-by: James Liu <contact@jamessliu.com> Co-authored-by: Marco Buono <thecoreh@gmail.com> Co-authored-by: Aceeri <conmcclusk@gmail.com>

superdump self-requested a review December 30, 2022 11:54

danchia force-pushed the cascade-shadow-maps branch from fa11b18 to e62a404 Compare December 30, 2022 23:21

superdump requested changes Dec 31, 2022

View reviewed changes

alice-i-cecile added C-Feature A new feature, making something new possible A-Rendering Drawing game state to the screen labels Dec 31, 2022

alice-i-cecile requested a review from superdump December 31, 2022 19:45

superdump mentioned this pull request Jan 1, 2023

[Merged by Bors] - bevy_pbr: Avoid copying structs and using registers in shaders #7069

Closed

superdump requested a review from robtfm January 18, 2023 18:12

superdump added this to the 0.10 milestone Jan 18, 2023

superdump reviewed Jan 18, 2023

View reviewed changes

danchia added 3 commits January 21, 2023 23:12

add warning for exceeding max cascades per light

74a5f11

appease clippy

e662687

tweak load_gltf cascades

106e07a

danchia force-pushed the cascade-shadow-maps branch from f8ee553 to 106e07a Compare January 22, 2023 07:16

danchia requested review from superdump and robtfm and removed request for superdump January 22, 2023 07:18

fmt

4ebf9ac

superdump approved these changes Jan 25, 2023

View reviewed changes

robtfm approved these changes Jan 25, 2023

View reviewed changes

bors bot changed the title ~~Cascaded shadow maps.~~ [Merged by Bors] - Cascaded shadow maps. Jan 25, 2023

bors bot closed this Jan 25, 2023

superdump mentioned this pull request Jan 25, 2023

Document how to configure cascaded shadow maps in different situations #7362

Closed

coreh mentioned this pull request Jan 28, 2023

[Merged by Bors] - Add Distance and Atmospheric Fog support #6412

Closed

cart mentioned this pull request Feb 24, 2023

[Merged by Bors] - News: Release 0.10.0 bevyengine/bevy-website#546

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - Cascaded shadow maps. #7064

[Merged by Bors] - Cascaded shadow maps. #7064

danchia commented Dec 30, 2022 •

edited

Loading

mockersf commented Dec 30, 2022

danchia commented Dec 30, 2022

superdump left a comment

superdump Dec 31, 2022

danchia Jan 1, 2023

superdump commented Dec 31, 2022

danchia commented Dec 31, 2022 •

edited

Loading

superdump commented Dec 31, 2022

superdump commented Jan 1, 2023

danchia commented Jan 1, 2023

superdump commented Jan 1, 2023

mockersf commented Jan 3, 2023

superdump commented Jan 3, 2023

mockersf commented Jan 3, 2023 •

edited

Loading

danchia commented Jan 3, 2023

danchia commented Jan 3, 2023

danchia commented Jan 8, 2023

superdump left a comment

superdump Jan 18, 2023

rparrett commented Jan 18, 2023 •

edited

Loading

danchia commented Jan 19, 2023

danchia commented Jan 22, 2023

rparrett commented Jan 22, 2023 •

edited

Loading

rparrett commented Jan 22, 2023 •

edited

Loading

robtfm commented Jan 23, 2023

rparrett commented Jan 23, 2023

superdump commented Jan 25, 2023

superdump commented Jan 25, 2023

superdump left a comment

robtfm left a comment

superdump commented Jan 25, 2023

superdump commented Jan 25, 2023

bors bot commented Jan 25, 2023

[Merged by Bors] - Cascaded shadow maps. #7064

[Merged by Bors] - Cascaded shadow maps. #7064

Conversation

danchia commented Dec 30, 2022 • edited Loading

Objective

Solution

Changelog

Migration Guide

mockersf commented Dec 30, 2022

danchia commented Dec 30, 2022

superdump left a comment

Choose a reason for hiding this comment

superdump Dec 31, 2022

Choose a reason for hiding this comment

danchia Jan 1, 2023

Choose a reason for hiding this comment

superdump commented Dec 31, 2022

danchia commented Dec 31, 2022 • edited Loading

superdump commented Dec 31, 2022

superdump commented Jan 1, 2023

danchia commented Jan 1, 2023

superdump commented Jan 1, 2023

mockersf commented Jan 3, 2023

superdump commented Jan 3, 2023

mockersf commented Jan 3, 2023 • edited Loading

danchia commented Jan 3, 2023

danchia commented Jan 3, 2023

danchia commented Jan 8, 2023

superdump left a comment

Choose a reason for hiding this comment

superdump Jan 18, 2023

Choose a reason for hiding this comment

rparrett commented Jan 18, 2023 • edited Loading

danchia commented Jan 19, 2023

danchia commented Jan 22, 2023

rparrett commented Jan 22, 2023 • edited Loading

rparrett commented Jan 22, 2023 • edited Loading

robtfm commented Jan 23, 2023

rparrett commented Jan 23, 2023

superdump commented Jan 25, 2023

superdump commented Jan 25, 2023

superdump left a comment

Choose a reason for hiding this comment

robtfm left a comment

Choose a reason for hiding this comment

superdump commented Jan 25, 2023

superdump commented Jan 25, 2023

bors bot commented Jan 25, 2023

danchia commented Dec 30, 2022 •

edited

Loading

danchia commented Dec 31, 2022 •

edited

Loading

mockersf commented Jan 3, 2023 •

edited

Loading

rparrett commented Jan 18, 2023 •

edited

Loading

rparrett commented Jan 22, 2023 •

edited

Loading

rparrett commented Jan 22, 2023 •

edited

Loading