[Merged by Bors] - Thread executor for running tasks on specific threads. #7087

hymm · 2023-01-04T06:03:27Z

Objective

Spawn tasks from other threads onto an async executor, but limit those tasks to run on a specific thread.
This is a continuation of trying to break up some of the changes in pipelined rendering.
Eventually this will be used to allow NonSend systems to run on the main thread in pipelined rendering [Merged by Bors] - Pipelined Rendering #6503 and also to solve Storing `!Send` data in `World` is problematic #6552.
For this specific PR this allows for us to store a thread executor in a thread local, rather than recreating a scope executor for every scope which should save on a little work.

Solution

We create a Executor that does a runtime check for what thread it's on before creating a !Send ticker. The ticker is the only way for the executor to make progress.

Changelog

create a ThreadExecutor that can only be ticked on one thread.

crates/bevy_tasks/src/thread_executor.rs

crates/bevy_tasks/src/task_pool.rs

crates/bevy_tasks/src/thread_executor.rs

maniwani · 2023-01-10T02:24:42Z

I know this was sorta split from your pipelined rendering PR, so I'm probably missing some context from there (since I haven't reviewed that one yet), but what motivated having the ticker as a separate struct?

DevinLeamy

LTGM

hymm · 2023-01-10T04:47:04Z

I know this was sorta split from your pipelined rendering PR, so I'm probably missing some context from there (since I haven't reviewed that one yet), but what motivated having the ticker as a separate struct?

The ticker has to be separate because part of what makes it work is that the ticker is !Send, so it can only be instantiated and then ticked on a specific thread. But the spawner is Send which allows other threads to spawn tasks that only run on that thread.

A similar question is why the spawner is separate from the executor. And I'm not sure if that is needed. I'll look into that.

hymm · 2023-01-10T06:07:42Z

So third try's the charm, I guess. The reason the spawner existed was to separate it's lifetime from the tickers lifetime. But this time I was able to get the ticker to be a non static lifetime by changing the tick method to async and awaiting the inner tick. Something about the way the old version was written was capturing a lifetime on self in the future besides the 'a lifetime. Which led to conflict in requirements between that lifetime and the 'a lifetime. Writing it this way avoids that lifetime being captured in the future somehow. Not sure I understand it 100%.

maniwani · 2023-01-10T18:10:17Z

The ticker has to be separate because part of what makes it work is that the ticker is !Send, so it can only be instantiated and then ticked on a specific thread.

I was able to look at all the changes today, and it seems like the ticker is separate because if try_tick was on ThreadExecutor, you'd have to test if you're calling from the right thread every time.

So the choice makes sense. Did you have any "with ticker vs without ticker" benchmarks? I'm just thinking users who are familiar with Executor might think its API being split between two types is awkward, but I guess optimizing it is more important since the use for this is so niche / low-level.

alice-i-cecile

bors r+

alice-i-cecile · 2023-01-10T18:18:30Z

bors r-

Giving a bit of time to let the conversation above wrap up.

bors · 2023-01-10T18:18:33Z

Canceled.

hymm · 2023-01-10T19:24:23Z

I was able to look at all the changes today, and it seems like the ticker is separate because if try_tick was on ThreadExecutor, you'd have to test if you're calling from the right thread every time.

Yeah, that's exactly right. Making the ticker nonsend and just keeping the check when it's created, keeps the check out of the hot path.

Did you have any "with ticker vs without ticker" benchmarks?

just ran the empty_systems benchmark. It meets my expectations where you can see a small improvement at small numbers of systems due to not having to create the scope_executor anymore, but that gets mostly washed out at higher system counts. Ran it a couple times due to this bench being a little noisy.

group                        main-for-thread-executor               main-for-thread-executor-2             thread-executor                        thread-executor-2
-----                        ------------------------               --------------------------             ---------------                        -----------------
empty_systems/000_systems    1.16     65.0±3.38ns        ? ?/sec    1.12     63.0±1.14ns        ? ?/sec    1.00     56.1±1.36ns        ? ?/sec    1.01     56.8±3.21ns        ? ?/sec
empty_systems/001_systems    1.21  1421.4±78.44ns        ? ?/sec    1.17  1383.3±42.76ns        ? ?/sec    1.07  1267.3±51.46ns        ? ?/sec    1.00  1179.4±31.87ns        ? ?/sec
empty_systems/002_systems    1.26      2.1±0.10µs        ? ?/sec    1.10  1834.8±76.14ns        ? ?/sec    1.03  1719.0±69.90ns        ? ?/sec    1.00  1661.1±156.02ns        ? ?/sec
empty_systems/003_systems    1.25      2.5±0.30µs        ? ?/sec    1.09      2.2±0.10µs        ? ?/sec    1.04      2.0±0.12µs        ? ?/sec    1.00  1973.2±108.43ns        ? ?/sec
empty_systems/004_systems    1.10      2.6±0.09µs        ? ?/sec    1.08      2.5±0.11µs        ? ?/sec    1.04      2.4±0.10µs        ? ?/sec    1.00      2.3±0.10µs        ? ?/sec
empty_systems/005_systems    1.10      3.1±0.23µs        ? ?/sec    1.00      2.8±0.12µs        ? ?/sec    1.04      2.9±0.25µs        ? ?/sec    1.08      3.0±0.08µs        ? ?/sec
empty_systems/010_systems    1.13      5.1±0.25µs        ? ?/sec    1.00      4.5±0.16µs        ? ?/sec    1.09      4.9±0.30µs        ? ?/sec    1.02      4.6±0.16µs        ? ?/sec
empty_systems/015_systems    1.19      8.7±0.34µs        ? ?/sec    1.05      7.6±0.27µs        ? ?/sec    1.03      7.5±0.26µs        ? ?/sec    1.00      7.3±0.73µs        ? ?/sec
empty_systems/020_systems    1.11     10.9±0.39µs        ? ?/sec    1.04     10.2±0.21µs        ? ?/sec    1.00      9.8±0.36µs        ? ?/sec    1.00      9.8±0.22µs        ? ?/sec
empty_systems/025_systems    1.09     13.0±0.60µs        ? ?/sec    1.02     12.2±0.57µs        ? ?/sec    1.02     12.2±0.32µs        ? ?/sec    1.00     11.9±0.27µs        ? ?/sec
empty_systems/030_systems    1.12     16.9±0.61µs        ? ?/sec    1.00     15.1±0.42µs        ? ?/sec    1.01     15.3±0.39µs        ? ?/sec    1.00     15.1±0.50µs        ? ?/sec
empty_systems/035_systems    1.09     18.8±0.69µs        ? ?/sec    1.03     17.8±0.73µs        ? ?/sec    1.04     17.9±0.78µs        ? ?/sec    1.00     17.3±0.55µs        ? ?/sec
empty_systems/040_systems    1.14     21.7±1.16µs        ? ?/sec    1.00     19.0±0.65µs        ? ?/sec    1.04     19.8±0.71µs        ? ?/sec    1.03     19.6±0.75µs        ? ?/sec
empty_systems/045_systems    1.10     23.6±1.43µs        ? ?/sec    1.05     22.6±1.25µs        ? ?/sec    1.05     22.5±2.48µs        ? ?/sec    1.00     21.5±1.14µs        ? ?/sec
empty_systems/050_systems    1.08     26.3±1.95µs        ? ?/sec    1.00     24.4±0.74µs        ? ?/sec    1.02     24.8±0.94µs        ? ?/sec    1.04     25.3±1.28µs        ? ?/sec
empty_systems/055_systems    1.10     28.3±0.80µs        ? ?/sec    1.06     27.1±0.59µs        ? ?/sec    1.00     25.6±0.63µs        ? ?/sec    1.01     25.8±0.30µs        ? ?/sec
empty_systems/060_systems    1.04     31.4±1.07µs        ? ?/sec    1.00     30.2±1.18µs        ? ?/sec    1.00     30.4±1.07µs        ? ?/sec    1.01     30.4±1.59µs        ? ?/sec
empty_systems/065_systems    1.07     33.8±1.14µs        ? ?/sec    1.04     33.0±0.94µs        ? ?/sec    1.00     31.6±2.38µs        ? ?/sec    1.02     32.1±1.05µs        ? ?/sec
empty_systems/070_systems    1.09     37.3±2.11µs        ? ?/sec    1.01     34.6±1.06µs        ? ?/sec    1.11     38.1±2.71µs        ? ?/sec    1.00     34.3±1.07µs        ? ?/sec
empty_systems/075_systems    1.11     39.6±1.34µs        ? ?/sec    1.05     37.7±1.20µs        ? ?/sec    1.04     37.2±1.38µs        ? ?/sec    1.00     35.8±1.41µs        ? ?/sec
empty_systems/080_systems    1.11     42.1±1.49µs        ? ?/sec    1.00     37.8±1.48µs        ? ?/sec    1.05     39.8±1.57µs        ? ?/sec    1.03     38.9±1.41µs        ? ?/sec
empty_systems/085_systems    1.02     42.6±1.46µs        ? ?/sec    1.00     41.7±1.36µs        ? ?/sec    1.03     42.8±2.38µs        ? ?/sec    1.00     41.8±1.26µs        ? ?/sec
empty_systems/090_systems    1.02     45.4±1.88µs        ? ?/sec    1.01     44.7±1.47µs        ? ?/sec    1.01     44.9±1.74µs        ? ?/sec    1.00     44.4±1.92µs        ? ?/sec
empty_systems/095_systems    1.03     48.2±2.13µs        ? ?/sec    1.01     47.4±1.30µs        ? ?/sec    1.03     48.2±5.35µs        ? ?/sec    1.00     47.0±2.13µs        ? ?/sec
empty_systems/100_systems    1.04     51.0±2.09µs        ? ?/sec    1.02     50.5±1.60µs        ? ?/sec    1.05     51.7±3.24µs        ? ?/sec    1.00     49.3±3.09µs        ? ?/sec

alice-i-cecile · 2023-01-10T22:32:24Z

bors r+

# Objective - Spawn tasks from other threads onto an async executor, but limit those tasks to run on a specific thread. - This is a continuation of trying to break up some of the changes in pipelined rendering. - Eventually this will be used to allow `NonSend` systems to run on the main thread in pipelined rendering #6503 and also to solve #6552. - For this specific PR this allows for us to store a thread executor in a thread local, rather than recreating a scope executor for every scope which should save on a little work. ## Solution - We create a Executor that does a runtime check for what thread it's on before creating a !Send ticker. The ticker is the only way for the executor to make progress. --- ## Changelog - create a ThreadExecutor that can only be ticked on one thread.

bors · 2023-01-10T22:59:26Z

Pull request successfully merged into main.

Build succeeded:

# Objective - Spawn tasks from other threads onto an async executor, but limit those tasks to run on a specific thread. - This is a continuation of trying to break up some of the changes in pipelined rendering. - Eventually this will be used to allow `NonSend` systems to run on the main thread in pipelined rendering bevyengine#6503 and also to solve bevyengine#6552. - For this specific PR this allows for us to store a thread executor in a thread local, rather than recreating a scope executor for every scope which should save on a little work. ## Solution - We create a Executor that does a runtime check for what thread it's on before creating a !Send ticker. The ticker is the only way for the executor to make progress. --- ## Changelog - create a ThreadExecutor that can only be ticked on one thread.

@cart

## How This Works For the Bevy 0.10 release blog post (and for the first time ever), I'm publicly opening the doors to other people writing blog post sections. Specifically, if you worked on a feature in a substantial way and are interested in presenting it, you can now ask to claim a section by leaving a comment in this PR. If you claim a section, submit a pull request to the `release-0.10.0` branch in this repo. For the next week, we will be filling in sections (the release target is Saturday March 4th). Please don't claim a section if you don't plan on completing it within that timeline. Also don't claim a section if you weren't an active participant in the design and implementation of the change (unless you are a Maintainer or SME). I will claim any unclaimed sections. Try to match the style of previous release blog posts as much as possible. 1. Show, don't tell. Don't bombard people with information. Avoid large walls of text _and_ large walls of code. Prefer the pattern "byte sized description of one thing" -> "example code/picture/video contextualizing that one thing" -> repeat. Take readers on a journey step by simple step. 2. Don't use up reader's "mental bandwidth" without good reason. We can't afford page-long descriptions of minor bug fixes. If it isn't a "headliner change", keep the description short and sweet. If a change is self describing, let it do that (ex: We now support this new mesh shape primitive ... this is what it looks like). If it is a "headliner change", still try to keep it reasonable. We always have a lot to cover. 3. In slight competition with point (2), don't omit interesting technical information when it is truly fun and engaging. A good chunk of our users are highly technical and enjoy learning how the sausage is made. Try to strike a balance between "terse and simple" and "nerdy details". 4. When relevant, briefly describe the problem being solved first, then describe the solution we chose. This contextualizes the change and gives the feature value and purpose. 5. When possible, provide visuals. They create interest / keep people hooked / break up the monotony. 6. Record images and videos at the default bevy resolution (1280x720) 7. Provide an accurate listing of authors that meaningfully contributed to the feature. Try to sort in order of "contribution scale". This is hard to define, but try to be fair. When in doubt, ask other contributors, SMEs, and/or maintainers. 8. Provide numbers and graphs where possible. If something is faster, use numbers to back it up. We don't (yet) have automated graph generation in blog post style, so send data / info to me (@cart) if you want a graph made. ## Headliners Headliners are our "big ticket high importance / high profile" changes. They are listed briefly at the beginning of the blog post, their entries are roughly sorted "to the top", and they are given priority when it comes to "space in the blog post". If you think we missed something (or didn't prioritize something appropriately), let us know. * ECS Schedule v3 (previously known as "stageless") * Partial Android Support * Depth and Normal Prepass * Environment Map Lighting * Cascaded Shadow Maps * Distance and Atmospheric Fog * Smooth Skeletal Animation Transitions * Enable Parallel Pipelined Rendering * Windows as Entities * Renderer Optimizations * ECS Optimizations ## Sections These are the sections we will cover in the blog post. If a section has been claimed, it will have `(claimed by X)` in the title. If it is unclaimed it will have `(unclaimed)` in the title. Let us know if we missed a section. We don't cover every feature, but we should cover pretty much everything that would be interesting to users. Note that what is interesting or challenging to implement is not necessarily something that is relevant to our blog post readers. And sometimes the reverse is true! If you believe a section should be split up or reorganized, just bring it up here and we can discuss it. ### ~~Schedule V3 (claimed by @alice-i-cecile)~~ * [Migrate engine to Schedule v3][7267] * [Add `bevy_ecs::schedule_v3` module][6587] * [Stageless: fix unapplied systems][7446] * [Stageless: move final apply outside of spawned executor][7445] * Sets * Base Sets * [Base Sets][7466] * Reporting * [Report sets][7756] * [beter cycle reporting][7463] * Run Conditions * [Add condition negation][7559] * [And/Or][7605] * [Add more common run conditions][7579] * States * [States derive macro][7535] * System Piping Flexibility * [Support piping exclusive systems][7023] * [Allow piping run conditions][7547] ### ~~Depth and Normal Prepass (claimed by @IceSentry)~~ * [Add depth and normal prepass][6284] * [Move prepass functions to prepass_utils][7354] ### ~~Distance and Atmospheric Fog (claimed by @coreh)~~ * [Add Distance and Atmospheric Fog support][6412] ### ~~Cascaded Shadow Maps (claimed by @cart)~~ * [Cascaded shadow maps.][7064] * [Better cascades config defaults + builder, tweak example configs][7456] ### ~~Environment Map Lighting (claimed by @cart)~~ * [EnvironmentMapLight, BRDF Improvements][7051] * [Webgl2 support][7737] ### ~~Tonemapping options (claimed by @cart)~~ * [Initial tonemapping options][7594] ### ~~Android support + unification (claimed by @mockersf)~~ * [IOS, Android... same thing][7493] ### ~~Windows as Entities (claimed by @Aceeri)~~ * [Windows as Entities][5589] * [break feedback loop when moving cursor][7298] * [Fix `Window` feedback loop between the OS and Bevy][7517] ### ~~Enable Parallel Pipelined Rendering (claimed by @james7132)~~ * [Pipelined Rendering][6503] * [Stageless: add a method to scope to always run a task on the scope thread][7415] * [Separate Extract from Sub App Schedule][7046] ### ~~Smooth Skeletal Animation Transitions (claimed by @james7132)~~ * [Smooth Transition between Animations][6922] ### ~~Spatial Audio (claimed by @harudagondi)~~ * [Spatial Audio][6028] ### ~~Shader Processor Features (claimed by @cart)~~ * [Shader defs can now have a value][5900] * [Shaders can now have #else ifdef chains][7431] * [Define shader defs in shader][7518] ### ~~Shader Flexibility Improvements (claimed by @cart)~~ * [add ambient lighting hook][5428] * [Refactor Globals and View structs into separate shaders][7512] ### ~~Renderer Optimizations (claimed by @james7132)~~ * [bevy_pbr: Avoid copying structs and using registers in shaders][7069] * [Flatten render commands][6885] * [Replace UUID based IDs with a atomic-counted ones][6988] * [improve compile time by type-erasing wgpu structs][5950] * [Shrink DrawFunctionId][6944] * [Shrink ComputedVisibility][6305] * [Reduce branching in TrackedRenderPass][7053] * [Make PipelineCache internally mutable.][7205] * [Improve `Color::hex` performance][6940] * [Support recording multiple CommandBuffers in RenderContext][7248] * [Parallelized transform propagation][4775] * [Introduce detailed_trace macro, use in TrackedRenderPass][7639] * [Optimize color computation in prepare_uinodes][7311] * [Directly extract joints into SkinnedMeshJoints][6833] * [Parallelize forward kinematics animation systems][6785] * [Move system_commands spans into apply_buffers][6900] * [Reduce the use of atomics in the render phase][7084] ### ~~ECS Optimizations (claimed by @james7132 )~~ * [Remove redundant table and sparse set component IDs from Archetype][4927] * [Immutable sparse sets for metadata storage][4928] * [Replace BlobVec's swap_scratch with a swap_nonoverlapping][4853] * [Use T::Storage::STORAGE_TYPE to optimize out unused branches][6800] * [Remove unnecessary branching from bundle insertion][6902] * [Split Component Ticks][6547] * [use bevy_utils::HashMap for better performance. TypeId is predefined …][7642] * [Extend EntityLocation with TableId and TableRow][6681] * [Basic adaptive batching for parallel quer- [Speed up `CommandQueue` by storing commands more densely][6391]y iteration][4777] ### ~~Reflect Improvements (claimed by @cart)~~ * [bevy_reflect: Add `ReflectFromReflect` (v2)][6245] * [Add reflection support for VecDeque][6831] * [reflect: add `insert` and `remove` methods to `List`][7063] * [Add `remove` method to `Map` reflection trait.][6564] * [bevy_reflect: Fix binary deserialization not working for unit structs][6722] * [Add `TypeRegistrationDeserializer` and remove `BorrowedStr`][7094] * [bevy_reflect: Add simple enum support to reflection paths][6560] * [Enable deriving Reflect on structs with generic types][7364] * [bevy_reflect: Support tuple reflection paths][7324] * [bevy_reflect: Pre-parsed paths][7321] * [bevy_ecs: ReflectComponentFns without World][7206] ### ~~AsBindGroup Improvements (claimed by @cart)~~ * [Support storage buffers in derive `AsBindGroup`][6129] * [Support raw buffers in AsBindGroup][7701] ### ~~Cylinder Shape (claimed by @cart)~~ * [Add cylinder shape][6809] ### ~~Subdividable Plane Shape (claimed by @cart)~~ * [added subdivisions to shape::Plane][7546] ### ~~StandardMaterial Blend Modes (claimed by @coreh)~~ * [Standard Material Blend Modes][6644] ### ~~Configurable Visibility Component (claimed by @cart)~~ * [enum `Visibility` component][6320] ### Task Improvements (claimed by @cart) * [Fix panicking on another scope][6524] * [Add thread create/destroy callbacks to TaskPool][6561] * [Thread executor for running tasks on specific threads.][7087] * [await tasks to cancel][6696] * [Stageless: move MainThreadExecutor to schedule_v3][7444] * [Stageless: close the finish channel so executor doesn't deadlock][7448] ### ~~Upgrade to wgpu 0.15 (claimed by @cart)~~ * [Wgpu 0.15][7356] ### ~~Expose Bindless / Non-uniform Indexing Support (claimed by @cart)~~ * [Request WGPU Capabilities for Non-uniform Indexing][6995] ### ~~Cubic Spline (claimed by @aevyrie)~~ * [Bezier][7653] ### ~~Revamp Bloom (claimed by @JMS55)~~ * [Revamp bloom](bevyengine/bevy#6677) ### ~~Use Prepass Shaders for Shadows (claimed by @superdump)~~ * [use prepass shaders for shadows](bevyengine/bevy#7784) ### ~~AccessKit (claimed by @alice-i-cecile)~~ * [accesskit](bevyengine/bevy#6874) ### ~~Camera Output Modes (claimed by @cart)~~ * [camera output modes](bevyengine/bevy#7671) ### ~~SystemParam Improvements (claimed by @JoJoJet)~~ * [Make the `SystemParam` derive macro more flexible][6694] * [Add a `SystemParam` primitive for deferred mutations; allow `#[derive]`ing more types of SystemParam][6817] ### ~~Gamepad Improvements (claimed by @cart)~~ * [Gamepad events refactor][6965] * [add `Axis::devices` to get all the input devices][5400] ### ~~Input Methods (claimed by @cart)~~ * [add Input Method Editor support][7325] ### ~~Color Improvements (claimed by @cart)~~ * [Add LCH(ab) color space to `bevy_render::color::Color`][7483] * [Add a more familiar hex color entry][7060] ### ~~Split Up CorePlugin (claimed by @cart)~~ * [Break `CorePlugin` into `TaskPoolPlugin`, `TypeRegistrationPlugin`, `FrameCountPlugin`.][7083] ### ~~ExtractComponent Derive (claimed by @cart)~~ * [Extract component derive][7399] ### ~~Added OpenGL and DX11 Backends By Default (claimed by @cart)~~ * [add OpenGL and DX11 backends][7481] ### ~~UnsafeWorldCell (claimed by @BoxyUwU)~~ * [Move all logic to `UnsafeWorldCell`][7381] * [Rename `UnsafeWorldCellEntityRef` to `UnsafeEntityCell`][7568] ### ~~Entity Commands (claimed by @cart)~~ * [Add a trait for commands that run for a given `Entity`][7015] * [Add an extension trait to `EntityCommands` to update hierarchy while preserving `GlobalTransform`][7024] * [Add ReplaceChildren and ClearChildren EntityCommands][6035] ### ~~Iterate EntityRef (claimed by @james7132)~~ * [Allow iterating over with EntityRef over the entire World][6843] ### ~~Ref Queries (@JoJoJet)~~ * [Added Ref to allow immutable access with change detection][7097] ### ~~Taffy Upgrade (claimed by @cart)~~ * [Upgrade to Taffy 0.2][6743] ### ~~Relative Cursor Position (claimed by @cart)~~ * [Relative cursor position][7199] ### ~~Const UI Config (claimed by @cart)~~ * [Add const to methods and const defaults to bevy_ui][5542] ### ~~Examples (claimed by @cart)~~ * [Add pixelated Bevy to assets and an example][6408] * [Organized scene_viewer into plugins for reuse and organization][6936] ### ~~CI Improvements (claimed by @cart)~~ * [add rust-version for MSRV and CI job to check][6852] * [msrv: only send a message on failure during the actual msrv part][7532] * [Make CI friendlier][7398] * [Fix CI welcome message][7428] * [add an action to ask for a migration guide when one is missing][7507] ### ~~SMEs (@cart)~~ This was already covered in another blog post. Just briefly call out what they are and that this is the first release that used them. Link to the other blog post. * [Subject Matter Experts and new Bevy Org docs][7185] [4775]: bevyengine/bevy#4775 [4777]: bevyengine/bevy#4777 [4853]: bevyengine/bevy#4853 [4927]: bevyengine/bevy#4927 [4928]: bevyengine/bevy#4928 [5400]: bevyengine/bevy#5400 [5428]: bevyengine/bevy#5428 [5542]: bevyengine/bevy#5542 [5589]: bevyengine/bevy#5589 [5900]: bevyengine/bevy#5900 [5950]: bevyengine/bevy#5950 [6028]: bevyengine/bevy#6028 [6035]: bevyengine/bevy#6035 [6129]: bevyengine/bevy#6129 [6179]: bevyengine/bevy#6179 [6245]: bevyengine/bevy#6245 [6284]: bevyengine/bevy#6284 [6305]: bevyengine/bevy#6305 [6320]: bevyengine/bevy#6320 [6391]: bevyengine/bevy#6391 [6408]: bevyengine/bevy#6408 [6412]: bevyengine/bevy#6412 [6503]: bevyengine/bevy#6503 [6524]: bevyengine/bevy#6524 [6547]: bevyengine/bevy#6547 [6557]: bevyengine/bevy#6557 [6560]: bevyengine/bevy#6560 [6561]: bevyengine/bevy#6561 [6564]: bevyengine/bevy#6564 [6587]: bevyengine/bevy#6587 [6644]: bevyengine/bevy#6644 [6649]: bevyengine/bevy#6649 [6681]: bevyengine/bevy#6681 [6694]: bevyengine/bevy#6694 [6696]: bevyengine/bevy#6696 [6722]: bevyengine/bevy#6722 [6743]: bevyengine/bevy#6743 [6785]: bevyengine/bevy#6785 [6800]: bevyengine/bevy#6800 [6802]: bevyengine/bevy#6802 [6809]: bevyengine/bevy#6809 [6817]: bevyengine/bevy#6817 [6831]: bevyengine/bevy#6831 [6833]: bevyengine/bevy#6833 [6843]: bevyengine/bevy#6843 [6852]: bevyengine/bevy#6852 [6885]: bevyengine/bevy#6885 [6900]: bevyengine/bevy#6900 [6902]: bevyengine/bevy#6902 [6922]: bevyengine/bevy#6922 [6926]: bevyengine/bevy#6926 [6936]: bevyengine/bevy#6936 [6940]: bevyengine/bevy#6940 [6944]: bevyengine/bevy#6944 [6965]: bevyengine/bevy#6965 [6988]: bevyengine/bevy#6988 [6995]: bevyengine/bevy#6995 [7015]: bevyengine/bevy#7015 [7023]: bevyengine/bevy#7023 [7024]: bevyengine/bevy#7024 [7046]: bevyengine/bevy#7046 [7051]: bevyengine/bevy#7051 [7053]: bevyengine/bevy#7053 [7060]: bevyengine/bevy#7060 [7063]: bevyengine/bevy#7063 [7064]: bevyengine/bevy#7064 [7069]: bevyengine/bevy#7069 [7083]: bevyengine/bevy#7083 [7084]: bevyengine/bevy#7084 [7087]: bevyengine/bevy#7087 [7094]: bevyengine/bevy#7094 [7097]: bevyengine/bevy#7097 [7185]: bevyengine/bevy#7185 [7199]: bevyengine/bevy#7199 [7205]: bevyengine/bevy#7205 [7206]: bevyengine/bevy#7206 [7248]: bevyengine/bevy#7248 [7267]: bevyengine/bevy#7267 [7298]: bevyengine/bevy#7298 [7311]: bevyengine/bevy#7311 [7321]: bevyengine/bevy#7321 [7324]: bevyengine/bevy#7324 [7325]: bevyengine/bevy#7325 [7354]: bevyengine/bevy#7354 [7356]: bevyengine/bevy#7356 [7364]: bevyengine/bevy#7364 [7381]: bevyengine/bevy#7381 [7398]: bevyengine/bevy#7398 [7399]: bevyengine/bevy#7399 [7415]: bevyengine/bevy#7415 [7428]: bevyengine/bevy#7428 [7431]: bevyengine/bevy#7431 [7444]: bevyengine/bevy#7444 [7445]: bevyengine/bevy#7445 [7446]: bevyengine/bevy#7446 [7448]: bevyengine/bevy#7448 [7456]: bevyengine/bevy#7456 [7463]: bevyengine/bevy#7463 [7466]: bevyengine/bevy#7466 [7481]: bevyengine/bevy#7481 [7483]: bevyengine/bevy#7483 [7493]: bevyengine/bevy#7493 [7507]: bevyengine/bevy#7507 [7510]: bevyengine/bevy#7510 [7512]: bevyengine/bevy#7512 [7517]: bevyengine/bevy#7517 [7518]: bevyengine/bevy#7518 [7532]: bevyengine/bevy#7532 [7535]: bevyengine/bevy#7535 [7546]: bevyengine/bevy#7546 [7547]: bevyengine/bevy#7547 [7559]: bevyengine/bevy#7559 [7568]: bevyengine/bevy#7568 [7579]: bevyengine/bevy#7579 [7594]: bevyengine/bevy#7594 [7605]: bevyengine/bevy#7605 [7639]: bevyengine/bevy#7639 [7642]: bevyengine/bevy#7642 [7653]: bevyengine/bevy#7653 [7701]: bevyengine/bevy#7701 [7737]: bevyengine/bevy#7737 [7756]: bevyengine/bevy#7756 Co-authored-by: François <mockersf@gmail.com> Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: Mike <mike.hsu@gmail.com> Co-authored-by: Boxy <supbscripter@gmail.com> Co-authored-by: IceSentry <c.giguere42@gmail.com> Co-authored-by: JoJoJet <21144246+JoJoJet@users.noreply.github.com> Co-authored-by: Aevyrie <aevyrie@gmail.com> Co-authored-by: James Liu <contact@jamessliu.com> Co-authored-by: Marco Buono <thecoreh@gmail.com> Co-authored-by: Aceeri <conmcclusk@gmail.com>

hymm requested a review from james7132 January 4, 2023 06:03

james7132 requested changes Jan 4, 2023

View reviewed changes

crates/bevy_tasks/src/thread_executor.rs Outdated Show resolved Hide resolved

crates/bevy_tasks/src/thread_executor.rs Outdated Show resolved Hide resolved

crates/bevy_tasks/src/thread_executor.rs Outdated Show resolved Hide resolved

james7132 added C-Feature A new feature, making something new possible A-Tasks Tools for parallel and async work labels Jan 4, 2023

hymm changed the title ~~Thread executor~~ Thread executor for running tasks on specific threads. Jan 4, 2023

DevinLeamy reviewed Jan 4, 2023

View reviewed changes

crates/bevy_tasks/src/thread_executor.rs Outdated Show resolved Hide resolved

crates/bevy_tasks/src/task_pool.rs Show resolved Hide resolved

james7132 approved these changes Jan 5, 2023

View reviewed changes

crates/bevy_tasks/src/thread_executor.rs Outdated Show resolved Hide resolved

hymm force-pushed the thread-executor branch from 806117b to aa678b3 Compare January 7, 2023 22:16

mockersf reviewed Jan 8, 2023

View reviewed changes

crates/bevy_tasks/src/thread_executor.rs Outdated Show resolved Hide resolved

hymm force-pushed the thread-executor branch from 5d228cd to c260e7c Compare January 9, 2023 20:13

mockersf reviewed Jan 9, 2023

View reviewed changes

crates/bevy_tasks/src/thread_executor.rs Outdated Show resolved Hide resolved

james7132 requested review from mockersf and DevinLeamy January 9, 2023 22:30

hymm requested review from maniwani and DevinLeamy and removed request for DevinLeamy January 9, 2023 22:41

DevinLeamy approved these changes Jan 10, 2023

View reviewed changes

hymm added 8 commits January 9, 2023 20:52

port code from pipelined rendering branch

d81dc6a

add an example

0914698

fix review comments

0078a34

rename related structs to be more clear

f096ffd

fix docs

d4a0042

remove spawner

34fd7a3

change ticker to use reference

beb9632

remove arc from executor

595b97b

hymm force-pushed the thread-executor branch from 958b8e5 to 595b97b Compare January 10, 2023 06:01

use better names for lifetimes

6015440

hymm requested a review from james7132 January 10, 2023 06:18

james7132 approved these changes Jan 10, 2023

View reviewed changes

james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 10, 2023

alice-i-cecile approved these changes Jan 10, 2023

View reviewed changes

maniwani approved these changes Jan 10, 2023

View reviewed changes

bors bot changed the title ~~Thread executor for running tasks on specific threads.~~ [Merged by Bors] - Thread executor for running tasks on specific threads. Jan 10, 2023

bors bot closed this Jan 10, 2023

hymm mentioned this pull request Feb 22, 2023

create a new scope executor for every scope #7564

Closed

cart mentioned this pull request Feb 24, 2023

[Merged by Bors] - News: Release 0.10.0 bevyengine/bevy-website#546

Closed

hymm deleted the thread-executor branch October 5, 2023 17:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - Thread executor for running tasks on specific threads. #7087

[Merged by Bors] - Thread executor for running tasks on specific threads. #7087

hymm commented Jan 4, 2023

maniwani commented Jan 10, 2023

DevinLeamy left a comment

hymm commented Jan 10, 2023

hymm commented Jan 10, 2023 •

edited

Loading

maniwani commented Jan 10, 2023 •

edited

Loading

alice-i-cecile left a comment

alice-i-cecile commented Jan 10, 2023

bors bot commented Jan 10, 2023

hymm commented Jan 10, 2023

alice-i-cecile commented Jan 10, 2023

bors bot commented Jan 10, 2023

[Merged by Bors] - Thread executor for running tasks on specific threads. #7087

[Merged by Bors] - Thread executor for running tasks on specific threads. #7087

Conversation

hymm commented Jan 4, 2023

Objective

Solution

Changelog

maniwani commented Jan 10, 2023

DevinLeamy left a comment

Choose a reason for hiding this comment

hymm commented Jan 10, 2023

hymm commented Jan 10, 2023 • edited Loading

maniwani commented Jan 10, 2023 • edited Loading

alice-i-cecile left a comment

Choose a reason for hiding this comment

alice-i-cecile commented Jan 10, 2023

bors bot commented Jan 10, 2023

hymm commented Jan 10, 2023

alice-i-cecile commented Jan 10, 2023

bors bot commented Jan 10, 2023

hymm commented Jan 10, 2023 •

edited

Loading

maniwani commented Jan 10, 2023 •

edited

Loading