Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow easier override of default plugins #721

Closed
wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

Somewhat related to #65

My use case is to allow the use of a different AssetPlugin. With this PR, I can do:

let mut default_plugins = bevy::DefaultPluginBuilder::default();
default_plugins.with_custom::<bevy::asset::AssetPlugin>(|builder| {
    // setup my custom plugin replacing `AssetPlugin`
});
App::build()
    .add_default_plugins_with_builder(default_plugins)
    .run();

@Moxinilian Moxinilian added A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible labels Oct 23, 2020
@cart
Copy link
Member

cart commented Oct 29, 2020

I like this, but I think I'd prefer it if it was a bit more generic. I put together an alternative that I think covers your use case, but also allows us to re-use it for other "plugin groups".

#744

@cart
Copy link
Member

cart commented Oct 29, 2020

I'm closing this for now, but I'm happy to re-open if you want to discuss this further.

@cart cart closed this Oct 29, 2020
@mockersf mockersf deleted the default-plugin branch April 27, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants