-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example to demonstrate manual generation and UV mapping of 3D mesh (generate_custom_mesh) solve #4922 #8909
Conversation
You added a new example but didn't update the readme. Please run |
Can you swap to a more descriptive title? :) This won't be very useful when looking at the git log or commit list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is worthwhile. I don't think we had an example demonstrating how to create and edit meshes before. It's nice to show how to access and set mesh attributes. Very important, as it's something I'd suspect everyone making a 3d game would need to eventually do.
What I'd like to see
So what needs to be done:
- Rename the example to something more descriptive
- Remove the
assets/textures/custom_image_for_example.png
and use
array_texture.png
in the example instead. - Fix the direction labels in comments
- Fix wording in "see docs"
- (optionally) a very small bit of "update the UVs to different values when
a key is pressed" in the example, this would also showcase how to edit
an existing mesh.
format Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
You added a new example but didn't update the readme. Please run |
Changed the texture, added a toggle to switch between textures, clean up & format |
Co-authored-by: Sélène Amanita <134181069+Selene-Amanita@users.noreply.github.com>
Co-authored-by: Sélène Amanita <134181069+Selene-Amanita@users.noreply.github.com>
Thank you both for your patience and thorough work on this! |
Co-authored-by: Sélène Amanita <134181069+Selene-Amanita@users.noreply.github.com>
Co-authored-by: Sélène Amanita <134181069+Selene-Amanita@users.noreply.github.com>
I put a lot of nitpicky comments, but I'm actually pleased by this example even if we ignore my proposed changes, it looks really nice and is pretty clear, looks good to me (modulo typos), good job! |
Co-authored-by: Sélène Amanita <134181069+Selene-Amanita@users.noreply.github.com>
Co-authored-by: Sélène Amanita <134181069+Selene-Amanita@users.noreply.github.com>
Co-authored-by: Sélène Amanita <134181069+Selene-Amanita@users.noreply.github.com>
Co-authored-by: Sélène Amanita <134181069+Selene-Amanita@users.noreply.github.com>
Sorry for all the typos, I swear I read these back but it's like I'm blind to them... |
Awesome work, merging now! |
No problem for the typos, happens to everybody I think I have notifications but it's not really a problem and it can probably be changed in settings, do what it takes to make the best PR you can don't worry about that ^^ |
Objective
Solution
Changelog