Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove cruft from unit_buildmenu_config.lua." #3957

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

WatchTheFort
Copy link
Member

Reverts #3935

unitName and showWaterUnits were being used by callers.

@WatchTheFort WatchTheFort merged commit f6dadd3 into master Nov 21, 2024
@WatchTheFort WatchTheFort deleted the revert-3935-rhys/grid-menu-cleanup-no-docs branch November 21, 2024 21:28
@rhys-vdw
Copy link
Contributor

rhys-vdw commented Nov 22, 2024

@WatchTheFort which callers? I couldn't find any references within this repo.

@robertthepie
Copy link
Contributor

robertthepie commented Nov 22, 2024

which callers?

Error in DrawScreen(): [string "LuaUI/Widgets/gui_buildmenu.lua"]:751: attempt to index field 'unitName' (a nil value)
Removed widget: Build menu

unfortunately this may have done damage for a notable term, as if this happened to a user then both of their build menu widgets now turn off by default

@rhys-vdw
Copy link
Contributor

Thanks @robertthepie, will look into it because that's an empty table (unless mutated from another context). However... Still a big mistake on my part. Not sure how I missed that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants