Show selected unit in legacy build menu pre-game #3963
+1
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use correct lookup table: `units.unitName` is always empty, but there is a table local to this file that can be used. - Do not invert the build command ID, the names are keyed by positive ID.
Table was not initialized nor referenced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work done
This fixes a bug where the currently selected build option is not highighted in the build menu when placing buildings pre-game.
I found this while investigating use of empty
units.unitNametable (#3957 (comment)).This table has been empty since e0f02ae, but there is a local table for the same purpose in
gui_buildmenu.luathat is used instead.units.unitNameis always empty, but there is a table local to this file that can be used.unitNamefromunit_buildmenu_config.luawhich is now definitely not referenced anywhere.Test steps
Screenshots
BEFORE:
Mex is not highlighed
AFTER:
Mex is highlighed