Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update tooling #527

Merged
merged 6 commits into from
Nov 24, 2024
Merged

chore: update tooling #527

merged 6 commits into from
Nov 24, 2024

Conversation

sakulstra
Copy link
Contributor

@sakulstra sakulstra commented Nov 21, 2024 •
edited
Loading

BREAKING CHANGES:

  • updates to a new version of catapulta-verify which relies on etherscan api v2 and generalizes the routescan verification. Please add a ETHERSCAN_API_KEY without any network suffix to your .env. This new version should be more reliable and support a bigger set of networks.

  • new version of origin and aave-cli. Please run npm i to update. The new version will no longer generate IRs inside .assets/, but instead inline an image link, which in theory could also be embedded in aips.

@sakulstra sakulstra marked this pull request as ready for review November 21, 2024 20:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

🌈Test Results No files changed, compilation skipped 2024-11-22T08:10:55.197523Z ERROR cheatcodes: non-empty stderr input=["npx", "@bgd-labs/aave-cli@^1.1.12", "diff-snapshots", "./reports/AaveV3Arbitrum_GHOStewardV2Upgrade_20241007_before.json", "./reports/AaveV3Arbitrum_GHOStewardV2Upgrade_20241007_after.json", "-o", "./diffs/AaveV3Arbitrum_GHOStewardV2Upgrade_20241007_before_AaveV3Arbitrum_GHOStewardV2Upgrade_20241007_after.md"] stderr="npm warn exec The following package was not found and will be installed: @bgd-labs/aave-cli@1.1.12\n"

Ran 9 tests for src/20241007_Multi_GHOStewardV2Upgrade/AaveV3Arbitrum_GHOStewardV2Upgrade_20241007.t.sol:AaveV3Arbitrum_GHOStewardV2Upgrade_20241007_Test
[PASS] test_defaultProposalExecution() (gas: 48832857)
Logs:
0xDA10009cBd5D07dd0CeCc66161FC93D7c9000da1
0xf97f4df75117a78c1A5a0DBb814Af92458539FB4
0xFF970A61A04b1cA14834A43f5dE4533eBDDB5CC8
0x2f2a2543B76A4166549F7aaB2e75Bef0aefC5B0f
0x82aF49447D8a07e3bd95BD0d56f35241523fBab1
0xFd086bC7CD5C481DCC9C85ebE478A1C0b69FCbb9
0xD22a58f79e9481D1a88e00c343885A588b34b68B
0x5979D7b546E38E414F7E9822514be443A4800529
0x3F56e0c36d275367b8C502090EDF38289b3dEa0d
0xEC70Dcb4A1EFa46b8F2D97C310C9c4790ba5ffA8
0x93b346b6BC2548dA6A1E7d98E9a421B42541425b
0xaf88d065e77c8cC2239327C5EDb3A432268e5831
0x17FC002b466eEc40DaE837Fc4bE5c67993ddBd6F
0x912CE59144191C1204E64559FE8253a0e49E6548
0x35751007a407ca6FEFfE80b3cB397736D2cf4dbe
0x7dfF72693f6A4149b17e7C6314655f6A9F7c8B33
E2E: Collateral DAI, TestAsset DAI
SUPPLY: DAI, Amount: 100007296532355000620845
SUPPLY: DAI, Amount: 1000072965323550006208
WITHDRAW: DAI, Amount: 500036482661775003104
WITHDRAW: DAI, Amount: 500036482661775003103
BORROW: DAI, Amount 1000072965323550006208
REPAY: DAI, Amount: 1000072965323550006208
E2E: Collateral DAI, TestAsset LINK
SUPPLY: DAI, Amount: 100007296532355000620845
SUPPLY: LINK, Amount: 87171038294237122658
WITHDRAW: LINK, Amount: 43585519147118561329
WITHDRAW: LINK, Amount: 43585519147118561330
BORROW: LINK, Amount 87171038294237122658
REPAY: LINK, Amount: 87171038294237122658
E2E: Collateral DAI, TestAsset USDC
SUPPLY: DAI, Amount: 100007296532355000620845
SUPPLY: USDC, Amount: 1000175260
WITHDRAW: USDC, Amount: 500087630
WITHDRAW: USDC, Amount: 500087630
BORROW: USDC, Amount 1000175260
REPAY: USDC, Amount: 1000175260
E2E: Collateral DAI, TestAsset WBTC
SUPPLY: DAI, Amount: 100007296532355000620845
SUPPLY: WBTC, Amount: 1494804
WITHDRAW: WBTC, Amount: 747402
WITHDRAW: WBTC, Amount: 747401
BORROW: WBTC, Amount 1494804
REPAY: WBTC, Amount: 1494804
E2E: Collateral DAI, TestAsset WETH
SUPPLY: DAI, Amount: 100007296532355000620845
SUPPLY: WETH, Amount: 380681382635380162
WITHDRAW: WETH, Amount: 190340691317690081
WITHDRAW: WETH, Amount: 190340691317690081
BORROW: WETH, Amount 380681382635380162
REPAY: WETH, Amount: 380681382635380162
E2E: Collateral DAI, TestAsset USDT
SUPPLY: DAI, Amount: 100007296532355000620845
SUPPLY: USDT, Amount: 1000620384
WITHDRAW: USDT, Amount: 500310192
WITHDRAW: USDT, Amount: 500310193
BORROW: USDT, Amount 1000620384
REPAY: USDT, Amount: 1000620384
E2E: Collateral DAI, TestAsset AAVE
SUPPLY: DAI, Amount: 100007296532355000620845
SUPPLY: AAVE, Amount: 6278583250246748321
WITHDRAW: AAVE, Amount: 3139291625123374160
WITHDRAW: AAVE, Amount: 3139291625123374161
E2E: TestAsset EURS SKIPPED
E2E: Collateral DAI, TestAsset wstETH
SUPPLY: DAI, Amount: 100007296532355000620845
SUPPLY: wstETH, Amount: 322086555915717169
WITHDRAW: wstETH, Amount: 161043277957858584
WITHDRAW: wstETH, Amount: 161043277957858584
BORROW: wstETH, Amount 322086555915717169
REPAY: wstETH, Amount: 322086555915717169
E2E: TestAsset MAI SKIPPED
E2E: Collateral DAI, TestAsset rETH
SUPPLY: DAI, Amount: 100007296532355000620845
SUPPLY: rETH, Amount: 340405046107453732
WITHDRAW: rETH, Amount: 170202523053726866
WITHDRAW: rETH, Amount: 170202523053726866
BORROW: rETH, Amount 340405046107453732
REPAY: rETH, Amount: 340405046107453732
E2E: Collateral DAI, TestAsset LUSD
SUPPLY: DAI, Amount: 100007296532355000620845
SUPPLY: LUSD, Amount: 1002075920518464461347
WITHDRAW: LUSD, Amount: 501037960259232230673
WITHDRAW: LUSD, Amount: 501037960259232230674
BORROW: LUSD, Amount 1002075920518464461347
REPAY: LUSD, Amount: 1002075920518464461347
E2E: Collateral DAI, TestAsset USDC
SUPPLY: DAI, Amount: 100007296532355000620845
SUPPLY: USDC, Amount: 1000175260
WITHDRAW: USDC, Amount: 500087630
WITHDRAW: USDC, Amount: 500087630
BORROW: USDC, Amount 1000175260
REPAY: USDC, Amount: 1000175260
E2E: Collateral DAI, TestAsset FRAX
SUPPLY: DAI, Amount: 100007296532355000620845
SUPPLY: FRAX, Amount: 1003149528385299622105
WITHDRAW: FRAX, Amount: 501574764192649811052
WITHDRAW: FRAX, Amount: 501574764192649811054
BORROW: FRAX, Amount 1003149528385299622105
REPAY: FRAX, Amount: 1003149528385299622105
E2E: Collateral DAI, TestAsset ARB
SUPPLY: DAI, Amount: 100007296532355000620845
SUPPLY: ARB, Amount: 1753049003627426528795
WITHDRAW: ARB, Amount: 876524501813713264397
WITHDRAW: ARB, Amount: 876524501813713264399
BORROW: ARB, Amount 1753049003627426528795
REPAY: ARB, Amount: 1753049003627426528795
E2E: Collateral DAI, TestAsset weETH
SUPPLY: DAI, Amount: 100007296532355000620845
SUPPLY: weETH, Amount: 362441574896413661
WITHDRAW: weETH, Amount: 181220787448206830
WITHDRAW: weETH, Amount: 181220787448206831
BORROW: weETH, Amount 362441574896413661
REPAY: weETH, Amount: 362441574896413661
E2E: Collateral DAI, TestAsset GHO
SUPPLY: DAI, Amount: 100007296532355000620845
SUPPLY: GHO, Amount: 1000000000000000000000
WITHDRAW: GHO, Amount: 500000000000000000000
WITHDRAW: GHO, Amount: 500000000000000000001
BORROW: GHO, Amount 1000000000000000000000
REPAY: GHO, Amount: 1000000000000000000000

[PASS] test_ghoAaveSteward_updateGhoBorrowRate() (gas: 522493)
[PASS] test_ghoBucketSteward_setControlledFacilitator() (gas: 312024)
[PASS] test_ghoBucketSteward_updateFacilitatorBucketCapacity() (gas: 335166)
[PASS] test_ghoCcipSteward_revertUpdateRateLimitUnauthorizedBeforeUpgrade() (gas: 66668)
[PASS] test_ghoCcipSteward_updateRateLimit() (gas: 324228)
[PASS] test_ghoCcipSteward_updateRateLimitAfterPoolUpgrade() (gas: 398985)
[PASS] test_poolTokenFunctionality() (gas: 301215)
[PASS] test_rolesAreSet_cannotReinitializePoolToken() (gas: 335609)
Suite result: ok. 9 passed; 0 failed; 0 skipped; finished in 16.49s (15.56s CPU time)

Ran 1 test suite in 16.50s (16.49s CPU time): 9 tests passed, 0 failed, 0 skipped (9 total tests)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

🔧 Build logs 
Compiling 351 files with Solc 0.8.20
Solc 0.8.20 finished in 172.54s
Compiler run successful with warnings:
Warning (5667): Unused function parameter. Remove or comment out the variable name to silence this warning.
   --> lib/aave-helpers/src/swaps/AaveSwapper.sol:146:5:
    |
146 |     address erc20Token
    |     ^^^^^^^^^^^^^^^^^^

Warning (2018): Function state mutability can be restricted to pure
   --> lib/aave-helpers/src/swaps/AaveSwapper.sol:145:3:
    |
145 |   function maxRescue(
    |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to pure
   --> lib/aave-helpers/src/ProtocolV2TestBase.sol:663:3:
    |
663 |   function _logReserveConfig(ReserveConfig memory config) internal view {
    |   ^ (Relevant source part starts here and spans across multiple lines).

| Contract                                                                                    | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|---------------------------------------------------------------------------------------------|------------------|-------------------|--------------------|---------------------|
| AaveGovernanceV2                                                                            |               44 |                94 |             24,532 |              49,058 |
| AaveSafetyModule                                                                            |               44 |                94 |             24,532 |              49,058 |
| AaveSwapper                                                                                 |            5,444 |             5,880 |             19,132 |              43,272 |
| AaveV2Avalanche                                                                             |               44 |                94 |             24,532 |              49,058 |
| AaveV2AvalancheAssets                                                                       |               44 |                94 |             24,532 |              49,058 |
| AaveV2Avalanche_ReserveFactorUpdatesMidOctober_20241004                                     |              988 |             1,017 |             23,588 |              48,135 |
| AaveV2Avalanche_UpdateLegacyGuardian_20241016                                               |              348 |               486 |             24,228 |              48,666 |
| AaveV2Ethereum                                                                              |               44 |                94 |             24,532 |              49,058 |
| AaveV2EthereumAMM                                                                           |               44 |                94 |             24,532 |              49,058 |
| AaveV2EthereumAMMAssets                                                                     |               44 |                94 |             24,532 |              49,058 |
| AaveV2EthereumAMM_UpdateLegacyGuardian_20241016                                             |              348 |               486 |             24,228 |              48,666 |
| AaveV2EthereumAssets                                                                        |               44 |                94 |             24,532 |              49,058 |
| AaveV2Ethereum_ReserveFactorUpdatesMidOctober_20241004                                      |              988 |             1,017 |             23,588 |              48,135 |
| AaveV2Ethereum_UpdateLegacyGuardian_20241016                                                |              348 |               486 |             24,228 |              48,666 |
| AaveV2Polygon                                                                               |               44 |                94 |             24,532 |              49,058 |
| AaveV2PolygonAssets                                                                         |               44 |                94 |             24,532 |              49,058 |
| AaveV2Polygon_ReserveFactorUpdatesMidOctober_20241004                                       |            2,384 |             2,454 |             22,192 |              46,698 |
| AaveV2Polygon_UpdateLegacyGuardian_20241016                                                 |              348 |               486 |             24,228 |              48,666 |
| AaveV3Arbitrum                                                                              |               44 |                94 |             24,532 |              49,058 |
| AaveV3ArbitrumAssets                                                                        |               44 |                94 |             24,532 |              49,058 |
| AaveV3ArbitrumEModes                                                                        |               44 |                94 |             24,532 |              49,058 |
| AaveV3ArbitrumExternalLibraries                                                             |               44 |                94 |             24,532 |              49,058 |
| AaveV3Arbitrum_GHOCCIP150Upgrade_20241021                                                   |              817 |               846 |             23,759 |              48,306 |
| AaveV3Arbitrum_GHOStewardV2Upgrade_20241007                                                 |            1,360 |             1,389 |             23,216 |              47,763 |
| AaveV3Arbitrum_ReserveFactorUpdatesMidOctober_20241004                                      |            3,227 |             3,297 |             21,349 |              45,855 |
| AaveV3Arbitrum_RiskStewardPhase2_20240805                                                   |              307 |               336 |             24,269 |              48,816 |
| AaveV3Arbitrum_UpdateLegacyGuardian_20241016                                                |            1,062 |             1,393 |             23,514 |              47,759 |
| AaveV3Avalanche                                                                             |               44 |                94 |             24,532 |              49,058 |
| AaveV3AvalancheAssets                                                                       |               44 |                94 |             24,532 |              49,058 |
| AaveV3AvalancheEModes                                                                       |               44 |                94 |             24,532 |              49,058 |
| AaveV3AvalancheExternalLibraries                                                            |               44 |                94 |             24,532 |              49,058 |
| AaveV3Avalanche_RiskStewardPhase2_20240805                                                  |              178 |               206 |             24,398 |              48,946 |
| AaveV3Avalanche_UpdateLegacyGuardian_20241016                                               |            1,062 |             1,393 |             23,514 |              47,759 |
| AaveV3BNB                                                                                   |               44 |                94 |             24,532 |              49,058 |
| AaveV3BNBAssets                                                                             |               44 |                94 |             24,532 |              49,058 |
| AaveV3BNBEModes                                                                             |               44 |                94 |             24,532 |              49,058 |
| AaveV3BNBExternalLibraries                                                                  |               44 |                94 |             24,532 |              49,058 |
| AaveV3BNB_OnboardWstETHToAaveV3OnBNBChain_20241030                                          |            5,561 |             5,632 |             19,015 |              43,520 |
| AaveV3BNB_RiskStewardPhase2_20240805                                                        |              178 |               206 |             24,398 |              48,946 |
| AaveV3BNB_UpdateLegacyGuardian_20241016                                                     |            1,062 |             1,393 |             23,514 |              47,759 |
| AaveV3Base                                                                                  |               44 |                94 |             24,532 |              49,058 |
| AaveV3BaseAssets                                                                            |               44 |                94 |             24,532 |              49,058 |
| AaveV3BaseEModes                                                                            |               44 |                94 |             24,532 |              49,058 |
| AaveV3BaseExternalLibraries                                                                 |               44 |                94 |             24,532 |              49,058 |
| AaveV3Base_IncreaseCbBTCSupplyCaps_20241004                                                 |            3,146 |             3,216 |             21,430 |              45,936 |
| AaveV3Base_ReserveFactorUpdatesMidOctober_20241004                                          |            3,223 |             3,293 |             21,353 |              45,859 |
| AaveV3Base_RiskStewardPhase2_20240805                                                       |              178 |               206 |             24,398 |              48,946 |
| AaveV3Base_UpdateLegacyGuardian_20241016                                                    |            1,062 |             1,393 |             23,514 |              47,759 |
| AaveV3Ethereum                                                                              |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumAssets                                                                        |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumEModes                                                                        |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumEtherFi                                                                       |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumEtherFiAssets                                                                 |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumEtherFiEModes                                                                 |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumEtherFiExternalLibraries                                                      |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumEtherFi_RiskStewardPhase2_20240805                                            |              178 |               206 |             24,398 |              48,946 |
| AaveV3EthereumExternalLibraries                                                             |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumLido                                                                          |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumLidoAssets                                                                    |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumLidoEModes                                                                    |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumLidoExternalLibraries                                                         |               44 |                94 |             24,532 |              49,058 |
| AaveV3EthereumLido_AutomatedAGRSActivation_20241108                                         |            3,046 |             3,075 |             21,530 |              46,077 |
| AaveV3EthereumLido_OnboardAndEnableSUSDeLiquidEModeOnAaveV3MainnetAndLidoInstances_20241108 |            5,657 |             5,728 |             18,919 |              43,424 |
| AaveV3EthereumLido_OnboardEzETHToLidoInstance_20241021                                      |            6,194 |             6,265 |             18,382 |              42,887 |
| AaveV3EthereumLido_RiskStewardPhase2_20240805                                               |              178 |               206 |             24,398 |              48,946 |
| AaveV3EthereumLido_WstETHSlope1UoptimalUpdate_20241001                                      |            3,250 |             3,320 |             21,326 |              45,832 |
| AaveV3Ethereum_AaveBGDPhase4_20241025                                                       |            1,407 |             1,436 |             23,169 |              47,716 |
| AaveV3Ethereum_AaveCertoraContinuousSecurityServices_20241014                               |            1,567 |             1,596 |             23,009 |              47,556 |
| AaveV3Ethereum_ChaosLabsAaveRiskManagementServiceRenewal_20241012                           |            1,255 |             1,284 |             23,321 |              47,868 |
| AaveV3Ethereum_FixUSDSBorrowRateToMatchSkySavingsRate_20241022                              |            3,238 |             3,308 |             21,338 |              45,844 |
| AaveV3Ethereum_GHOCCIP150Upgrade_20241021                                                   |              817 |               846 |             23,759 |              48,306 |
| AaveV3Ethereum_GHOStewardV2Upgrade_20241007                                                 |            2,895 |             2,924 |             21,681 |              46,228 |
| AaveV3Ethereum_IncreaseCbBTCSupplyCaps_20241004                                             |            3,150 |             3,220 |             21,426 |              45,932 |
| AaveV3Ethereum_IncreaseUSDSBorrowRateToMatchSkySavingsRate_20241016                         |            3,239 |             3,309 |             21,337 |              45,843 |
| AaveV3Ethereum_OnboardAndEnableSUSDeLiquidEModeOnAaveV3MainnetAndLidoInstances_20241108     |            3,817 |             3,887 |             20,759 |              45,265 |
| AaveV3Ethereum_OnboardRsETHToAaveV3Ethereum_20241104                                        |            5,957 |             6,028 |             18,619 |              43,124 |
| AaveV3Ethereum_PYUSDReserveConfigurationUpdateIncentiveCampaign_20241031                    |            3,988 |             4,059 |             20,588 |              45,093 |
| AaveV3Ethereum_RemoveFraxFromIsolationModeOnAaveV3Mainnet_20241105                          |            3,226 |             3,296 |             21,350 |              45,856 |
| AaveV3Ethereum_RenewLlamaRiskAsRiskServiceProvider_20241013                                 |            1,068 |             1,097 |             23,508 |              48,055 |
| AaveV3Ethereum_RiskStewardPhase2_20240805                                                   |              307 |               336 |             24,269 |              48,816 |
| AaveV3Ethereum_SafetyModuleStkAAVEReEnableRewards_20241106                                  |              910 |               939 |             23,666 |              48,213 |
| AaveV3Ethereum_StkGHOIncentivesQ4_20241029                                                  |            1,458 |             1,487 |             23,118 |              47,665 |
| AaveV3Ethereum_UpdateLegacyGuardian_20241016                                                |            1,062 |             1,413 |             23,514 |              47,739 |
| AaveV3Ethereum_WstETHReserveBorrowRateUpdateMainInstance_20241024                           |            3,227 |             3,297 |             21,349 |              45,855 |
| AaveV3Gnosis                                                                                |               44 |                94 |             24,532 |              49,058 |
| AaveV3GnosisAssets                                                                          |               44 |                94 |             24,532 |              49,058 |
| AaveV3GnosisEModes                                                                          |               44 |                94 |             24,532 |              49,058 |
| AaveV3GnosisExternalLibraries                                                               |               44 |                94 |             24,532 |              49,058 |
| AaveV3Gnosis_ReserveFactorUpdatesMidOctober_20241004                                        |            3,225 |             3,295 |             21,351 |              45,857 |
| AaveV3Gnosis_RiskStewardPhase2_20240805                                                     |              178 |               206 |             24,398 |              48,946 |
| AaveV3Gnosis_UpdateLegacyGuardian_20241016                                                  |            1,062 |             1,393 |             23,514 |              47,759 |
| AaveV3Metis                                                                                 |               44 |                94 |             24,532 |              49,058 |
| AaveV3MetisAssets                                                                           |               44 |                94 |             24,532 |              49,058 |
| AaveV3MetisEModes                                                                           |               44 |                94 |             24,532 |              49,058 |
| AaveV3MetisExternalLibraries                                                                |               44 |                94 |             24,532 |              49,058 |
| AaveV3Metis_RiskStewardPhase2_20240805                                                      |              178 |               206 |             24,398 |              48,946 |
| AaveV3Metis_UpdateLegacyGuardian_20241016                                                   |            1,062 |             1,393 |             23,514 |              47,759 |
| AaveV3Optimism                                                                              |               44 |                94 |             24,532 |              49,058 |
| AaveV3OptimismAssets                                                                        |               44 |                94 |             24,532 |              49,058 |
| AaveV3OptimismEModes                                                                        |               44 |                94 |             24,532 |              49,058 |
| AaveV3OptimismExternalLibraries                                                             |               44 |                94 |             24,532 |              49,058 |
| AaveV3Optimism_ReserveFactorUpdatesMidOctober_20241004                                      |            3,227 |             3,297 |             21,349 |              45,855 |
| AaveV3Optimism_RiskStewardPhase2_20240805                                                   |              178 |               206 |             24,398 |              48,946 |
| AaveV3Optimism_UpdateLegacyGuardian_20241016                                                |            1,062 |             1,393 |             23,514 |              47,759 |
| AaveV3Polygon                                                                               |               44 |                94 |             24,532 |              49,058 |
| AaveV3PolygonAssets                                                                         |               44 |                94 |             24,532 |              49,058 |
| AaveV3PolygonEModes                                                                         |               44 |                94 |             24,532 |              49,058 |
| AaveV3PolygonExternalLibraries                                                              |               44 |                94 |             24,532 |              49,058 |
| AaveV3Polygon_ReserveFactorUpdatesMidOctober_20241004                                       |            3,226 |             3,296 |             21,350 |              45,856 |
| AaveV3Polygon_RiskStewardPhase2_20240805                                                    |              178 |               206 |             24,398 |              48,946 |
| AaveV3Polygon_UpdateLegacyGuardian_20241016                                                 |            1,062 |             1,393 |             23,514 |              47,759 |
| AaveV3Scroll                                                                                |               44 |                94 |             24,532 |              49,058 |
| AaveV3ScrollAssets                                                                          |               44 |                94 |             24,532 |              49,058 |
| AaveV3ScrollEModes                                                                          |               44 |                94 |             24,532 |              49,058 |
| AaveV3ScrollExternalLibraries                                                               |               44 |                94 |             24,532 |              49,058 |
| AaveV3Scroll_RiskStewardPhase2_20240805                                                     |              178 |               206 |             24,398 |              48,946 |
| AaveV3Scroll_UpdateLegacyGuardian_20241016                                                  |            1,062 |             1,393 |             23,514 |              47,759 |
| Address                                                                                     |               44 |                94 |             24,532 |              49,058 |
| CCIPUtils                                                                                   |            4,968 |             5,021 |             19,608 |              44,131 |
| ChainHelpers                                                                                |               44 |                94 |             24,532 |              49,058 |
| ChainIds                                                                                    |               44 |                94 |             24,532 |              49,058 |
| Client                                                                                      |              109 |               160 |             24,467 |              48,992 |
| CollectorUtils                                                                              |               44 |                94 |             24,532 |              49,058 |
| ConfiguratorInputTypes                                                                      |               44 |                94 |             24,532 |              49,058 |
| Create2Utils                                                                                |              121 |               172 |             24,455 |              48,980 |
| Create2UtilsZkSync                                                                          |              104 |               155 |             24,472 |              48,997 |
| DataTypes                                                                                   |               44 |                94 |             24,532 |              49,058 |
| ERC1967Proxy                                                                                |              122 |               967 |             24,454 |              48,185 |
| ERC1967Utils                                                                                |               44 |                94 |             24,532 |              49,058 |
| EngineFlags                                                                                 |               44 |                94 |             24,532 |              49,058 |
| Errors                                                                                      |            4,652 |             4,705 |             19,924 |              44,447 |
| GovV3Helpers                                                                                |            2,517 |             2,570 |             22,059 |              46,582 |
| GovV3StorageHelpers                                                                         |               44 |                94 |             24,532 |              49,058 |
| GovernanceGuardians                                                                         |              292 |               345 |             24,284 |              48,807 |
| GovernanceV3Arbitrum                                                                        |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3Avalanche                                                                       |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3BNB                                                                             |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3Base                                                                            |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3Ethereum                                                                        |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3Gnosis                                                                          |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3Metis                                                                           |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3Optimism                                                                        |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3Polygon                                                                         |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3PolygonZkEvm                                                                    |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3Scroll                                                                          |               44 |                94 |             24,532 |              49,058 |
| GovernanceV3ZkSync                                                                          |               44 |                94 |             24,532 |              49,058 |
| IpfsUtils                                                                                   |               44 |                94 |             24,532 |              49,058 |
| MiscArbitrum                                                                                |               44 |                94 |             24,532 |              49,058 |
| MiscAvalanche                                                                               |               44 |                94 |             24,532 |              49,058 |
| MiscBNB                                                                                     |               44 |                94 |             24,532 |              49,058 |
| MiscBase                                                                                    |               44 |                94 |             24,532 |              49,058 |
| MiscEthereum                                                                                |               44 |                94 |             24,532 |              49,058 |
| MiscGnosis                                                                                  |               44 |                94 |             24,532 |              49,058 |
| MiscMetis                                                                                   |               44 |                94 |             24,532 |              49,058 |
| MiscOptimism                                                                                |               44 |                94 |             24,532 |              49,058 |
| MiscPolygon                                                                                 |               44 |                94 |             24,532 |              49,058 |
| MiscScroll                                                                                  |               44 |                94 |             24,532 |              49,058 |
| Payloads                                                                                    |               44 |                94 |             24,532 |              49,058 |
| PayloadsControllerUtils                                                                     |               44 |                94 |             24,532 |              49,058 |
| ProtocolGuardians                                                                           |              292 |               345 |             24,284 |              48,807 |
| ProxyAdmin                                                                                  |              990 |             1,235 |             23,586 |              47,917 |
| ProxyHelpers                                                                                |               44 |                94 |             24,532 |              49,058 |
| RateLimiter                                                                                 |               44 |                94 |             24,532 |              49,058 |
| RenewalV2BasePayload                                                                        |              348 |               595 |             24,228 |              48,557 |
| RenewalV3BasePayload                                                                        |            1,062 |             1,509 |             23,514 |              47,643 |
| ReserveConfiguration                                                                        |              128 |               179 |             24,448 |              48,973 |
| RewardsDataTypes                                                                            |               44 |                94 |             24,532 |              49,058 |
| SafeCast                                                                                    |               44 |                94 |             24,532 |              49,058 |
| SafeERC20                                                                                   |               44 |                94 |             24,532 |              49,058 |
| StorageHelpers                                                                              |               44 |                94 |             24,532 |              49,058 |
| StorageSlot                                                                                 |               44 |                94 |             24,532 |              49,058 |
| TestNetChainIds                                                                             |               44 |                94 |             24,532 |              49,058 |
| TransparentUpgradeableProxy                                                                 |            1,088 |             2,274 |             23,488 |              46,878 |
| WadRayMath                                                                                  |               44 |                94 |             24,532 |              49,058 |
🔧 Build logs zksync 
Compiling 110 files with zksolc and ZKsync solc 0.8.20
zksolc and ZKsync solc 0.8.20 finished in 75.51s
Compiler run successful!
| Contract | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|----------|------------------|-------------------|--------------------|---------------------|

@sakulstra sakulstra merged commit b61496d into main Nov 24, 2024
4 checks passed
@sakulstra sakulstra deleted the fix/update-tooling branch November 24, 2024 19:36
DhairyaSethi added a commit to aave/aave-proposals-v3 that referenced this pull request Dec 25, 2024
@DhairyaSethi
fix: updates based on upstream changes from bgd-labs#527
7c0b73d
DhairyaSethi pushed a commit to aave/aave-proposals-v3 that referenced this pull request Dec 25, 2024
@sakulstra @DhairyaSethi
chore: update tooling (bgd-labs#527)
f8a4900 
**BREAKING CHANGES**:
- updates to a new version of **catapulta-verify** which relies on etherscan api v2 and generalizes the routescan verification. Please add a `ETHERSCAN_API_KEY` without any network suffix to your `.env`. This new version should be more reliable and support a bigger set of networks.

- new version of origin and `aave-cli`. Please run `npm i` to update. The new version will no longer generate IRs inside `.assets/`, but instead inline an image link, which in theory could also be embedded in aips.
DhairyaSethi added a commit to aave/aave-proposals-v3 that referenced this pull request Dec 25, 2024
@DhairyaSethi
fix: updates based on upstream changes from bgd-labs#527
9faf62d
brotherlymite pushed a commit that referenced this pull request Jan 16, 2025
@DhairyaSethi @parth-15
@miguelmtzinf @CanonicalJP
GHO CCIP 1.5.1 Upgrade Eth<>Arb (#557)
134c39c 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* chore: init aip

* feat: ccip 1.5.1 upgrade

* tmp: fix ci for aave org, to rm for bdg

* tmp: add 1.4 pool with withdrawLiq flattended, to be removed once impl is deployed

* tmp: fix ci for aave org

* revert: test ci secrets updates

* chore: fix comments

* chore: rm duplicate check

* chore: reorder imports, pending automation

* chore: import order

* chore: imports order, re-frame comment

* feat: update to latest spec: naming changes, setCurrentBridgedAmount, resolve existing pool bridgeAmount comment

* chore: consistency, cleanup comment based on latest approach

* upd: `directMint` & `directBurn`

* feat: add `gho-core` lib temporarily, fix interface

* feat: new gho ccip steward

* feat: reference existing pool upgrade impl deployment

* feat: more verbose and efficient

* chore: upd ccip lib

* test: cleanup & fuzzify

* test: cleanup & fuzzify

* chore: use latest deployment of existing remote pool upgrade

* doc: snapshot -> direct-to-aip

* chore: import gho from EthereumAssets instead of MiscEthereum

* chore: cleanup rm ProxyAdmin reference

* chore: rename facilitator

* chore: rm duplicate check

* fix: updates based on upstream changes from #527

* chore: fix&add comment, use chain selector from helper lib

* chore: fix chain selector lib typo

* feat: accept existing proxy pool ownership as well

* feat: add rate limit

* feat: add deployed token pools & stewards

* feat: rm `gho-core` & `ccip`

* feat: upd arb token pool & steward deployment

* feat: notify gho bucket steward

* feat: update aave steward

* chore: use existing IOwnable

* chore: new ccip stewards with timelock getter

* feat: use oz v5.1 proxies

* doc: add discussion + spec

* feat: chainlink pre-req have been performed

* Updated GHOCCIP151Upgrade.md

* Updated GHOCCIP151Upgrade.md

Updated to permalinks

* doc: lint and add steward addresses to spec md

* doc: expand on bucket steward update

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>
Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com>
Co-authored-by: JP <89362795+CanonicalJP@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyzia551 kyzia551 kyzia551 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakulstra @kyzia551