Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAM-1585] Support additional Illumina FASTQ metadata. #1586

Merged
merged 1 commit into from
Jul 11, 2017
Merged

[ADAM-1585] Support additional Illumina FASTQ metadata. #1586

merged 1 commit into from
Jul 11, 2017

Conversation

fnothaft
Copy link
Member

@fnothaft fnothaft commented Jul 2, 2017

Resolves #1585.

@fnothaft fnothaft added this to the 0.23.0 milestone Jul 2, 2017
@fnothaft
Copy link
Member Author

fnothaft commented Jul 2, 2017

As an aside, I was going to add a FASTQ with said metadata, but I don't have a FASTQ that I can share publically with it. I searched both ENA and SRA for reads with the metadata, but they appear to obliterate that metadata prior to upload.

@coveralls
Copy link

coveralls commented Jul 2, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 83.1% when pulling 1488bdc on fnothaft:issues/1585-fastq-metadata into 0306717 on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2172/
Test PASSed.

heuermh
heuermh requested changes Jul 7, 2017
View reviewed changes
Copy link
Member

@heuermh heuermh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also #1589, the pattern here will also need to be added to InterleavedFastqInputFormat.

@fnothaft
[ADAM-1585] Support additional Illumina FASTQ metadata.
61202b2 
Resolves bigdatagenomics#1585, bigdatagenomics#1589. Adds regex to cover new metadata that Illumina added into
FASTQ name line. Also, adds a regex to the InterleavedFastqInputFormat that
checks for a wider range of supported first-of-read ending suffices.
@fnothaft
Copy link
Member Author

Rebased and added code to address review comments. Resolves #1589 now as well.

@coveralls
Copy link

coveralls commented Jul 11, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 84.157% when pulling 61202b2 on fnothaft:issues/1585-fastq-metadata into 97a8498 on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2196/
Test PASSed.

@heuermh heuermh merged commit 7a11d9e into bigdatagenomics:master Jul 11, 2017
@heuermh
Copy link
Member

heuermh commented Jul 11, 2017

Thank you, @fnothaft

@fnothaft fnothaft deleted the issues/1585-fastq-metadata branch January 9, 2018 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heuermh heuermh heuermh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fnothaft @coveralls @AmplabJenkins @heuermh