A few random Predicate-related cleanups #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test FAILed. Build result: FAILUREGitHub pull request #457 of commit 90de3fe automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/457/merge^{commit} # timeout=10Checking out Revision 774b1e4 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 774b1e4 > git rev-list a7a2569f68f2981425bb14e2fffc1bdbd8024b8c # timeout=10Triggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.3.0,centos completed with result FAILURETest FAILed. |
|
hrm, the death rattle of the Jenkins job above showed a division by zero error in but I've run Jenkins, retest this please? |
|
nvm, I've repro'd this failure now. investigating |
|
Btw, I create PR #458 to fix the division by zero issue. -Matt On Mon, Nov 3, 2014 at 2:27 PM, Ryan Williams notifications@github.com
|
|
hm, but |
|
|
Yes, that seems the most likely explanation. We need to remove unused code anyway -- especially code that doesn't -Matt On Mon, Nov 3, 2014 at 2:48 PM, Ryan Williams notifications@github.com
|
ryan-williams
force-pushed
the
predicates
branch
from
90de3fe
to
ee90817
Compare
|
Test PASSed. |
|
cool, tests fixed, lmk if you guys have thoughts on these changes |
ryan-williams
force-pushed
the
predicates
branch
from
ee90817
to
723d9bb
Compare
|
Test PASSed. |
|
LGTM, can you squash and I'll merge? |
- simplify PredicateUtils wrapper - wrap some long lines - wrapper for FieldCondition[Boolean] creation - AlignmentRecordCondition creation conv. wrappers - add supplementaryAlignment to AlignmentRecordField
ryan-williams
force-pushed
the
predicates
branch
from
723d9bb
to
2038440
Compare
|
squashed |
fnothaft
added a commit
that referenced
this pull request
Nov 5, 2014
A few random Predicate-related cleanups
|
Merged! Thanks @ryan-williams! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made these while working on adding a predicate for use by
adam view, though I haven't gotten that to work yet, thought I'd send these out anyway.