Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compilation fails on jdk 9 [https://github.com/bigdatagenomics/bdg-fo… #166

Closed
wants to merge 1 commit into from
Closed

compilation fails on jdk 9 [https://github.com/bigdatagenomics/bdg-fo… #166

wants to merge 1 commit into from

Conversation

sreev
Copy link

@sreev sreev commented May 19, 2018

…rmats/issues/165]

  • fix jdk 9 compilation failure
  • add facility to change jdk source, target version; for any want to compile for java 8 or 10
  • upgrade versions of avro and plugins

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@heuermh
Copy link
Member

heuermh commented May 19, 2018

Jenkins, test this please

@fnothaft fnothaft mentioned this pull request May 21, 2018
Closed
@heuermh
Copy link
Member

heuermh commented Sep 19, 2018

Hello @sreev, I would like to close this pull request in favor of #168, which adds maven-compile-plugin configuration and bumps plugin versions as you do here.

Unfortunately we can't bump the Avro version in bdg-formats until we are also prepared to do so downstream in ADAM.

@heuermh heuermh added this to the 0.11.4 milestone Sep 20, 2018
@heuermh
Copy link
Member

heuermh commented Sep 20, 2018

Closing in favor of #168.

@heuermh heuermh closed this Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.4
Development

Successfully merging this pull request may close these issues.
3 participants
@sreev @AmplabJenkins @heuermh