Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use separate filtersFailed and filtersPassed arrays for variant quality filters #88

Merged
merged 1 commit into from
Jul 18, 2016
Merged

Use separate filtersFailed and filtersPassed arrays for variant quality filters #88

merged 1 commit into from
Jul 18, 2016

Conversation

heuermh
Copy link
Member

@heuermh heuermh commented Jul 6, 2016

Fixes #87

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/bdg-formats-prb/108/
Test PASSed.

@fnothaft
Copy link
Member

fnothaft commented Jul 6, 2016

LGTM. Will leave open until tomorrow for review.

@heuermh heuermh mentioned this pull request Jul 6, 2016
Closed
@heuermh heuermh mentioned this pull request Jul 18, 2016
Closed
61 tasks
@fnothaft fnothaft merged commit 7b69079 into bigdatagenomics:master Jul 18, 2016
@heuermh heuermh deleted the variant-filter branch July 18, 2016 21:58
@heuermh
Copy link
Member Author

heuermh commented Jul 18, 2016

Thanks!

@fnothaft
Copy link
Member

Thank you, @heuermh!

@fnothaft fnothaft mentioned this pull request Jul 26, 2016
Closed
fnothaft added a commit to fnothaft/bdg-formats that referenced this pull request Aug 24, 2016
@fnothaft
Revert "Use separate filtersFailed and filtersPassed arrays for varia…
29b4a23 
…nt quality filters (bigdatagenomics#88)"

This reverts commit 7b69079.
heuermh pushed a commit that referenced this pull request Aug 24, 2016
@fnothaft @heuermh
Revert back to 0.9.0 (#99)
b457b71 
* Revert "Complete refactoring of variant and related annotation records"

This reverts commit d77823d.

* Revert "Refactor variant and genotype annotations (#90)"

This reverts commit 5e81a9c.

* Revert "Use separate filtersFailed and filtersPassed arrays for variant quality filters (#88)"

This reverts commit 7b69079.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heuermh @AmplabJenkins @fnothaft