Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 8 #567

Closed
wants to merge 5 commits into from
Closed

Version 8 #567

wants to merge 5 commits into from

Conversation

dianjuar
Copy link
Member

@dianjuar dianjuar commented Jan 15, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What is the current behavior?

This PR should close:

#553, #516, #467
#445, #444, #443, #442, #441, #440, #439, #438, #437, #415
#74

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Here, you can find a more detailed explanation of the changes introduced in V8.

https://dev.to/dianjuar/whats-coming-to-ngx-deploy-npm-v8-23gn

@dianjuar dianjuar changed the title feat: drop support for Angular workspaces (#560) Version 8 Jan 16, 2024
@dianjuar dianjuar marked this pull request as ready for review January 16, 2024 21:22
We have decided to stop supporting Angular Workspaces and focus exclusively on Nx Workspaces. This
decision is motivated by several factors, including that the Nx Devkit no longer supports
compatibility with Angular Workspaces. To offer support, we would have to create a second plugin
that uses AngularDevkit under the hood, which would require considerable effort on the part of our
maintainers. We want to focus on what brings the most value to our current users, and Nx Workspaces
is the best way to do that.

BREAKING CHANGE: As an alternative, maintainers suggest migrating your Angular Workspaces to Nx
Workspaces if you want to use this plugin. A stand-alone approach to Nx workspaces is an option that
you should consider. We apologize for any inconvenience this may cause and appreciate your
understanding.
Deprecate the built-in build process in favor of `dependsOn` Nx feature.
Add support for libraries that doesn't require build process.

BREAKING CHANGE:
 - `ngx-deploy-npm:install`: Added `--dist-folder-path` option as
required.
 - `ngx-deploy-npm:install`: Drop the option `--projects`, now, each project needs to be specified
independently using `--project`.
 - `ngx-deploy-npm:deploy`: `distFolderPath` option is now required.
 - `ngx-deploy-npm:deploy`: Remove options `noBuild` and `buildTarget`.
Since semver is using `runExecutor`, it doesn't trigger the dependencies;
as quick fix we have to mark put it explicitly on `postTargets`.
Copy link

sonarcloud bot commented Jan 17, 2024

@dianjuar
Copy link
Member Author

We will break down this PR into multiple PRs to the main branch to comply with the existing release and changelog generator procedures.

@dianjuar dianjuar closed this Jan 18, 2024
@dianjuar dianjuar deleted the v8 branch January 19, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant