Rewrite yaml loader #13803
Merged
Rewrite yaml loader #13803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old implementation would fail in weird ways with configs that were incorrect in just the right way. The new implementation just does what PyYAML would do, only diverging in case of duplicate keys.
✅ Deploy Preview for frigate-docs canceled.
|
NickM-27
requested changes
Sep 17, 2024
Co-authored-by: Nicolas Mowen <nickmowen213@gmail.com>
NickM-27
approved these changes
Sep 17, 2024
hawkeye217
approved these changes
Sep 17, 2024
hawkeye217
added a commit
that referenced
this pull request
Sep 17, 2024
This reverts commit 38ff46e.
NickM-27
pushed a commit
that referenced
this pull request
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Onward with trying to clean up the lifecycle of the python app; I encountered the hack in
load_config_with_no_duplicates().__pycache__to.gitignoreinstead of just the.pycfiles. No effect other than greying-out the__pycache__entries in vscode.