Do not use PyYAML in frigate app #13809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old implementation would fail in weird ways with configs that were incorrect in just the right way. The new implementation just does what PyYAML would do, only diverging in case of duplicate keys.
CodeQL complains when you use yaml.load() with custom loaders. This will at least get it to stfu whenever our custom loader is used.
✅ Deploy Preview for frigate-docs canceled.
|
|
Hold up, |
gtsiam
changed the title
|
Actually I'm gonna rework much of this in the next PR, so don't bother reviewing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we can do away with PyYAML entirely in frigate itself, so I'll just do that.
Original description:
This is almost the exact same pr as #13803, which was reverted in #13805.
The CodeQL security vulnerability is
bullshit (pardon my french)a false positive.Besides, I can literally execute arbitrary commands in the go2rtc config, what RCE? Security theatre intensifies.
Also, it's not new - You'll notice it flags it even in previous commits. I just happened to touch the relevant code which caused it to think it's "new".
Only change is that I moved the
yaml.load()calls to abuiltins.load_yaml()function to silence CodeQL when the custom loader is used in the future.