Revert "Rewrite yaml loader" #13805
Merged
Revert "Rewrite yaml loader" #13805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 38ff46e.
✅ Deploy Preview for frigate-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NickM-27
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
CC @gtsiam see https://github.com/blakeblackshear/frigate/runs/30282608426 for more details
You wot mate? Man, I love code scanners. Also this config can define arbitrary commands to execute. RCE from yaml deserialization is the list of our concerns.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #13803 for CodeQL issues.
https://github.com/blakeblackshear/frigate/security/code-scanning/56