Skip to content

fix : Custom providers with empty API keys show as configured in desktop#6105

Merged
alexhancock merged 1 commit intoblock:mainfrom
Abhijay007:fix/emptyAPI
Dec 16, 2025
Merged

fix : Custom providers with empty API keys show as configured in desktop#6105
alexhancock merged 1 commit intoblock:mainfrom
Abhijay007:fix/emptyAPI

Conversation

@Abhijay007
Copy link
Collaborator

@Abhijay007 Abhijay007 commented Dec 13, 2025

Closes: #6047

PR Description

This PR aims to resolve the issue with custom providers that were created via the CLI with an empty API key (valid for local or no-auth endpoints like Ollama) were incorrectly shown as not configured in the Desktop UI.

This was caused by check_provider_configured() validating that the API key was non-empty instead of checking whether it existed in the config.

Solution

Updated check_provider_configured() to treat a provider as configured if the API key exists in the config, even if it is empty.

File modified

  • crates/goose-server/src/routes/utils.rs

Type of Change

  • Bug fix

Testing

  • Tested in Desktop UI by creating a custom provider via CLI with an empty API key

Screenshots / Demos

Before:
image

After:
afterEmptyString

@Abhijay007
fix : Custom providers with empty API keys show as configured in desktop
41a6514 
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Copilot AI review requested due to automatic review settings December 13, 2025 15:37
Copilot AI reviewed Dec 13, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where custom providers created via CLI with empty API keys (valid for local/no-auth endpoints like Ollama) were incorrectly shown as "not configured" in the Desktop UI. The fix simplifies the check_provider_configured() function to check for the existence of an API key in the config, rather than requiring it to be non-empty.

Key changes:

  • Modified check_provider_configured() to use .is_ok() instead of .map(|s| !s.is_empty()).unwrap_or(false)
  • Removed outdated TODO comment about zero-config providers that this change addresses

DOsinga
DOsinga approved these changes Dec 14, 2025
View reviewed changes
crates/goose-server/src/routes/utils.rs
.get_secret::<String>(&loaded_provider.config.api_key_env)
.map(|s| !s.is_empty())
.unwrap_or(false);
.is_ok();
Copy link
Collaborator

@DOsinga DOsinga Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this lead to the situation where we think custom providers are configured that are not because they miss the API key?

Copy link
Collaborator Author

@Abhijay007 Abhijay007 Dec 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the desktop app, we have a checkbox to control this behavior, marking it as local mode.
For the CLI, it works the same as before, if the user explicitly adds it, we treat it as added; otherwise, it is passed through as-is. I don’t think there is any explicit API-level validation or check for this in the CLI.

image

@alexhancock alexhancock merged commit 9dc9f20 into block:main Dec 16, 2025
22 checks passed
@alexhancock alexhancock mentioned this pull request Dec 16, 2025
Closed
zanesq added a commit that referenced this pull request Dec 16, 2025
@zanesq
Merge branch 'main' of github.com:block/goose into zane/request-param…
d79adad 
…s-predefined-models

* 'main' of github.com:block/goose: (81 commits)
  fix: display shell output as static text instead of spinner (#6041)
  fix : Custom providers with empty API keys show as configured in desktop (#6105)
  Add .agents/skills and ~/.config/agent/skills to skills discovery paths (#6139)
  fix: use instructions for system prompt and prompt for user message in subagents (#6121)
  Fix compaction loop for small models or large input (#5803)
  feat: Centralize theme management with ThemeContext (#6137)
  OpenRouter & Xai streaming (#5873)
  fix: resolve mcp-hermit cleanup path expansion issue (#5953)
  feat: add goose PR reviewer workflow (#6124)
  perf: Avoid repeated MCP queries during streaming responses (#6138)
  Fix YAML serialization for recipes with special characters (#5796)
  Add more posthog analytics (privacy aware) (#6122)
  docs: add Sugar MCP server to extensions registry (#6077)
  Fix tokenState loading on new sessions (#6129)
  bump bedrock dep versions (#6090)
  Don't persist ephemeral extensions when resuming sessions (#5974)
  chore(deps): bump mdast-util-to-hast from 13.2.0 to 13.2.1 in /ui/desktop (#5939)
  chore(deps): bump node-forge from 1.3.1 to 1.3.2 in /documentation (#5898)
  Add Scorecard supply-chain security workflow (#5810)
  Don't show subagent tool when we're a subagent (#6125)
  ...

# Conflicts:
#	crates/goose/src/providers/formats/databricks.rs
aharvard added a commit that referenced this pull request Dec 17, 2025
@aharvard
Merge branch 'main' into feat/add-mcp-app-renderer
9b3ed0c 
* main:
  fix: we don't need to warn about tool count when in code mode (#6149)
  deps: upgrade agent-client-protocol to 0.9.0 (#6109)
  fix(providers): fix for gemini-cli on windows to work around cmd's multiline prompt limitations #5911 (#5966)
  More slash commands (#5858)
  fix: MCP UI not rendering due to CallToolResult structure change (#6143)
  fix: display shell output as static text instead of spinner (#6041)
  fix : Custom providers with empty API keys show as configured in desktop (#6105)
  Add .agents/skills and ~/.config/agent/skills to skills discovery paths (#6139)
  fix: use instructions for system prompt and prompt for user message in subagents (#6121)
  Fix compaction loop for small models or large input (#5803)
  feat: Centralize theme management with ThemeContext (#6137)
  OpenRouter & Xai streaming (#5873)
  fix: resolve mcp-hermit cleanup path expansion issue (#5953)
  feat: add goose PR reviewer workflow (#6124)
  perf: Avoid repeated MCP queries during streaming responses (#6138)
  Fix YAML serialization for recipes with special characters (#5796)
  Add more posthog analytics (privacy aware) (#6122)
  docs: add Sugar MCP server to extensions registry (#6077)
dianed-square added a commit that referenced this pull request Dec 17, 2025
@dianed-square
Merge remote-tracking branch 'origin/main' into docs/skills
1007fdd 
* origin/main: (57 commits)
  docs: create/edit recipe button (#6145)
  fix(google): Fix 400 Bad Request error with Gemini 3 thought signatures (#6035)
  fix: we don't need to warn about tool count when in code mode (#6149)
  deps: upgrade agent-client-protocol to 0.9.0 (#6109)
  fix(providers): fix for gemini-cli on windows to work around cmd's multiline prompt limitations #5911 (#5966)
  More slash commands (#5858)
  fix: MCP UI not rendering due to CallToolResult structure change (#6143)
  fix: display shell output as static text instead of spinner (#6041)
  fix : Custom providers with empty API keys show as configured in desktop (#6105)
  Add .agents/skills and ~/.config/agent/skills to skills discovery paths (#6139)
  fix: use instructions for system prompt and prompt for user message in subagents (#6121)
  Fix compaction loop for small models or large input (#5803)
  feat: Centralize theme management with ThemeContext (#6137)
  OpenRouter & Xai streaming (#5873)
  fix: resolve mcp-hermit cleanup path expansion issue (#5953)
  feat: add goose PR reviewer workflow (#6124)
  perf: Avoid repeated MCP queries during streaming responses (#6138)
  Fix YAML serialization for recipes with special characters (#5796)
  Add more posthog analytics (privacy aware) (#6122)
  docs: add Sugar MCP server to extensions registry (#6077)
  ...
katzdave added a commit that referenced this pull request Dec 17, 2025
@katzdave
Merge branch 'main' of github.com:block/goose into dkatz/canonical-pr…
70a9a1e 
…icing

* 'main' of github.com:block/goose: (35 commits)
  docs: skills (#6062)
  fix: add conditional configuration for GOOSE_BIN_DIR in PATH (#5940)
  Update dependencies to help in Fedora packaging (#5835)
  fix: make goose reviewer less bad (#6154)
  docs: create/edit recipe button (#6145)
  fix(google): Fix 400 Bad Request error with Gemini 3 thought signatures (#6035)
  fix: we don't need to warn about tool count when in code mode (#6149)
  deps: upgrade agent-client-protocol to 0.9.0 (#6109)
  fix(providers): fix for gemini-cli on windows to work around cmd's multiline prompt limitations #5911 (#5966)
  More slash commands (#5858)
  fix: MCP UI not rendering due to CallToolResult structure change (#6143)
  fix: display shell output as static text instead of spinner (#6041)
  fix : Custom providers with empty API keys show as configured in desktop (#6105)
  Add .agents/skills and ~/.config/agent/skills to skills discovery paths (#6139)
  fix: use instructions for system prompt and prompt for user message in subagents (#6121)
  Fix compaction loop for small models or large input (#5803)
  feat: Centralize theme management with ThemeContext (#6137)
  OpenRouter & Xai streaming (#5873)
  fix: resolve mcp-hermit cleanup path expansion issue (#5953)
  feat: add goose PR reviewer workflow (#6124)
  ...
@github-actions github-actions bot mentioned this pull request Dec 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@alexhancock alexhancock alexhancock approved these changes

@DOsinga DOsinga DOsinga approved these changes

@angiejones angiejones angiejones approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Desktop: Custom providers with empty API Key considered "not configured"

4 participants

@Abhijay007 @alexhancock @DOsinga @angiejones