deps: upgrade agent-client-protocol to 0.9.0#6109
deps: upgrade agent-client-protocol to 0.9.0#6109codefromthecrypt merged 1 commit intoblock:mainfrom
Conversation
|
@alexhancock I tried to match exactly what was before so that the diff is just about API updates. Lemme know if we need anything else on this. |
There was a problem hiding this comment.
Pull request overview
This PR upgrades the agent-client-protocol dependency from version 0.4.0 to 0.9.0 and updates all API usage throughout the codebase to align with the new library's builder pattern API. The upgrade introduces a cleaner, more idiomatic Rust API that uses builder patterns instead of direct struct construction with explicit field initialization.
- Updates
agent-client-protocolfrom 0.4.0 to 0.9.0 in Cargo.toml - Migrates all ACP API usage to new builder pattern style (
.new()methods with chained setters) - Fixes a minor syntax issue in computercontroller changing
unwrap_or_elsetounwrap_orfor efficiency
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/goose-cli/Cargo.toml | Bumps agent-client-protocol dependency version to 0.9.0 |
| Cargo.lock | Updates lockfile with new ACP version and transitive dependencies (agent-client-protocol-schema, derive_more, strum, etc.) |
| crates/goose-cli/src/commands/acp.rs | Converts all ACP struct instantiations to builder patterns, adds new imports (Content, ContentChunk, ExtResponse, ProtocolVersion), and adds wildcard match arm for forward compatibility |
| crates/goose-mcp/src/computercontroller/mod.rs | Changes unwrap_or_else to unwrap_or for more efficient constant fallback value |
6735052 to
59f59cf
Compare
59f59cf to
c4a12d6
Compare
|
@alexhancock fyi I'm gonna drop all your historical comments per instructions so we can move forward. |
Signed-off-by: Adrian Cole <adrian@tetrate.io>
c4a12d6 to
b7f9416
Compare
| embedded_context: true, // Goose can handle embedded context resources | ||
| meta: None, | ||
| }, | ||
| mcp_capabilities: acp::McpCapabilities { |
There was a problem hiding this comment.
fyi when removing the toehold which says to implement this, the result is a complete no-op, so I removed the McpCapabilities from this change.
|
@angiejones any idea how we can get a fast track process for dependency upgrades like this? I want to help with ACP but compared to most projects and despite a contributor, I have zero access, so I have to do a lot of nagging. It puts at risk of drift before merge then restart again. |
|
can you not merge this yourself, or how can we make the process better here? |
|
@DOsinga sorry part of my comment wasn't clear enough. I am labeled as a maintainer, but I don't think that actually means maintainer. I have no ability to merge this PR, no merge button. So far, I think that just "maintainer" means I can post to discord.
On process... Some...
Right now, I had to nag mic, then a couple other times. I have to meta track a dependency update with similar effort to an actual spec change. This is the part I think we can tune. |
|
ah, I think that was an oversight that we didn't actually make you maintainer, just recognized you as one. you should be now. agree on all the things you say - now that you have write access, let's make it so! sorry about that! |
|
Thanks for sorting this out @DOsinga. Glad I can help approve now also, or merge other people's low risk change. |
* main: fix: we don't need to warn about tool count when in code mode (#6149) deps: upgrade agent-client-protocol to 0.9.0 (#6109) fix(providers): fix for gemini-cli on windows to work around cmd's multiline prompt limitations #5911 (#5966) More slash commands (#5858) fix: MCP UI not rendering due to CallToolResult structure change (#6143) fix: display shell output as static text instead of spinner (#6041) fix : Custom providers with empty API keys show as configured in desktop (#6105) Add .agents/skills and ~/.config/agent/skills to skills discovery paths (#6139) fix: use instructions for system prompt and prompt for user message in subagents (#6121) Fix compaction loop for small models or large input (#5803) feat: Centralize theme management with ThemeContext (#6137) OpenRouter & Xai streaming (#5873) fix: resolve mcp-hermit cleanup path expansion issue (#5953) feat: add goose PR reviewer workflow (#6124) perf: Avoid repeated MCP queries during streaming responses (#6138) Fix YAML serialization for recipes with special characters (#5796) Add more posthog analytics (privacy aware) (#6122) docs: add Sugar MCP server to extensions registry (#6077)
* origin/main: (57 commits) docs: create/edit recipe button (#6145) fix(google): Fix 400 Bad Request error with Gemini 3 thought signatures (#6035) fix: we don't need to warn about tool count when in code mode (#6149) deps: upgrade agent-client-protocol to 0.9.0 (#6109) fix(providers): fix for gemini-cli on windows to work around cmd's multiline prompt limitations #5911 (#5966) More slash commands (#5858) fix: MCP UI not rendering due to CallToolResult structure change (#6143) fix: display shell output as static text instead of spinner (#6041) fix : Custom providers with empty API keys show as configured in desktop (#6105) Add .agents/skills and ~/.config/agent/skills to skills discovery paths (#6139) fix: use instructions for system prompt and prompt for user message in subagents (#6121) Fix compaction loop for small models or large input (#5803) feat: Centralize theme management with ThemeContext (#6137) OpenRouter & Xai streaming (#5873) fix: resolve mcp-hermit cleanup path expansion issue (#5953) feat: add goose PR reviewer workflow (#6124) perf: Avoid repeated MCP queries during streaming responses (#6138) Fix YAML serialization for recipes with special characters (#5796) Add more posthog analytics (privacy aware) (#6122) docs: add Sugar MCP server to extensions registry (#6077) ...
…icing * 'main' of github.com:block/goose: (35 commits) docs: skills (#6062) fix: add conditional configuration for GOOSE_BIN_DIR in PATH (#5940) Update dependencies to help in Fedora packaging (#5835) fix: make goose reviewer less bad (#6154) docs: create/edit recipe button (#6145) fix(google): Fix 400 Bad Request error with Gemini 3 thought signatures (#6035) fix: we don't need to warn about tool count when in code mode (#6149) deps: upgrade agent-client-protocol to 0.9.0 (#6109) fix(providers): fix for gemini-cli on windows to work around cmd's multiline prompt limitations #5911 (#5966) More slash commands (#5858) fix: MCP UI not rendering due to CallToolResult structure change (#6143) fix: display shell output as static text instead of spinner (#6041) fix : Custom providers with empty API keys show as configured in desktop (#6105) Add .agents/skills and ~/.config/agent/skills to skills discovery paths (#6139) fix: use instructions for system prompt and prompt for user message in subagents (#6121) Fix compaction loop for small models or large input (#5803) feat: Centralize theme management with ThemeContext (#6137) OpenRouter & Xai streaming (#5873) fix: resolve mcp-hermit cleanup path expansion issue (#5953) feat: add goose PR reviewer workflow (#6124) ...
* 'main' of github.com:block/goose: (28 commits) Clean PR preview sites from gh-pages branch history (#6161) fix: make goose reviewer less sycophantic (#6171) revert /reply to previous behavior (replacing session history) when full conversation provided (#6058) chore: manually update version (#6166) Integrate pricing with canonical model (#6130) Regenerate canonical models when release branch is created. (#6127) fix: use correct parameter name in read_module handler (#6148) docs: blog for code mode MCP (#6126) test: add ACP integration test (#6150) docs: auto download updates (#6163) fix: respect default_enabled value of platform extensions (#6159) docs: skills (#6062) fix: add conditional configuration for GOOSE_BIN_DIR in PATH (#5940) Update dependencies to help in Fedora packaging (#5835) fix: make goose reviewer less bad (#6154) docs: create/edit recipe button (#6145) fix(google): Fix 400 Bad Request error with Gemini 3 thought signatures (#6035) fix: we don't need to warn about tool count when in code mode (#6149) deps: upgrade agent-client-protocol to 0.9.0 (#6109) fix(providers): fix for gemini-cli on windows to work around cmd's multiline prompt limitations #5911 (#5966) ... # Conflicts: # ui/desktop/src/api/sdk.gen.ts # ui/desktop/src/hooks/useAgent.ts

Summary
Updates the ACP to latest and fixes syntax
Type of Change
AI Assistance
Testing
Ran in Zed

$ cat ~/Library/Logs/Zed/Zed.log --snip-- 2025-12-14T09:10:11+08:00 WARN [agent_servers::acp] agent stderr: Goose ACP agent started. Listening on stdio... 2025-12-14T09:10:15+08:00 WARN [agent_servers::acp] agent stderr: Goose ACP agent started. Listening on stdio...Related Issues
Prep before doing more ACP work