Skip to content

fix: respect default_enabled value of platform extensions#6159

Merged
alexhancock merged 1 commit intomainfrom
alexhancock/respect-default-enabled
Dec 17, 2025
Merged

fix: respect default_enabled value of platform extensions#6159
alexhancock merged 1 commit intomainfrom
alexhancock/respect-default-enabled

Conversation

@alexhancock
Copy link
Collaborator

Right now when adding new platform extensions to the config we do not honor the default_enabled value they have configured and just always turn them on. This makes it respect that config value.

I noticed this because code_execution was being turned on when added and I didn't expect that

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where platform extensions were always being enabled when added to the config, ignoring their default_enabled configuration value. The fix ensures that extensions like code_execution (which has default_enabled: false) are not automatically enabled when added to the config.

  • Changed the hardcoded enabled: true to respect def.default_enabled when auto-populating platform extensions

@alexhancock alexhancock merged commit 61c86a7 into main Dec 17, 2025
23 checks passed
@alexhancock alexhancock deleted the alexhancock/respect-default-enabled branch December 17, 2025 21:39
zanesq added a commit that referenced this pull request Dec 18, 2025
* 'main' of github.com:block/goose: (28 commits)
  Clean PR preview sites from gh-pages branch history (#6161)
  fix: make goose reviewer less sycophantic (#6171)
  revert /reply to previous behavior (replacing session history) when full conversation provided (#6058)
  chore: manually update version (#6166)
  Integrate pricing with canonical model (#6130)
  Regenerate canonical models when release branch is created. (#6127)
  fix: use correct parameter name in read_module handler (#6148)
  docs: blog for code mode MCP (#6126)
  test: add ACP integration test (#6150)
  docs: auto download updates (#6163)
  fix: respect default_enabled value of platform extensions (#6159)
  docs: skills (#6062)
  fix: add conditional configuration for GOOSE_BIN_DIR in PATH (#5940)
  Update dependencies to help in Fedora packaging (#5835)
  fix: make goose reviewer less bad (#6154)
  docs: create/edit recipe button (#6145)
  fix(google): Fix 400 Bad Request error with Gemini 3 thought signatures (#6035)
  fix: we don't need to warn about tool count when in code mode (#6149)
  deps: upgrade agent-client-protocol to 0.9.0 (#6109)
  fix(providers): fix for gemini-cli on windows to work around cmd's multiline prompt limitations #5911 (#5966)
  ...

# Conflicts:
#	ui/desktop/src/api/sdk.gen.ts
#	ui/desktop/src/hooks/useAgent.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants