fix: add conditional configuration for GOOSE_BIN_DIR in PATH#5940
Merged
jamadeo merged 1 commit intoblock:mainfrom Dec 17, 2025
Merged
fix: add conditional configuration for GOOSE_BIN_DIR in PATH#5940jamadeo merged 1 commit intoblock:mainfrom
jamadeo merged 1 commit intoblock:mainfrom
Conversation
Signed-off-by: Allen <s96016641@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the download_cli.sh script by adding conditional handling for the CONFIGURE environment variable when prompting users to add GOOSE_BIN_DIR to their PATH. This aligns the PATH configuration behavior with the existing goose configure step (line 290), allowing non-interactive installations to skip prompts entirely.
- Wraps the interactive PATH configuration prompt in a
CONFIGUREcheck - Displays a simple message when configuration is disabled, prompting manual PATH setup
| esac | ||
| else | ||
| echo "" | ||
| echo "Configure disabled. Please add \$GOOSE_BIN_DIR to your PATH manually." |
There was a problem hiding this comment.
When CONFIGURE is disabled, users don't receive instructions on how to manually add GOOSE_BIN_DIR to their PATH. Consider showing the same instructions as choice "2" (lines 341-344) so users know the exact command to run.
Suggested change
| echo "Configure disabled. Please add \$GOOSE_BIN_DIR to your PATH manually." | |
| echo "Configure disabled. Please add \$GOOSE_BIN_DIR to your PATH manually." | |
| echo "" | |
| echo "Add it to your PATH by editing ~/.${SHELL_NAME}rc or similar:" | |
| echo " export PATH=\"\$GOOSE_BIN_DIR:\$PATH\"" | |
| echo "Then reload your shell (e.g. 'source ~/.${SHELL_NAME}rc') to apply changes." |
jamadeo
approved these changes
Dec 17, 2025
katzdave
added a commit
that referenced
this pull request
Dec 17, 2025
…icing * 'main' of github.com:block/goose: (35 commits) docs: skills (#6062) fix: add conditional configuration for GOOSE_BIN_DIR in PATH (#5940) Update dependencies to help in Fedora packaging (#5835) fix: make goose reviewer less bad (#6154) docs: create/edit recipe button (#6145) fix(google): Fix 400 Bad Request error with Gemini 3 thought signatures (#6035) fix: we don't need to warn about tool count when in code mode (#6149) deps: upgrade agent-client-protocol to 0.9.0 (#6109) fix(providers): fix for gemini-cli on windows to work around cmd's multiline prompt limitations #5911 (#5966) More slash commands (#5858) fix: MCP UI not rendering due to CallToolResult structure change (#6143) fix: display shell output as static text instead of spinner (#6041) fix : Custom providers with empty API keys show as configured in desktop (#6105) Add .agents/skills and ~/.config/agent/skills to skills discovery paths (#6139) fix: use instructions for system prompt and prompt for user message in subagents (#6121) Fix compaction loop for small models or large input (#5803) feat: Centralize theme management with ThemeContext (#6137) OpenRouter & Xai streaming (#5873) fix: resolve mcp-hermit cleanup path expansion issue (#5953) feat: add goose PR reviewer workflow (#6124) ...
zanesq
added a commit
that referenced
this pull request
Dec 18, 2025
* 'main' of github.com:block/goose: (28 commits) Clean PR preview sites from gh-pages branch history (#6161) fix: make goose reviewer less sycophantic (#6171) revert /reply to previous behavior (replacing session history) when full conversation provided (#6058) chore: manually update version (#6166) Integrate pricing with canonical model (#6130) Regenerate canonical models when release branch is created. (#6127) fix: use correct parameter name in read_module handler (#6148) docs: blog for code mode MCP (#6126) test: add ACP integration test (#6150) docs: auto download updates (#6163) fix: respect default_enabled value of platform extensions (#6159) docs: skills (#6062) fix: add conditional configuration for GOOSE_BIN_DIR in PATH (#5940) Update dependencies to help in Fedora packaging (#5835) fix: make goose reviewer less bad (#6154) docs: create/edit recipe button (#6145) fix(google): Fix 400 Bad Request error with Gemini 3 thought signatures (#6035) fix: we don't need to warn about tool count when in code mode (#6149) deps: upgrade agent-client-protocol to 0.9.0 (#6109) fix(providers): fix for gemini-cli on windows to work around cmd's multiline prompt limitations #5911 (#5966) ... # Conflicts: # ui/desktop/src/api/sdk.gen.ts # ui/desktop/src/hooks/useAgent.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces a conditional check to the
download_cli.shscript, improving how the script handles addingGOOSE_BIN_DIRto the user'sPATH. The main change is that the script now respects aCONFIGUREflag, which allows users to skip interactive configuration and receive manual instructions instead.Enhancements to PATH configuration logic:
CONFIGUREenvironment variable to determine whether to prompt the user interactively or simply show manual instructions for addingGOOSE_BIN_DIRto thePATH.CONFIGUREis not enabled, the script now displays a message indicating that configuration is disabled and instructs the user to addGOOSE_BIN_DIRmanually.Type of Change
AI Assistance