revert /reply to old behavior when full conversation provided#6058
revert /reply to old behavior when full conversation provided#6058tlongwell-block merged 3 commits intomainfrom
Conversation
4a99bd3 to
6aafb17
Compare
DOsinga
left a comment
There was a problem hiding this comment.
I think we do need to keep the full conversation in the loop
| }; | ||
|
|
||
| let mut all_messages = messages.clone(); | ||
| let mut all_messages = Conversation::new_unvalidated(vec![user_message.clone()]); |
There was a problem hiding this comment.
this doesn't strike me as quite right; we keep a shadow administration of the messages here I think just for tracking purposes. we should probably move that to agent, but until we do, we should in the block above retrieve the conversation so far from the db if it is not given and then call the agent only with the user message
|
/goose |
|
Summary: This PR restores the ability for external integrations (like the Slack bot) to provide their own conversation history when calling 🟡 Warnings
✅ Highlights
Review generated by goose |
* 'main' of github.com:block/goose: (28 commits) Clean PR preview sites from gh-pages branch history (#6161) fix: make goose reviewer less sycophantic (#6171) revert /reply to previous behavior (replacing session history) when full conversation provided (#6058) chore: manually update version (#6166) Integrate pricing with canonical model (#6130) Regenerate canonical models when release branch is created. (#6127) fix: use correct parameter name in read_module handler (#6148) docs: blog for code mode MCP (#6126) test: add ACP integration test (#6150) docs: auto download updates (#6163) fix: respect default_enabled value of platform extensions (#6159) docs: skills (#6062) fix: add conditional configuration for GOOSE_BIN_DIR in PATH (#5940) Update dependencies to help in Fedora packaging (#5835) fix: make goose reviewer less bad (#6154) docs: create/edit recipe button (#6145) fix(google): Fix 400 Bad Request error with Gemini 3 thought signatures (#6035) fix: we don't need to warn about tool count when in code mode (#6149) deps: upgrade agent-client-protocol to 0.9.0 (#6109) fix(providers): fix for gemini-cli on windows to work around cmd's multiline prompt limitations #5911 (#5966) ... # Conflicts: # ui/desktop/src/api/sdk.gen.ts # ui/desktop/src/hooks/useAgent.ts
…ull conversation provided (#6058)
…ull conversation provided (block#6058) Signed-off-by: Brandon Kvarda <brandon.kvarda@databricks.com>
Allow passing full conversation to /reply if needed. This supports the previous behavior of the /reply endpoint before the session required overhaul as part of the agent manager work. This is required for some uses of goose-server where session contents may have more than one source of truth, like the goose slackbot.