Fallback to latest version during failed install#6859
Fallback to latest version during failed install#6859IAmMarcellus wants to merge 3 commits intoblock:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6334949660
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
IAmMarcellus
changed the title
download_cli.sh
Outdated
| echo "Error: Failed to download $DOWNLOAD_URL" | ||
| exit 1 | ||
| fi | ||
| else | ||
| echo "Error: Failed to download $DOWNLOAD_URL" |
There was a problem hiding this comment.
❓ Are these two error messages the same because the problem is the same?
If not, is that possible to make them different, so that a user could understand the problem more precise?
katzdave
left a comment
katzdave
left a comment
There was a problem hiding this comment.
Looks good @IAmMarcellus Can you complete the DCO check?
|
ported this over so we can merge without the DCO - thanks @IAmMarcellus for taking care of this |
4 participants
Summary
Fix for #6858
Installs fail because sometime
goose-x86_64-unknown-linux-gnu.tar.bz2doesn't exist atgithub.com/block/goose/releases/download/stablebut it exists at/goose/releases/download/<version_number>.Now, if the download fails and a GOOSE_VERSION isn't specified, it will get the latest version from github and retry with that version explicitly. This avoids a failure when the
stabletag is missing its download files.Type of Change
AI Assistance
Testing
Script is working locally for me and there isn't a download file on the stable tag right now.
Related Issues
Relates to #6858