Skip to content

fix: ignore deprecated skills extension#7139

Merged
DOsinga merged 5 commits intoblock:mainfrom
fresh3nough:fix/ignore-deprecated-skills-extension
Feb 13, 2026
Merged

fix: ignore deprecated skills extension#7139
DOsinga merged 5 commits intoblock:mainfrom
fresh3nough:fix/ignore-deprecated-skills-extension

Conversation

@fresh3nough
Copy link
Contributor

@fresh3nough fresh3nough commented Feb 11, 2026 •
edited
Loading

Summary

  • skip platform extensions not present in PLATFORM_EXTENSIONS when reading config or session state
  • remove deprecated skills filtering and migration cleanup in favor of centralized availability checks
  • add tests for unavailable platform extension filtering

Reproduction

  1. Add a platform extension entry with a name not in PLATFORM_EXTENSIONS to config.yaml
  2. Start a session (./target/debug/goose session)
  3. Observe the extension is skipped and not loaded

Testing

  • cargo test -p goose filters_unavailable_platform

Fixes #7134

@fresh3nough @warp-agent
fix: ignore deprecated skills extension
e96a5d6 
Signed-off-by: anonwurcod <anonwurcod@proton.me>
Co-Authored-By: Warp <agent@warp.dev>
@fresh3nough fresh3nough mentioned this pull request Feb 11, 2026
Closed
DOsinga
DOsinga reviewed Feb 12, 2026
View reviewed changes
crates/goose-cli/src/session/builder.rs Outdated
} else {
resolve_extensions_for_new_session(recipe.and_then(|r| r.extensions.as_deref()), None)
};
configured_extensions.retain(|config| !is_deprecated_platform_extension(config));
Copy link
Collaborator

@DOsinga DOsinga Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we be doing this at a higher level? this fixes it for the cli, but how does this work for the desktop?

I think in general we should just ignore trying to load platform extensions that don't exist. we offer a let goose help you fix this for you, but for platform extensions and built-in extensions there is just nothing you can do

Copy link
Contributor Author

@fresh3nough fresh3nough Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DOsinga

question 1: what is currently implemented makes it CLI-specific for new or resumed sessions. If the desktop app has a parallel session builder it wouldn't directly benefit from this filter—though the migration should still mitigate the issue by cleaning the config upfront

question 2: Regarding a higher-level approach: agreed, This could be handled in the shared extension resolver/loader (e.g., in crates/goose/src/agents/extension.rs or wherever PLATFORM_EXTENSIONS is checked during startup). That would uniformly cover CLI, desktop, and any future interfaces

i can put in a quick fix for #2 if you wish

Copy link
Collaborator

@DOsinga DOsinga Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think all we should do is just #2 - don't load platform extensions that are not present in the system. this doesn't seem like a good candidate for migrations. maybe I am just temporarily on a new version. if you wanted to do a migration it should also be done in or using the extensions.rs - you are now duplicating get_extensions_map_with_config. you could apply your filtere there. but like I said, my preference would be to skip any platform extension that cannot be loaded in extension manager.

Copy link
Contributor Author

@fresh3nough fresh3nough Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DOsinga my commits touch .github/workflows/canary.yml which triggers an auth error when i try to push the changes required to fix the merge conflicts, how to resolve?

fresh3nough and others added 2 commits February 13, 2026 12:11
@fresh3nough @warp-agent
filter unavailable platform extensions
fb70239 
Co-Authored-By: Warp <agent@warp.dev>
Signed-off-by: anonwurcod <anonwurcod@proton.me>
@fresh3nough @warp-agent
merge upstream/main
a266965 
Co-Authored-By: Warp <agent@warp.dev>
Signed-off-by: anonwurcod <anonwurcod@proton.me>
@DOsinga
Copy link
Collaborator

DOsinga commented Feb 13, 2026

@DOsinga my commits touch .github/workflows/canary.yml which triggers an auth error when i try to push the changes required to fix the merge conflicts, how to resolve?

not sure I follow, how does it touch the canary.yml? if you somehow get into trouble, I can always branch of this and get it landed for you

@fresh3nough @warp-agent
fix merge markers in extension state
8aacf0b 
Co-Authored-By: Warp <agent@warp.dev>
Signed-off-by: anonwurcod <anonwurcod@proton.me>
@fresh3nough
Copy link
Contributor Author

fresh3nough commented Feb 13, 2026

@DOsinga should be good now if you wish to review

DOsinga
DOsinga approved these changes Feb 13, 2026
View reviewed changes
Copy link
Collaborator

@DOsinga DOsinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think builder.rs & migrations.rs have no empty diffs and git is not happy about it?

@fresh3nough @warp-agent
format after merge
40be881 
Co-Authored-By: Warp <agent@warp.dev>
Signed-off-by: anonwurcod <anonwurcod@proton.me>
@DOsinga
Copy link
Collaborator

DOsinga commented Feb 13, 2026

thanks for the quick turnaround!

@DOsinga DOsinga added this pull request to the merge queue Feb 13, 2026
@fresh3nough
Copy link
Contributor Author

fresh3nough commented Feb 13, 2026

np!

Merged via the queue into block:main with commit 58d3431 Feb 13, 2026
20 checks passed
katzdave added a commit that referenced this pull request Feb 13, 2026
@katzdave
Merge branch 'main' of github.com:block/goose into dkatz/canonical-co…
0689d04 
…ntext

* 'main' of github.com:block/goose:
  Move platform extensions into their own folder (#7210)
  fix: ignore deprecated skills extension (#7139)
  Add a goosed over HTTP integration test, and test the developer tool PATH (#7178)
michaelneale added a commit that referenced this pull request Feb 16, 2026
@michaelneale
Merge remote-tracking branch 'origin/main' into gateway-abstraction
661def6 
* origin/main: (42 commits)
  fix: use dynamic port for Tetrate auth callback server (#7228)
  docs: removing LLM Usage admonitions (#7227)
  feat(otel): respect standard OTel env vars for exporter selection (#7144)
  fix: fork session (#7219)
  Bump version numbers for 1.24.0 release (#7214)
  Move platform extensions into their own folder (#7210)
  fix: ignore deprecated skills extension (#7139)
  Add a goosed over HTTP integration test, and test the developer tool PATH (#7178)
  feat: add onFallbackRequest handler to McpAppRenderer (#7208)
  feat: add streaming support for Claude Code CLI provider (#6833)
  fix: The detected filetype is PLAIN_TEXT, but the provided filetype was HTML (#6885)
  Add prompts (#7212)
  Add testing instructions for speech to text (#7185)
  Diagnostic files copying (#7209)
  fix: allow concurrent tool execution within the same MCP extension (#7202)
  fix: handle missing arguments in MCP tool calls to prevent GUI crash (#7143)
  Filter Apps page to only show standalone Goose Apps (#6811)
  opt: use static for Regex (#7205)
  nit: show dir in title, and less... jank (#7138)
  feat(gemini-cli): use stream-json output and re-use session (#7118)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DOsinga DOsinga DOsinga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Skills extension failure should be ignored

2 participants

@fresh3nough @DOsinga