Move platform extensions into their own folder#7210
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears intended to refactor “platform extensions” by moving their implementation into a dedicated agents::platform_extensions module and updating imports/call sites accordingly.
Changes:
- Updates several call sites (tests, permission code, agent logic) to import extension/tool constants from
agents::platform_extensions. - Updates
agents::mod.rsandagents::extension.rsto reference/re-export the newplatform_extensionsmodule. - Removes the previous in-module platform extension implementations (
apps_extension,chatrecall_extension,code_execution_extension,extension_manager_extension,summon_extension,todo_extension,tom_extension).
Reviewed changes
Copilot reviewed 10 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/goose/tests/agent.rs | Updates test imports to the new agents::platform_extensions path. |
| crates/goose/src/permission/permission_judge.rs | Redirects extension-manager tool constant import to agents::platform_extensions. |
| crates/goose/src/permission/permission_inspector.rs | Redirects extension-manager tool constant import to agents::platform_extensions. |
| crates/goose/src/agents/reply_parts.rs | Redirects code-execution extension name import to agents::platform_extensions. |
| crates/goose/src/agents/mod.rs | Removes old extension modules and declares pub mod platform_extensions;. |
| crates/goose/src/agents/extension.rs | Re-exports platform extension definitions from agents::platform_extensions. |
| crates/goose/src/agents/agent.rs | Redirects MANAGE_EXTENSIONS_TOOL_NAME_COMPLETE import to agents::platform_extensions. |
| crates/goose/src/agents/apps_extension.rs | Deleted (expected to be moved under platform extensions). |
| crates/goose/src/agents/chatrecall_extension.rs | Deleted (expected to be moved under platform extensions). |
| crates/goose/src/agents/code_execution_extension.rs | Deleted (expected to be moved under platform extensions). |
| crates/goose/src/agents/extension_manager_extension.rs | Deleted (expected to be moved under platform extensions). |
| crates/goose/src/agents/summon_extension.rs | Deleted (expected to be moved under platform extensions). |
| crates/goose/src/agents/todo_extension.rs | Deleted (expected to be moved under platform extensions). |
| crates/goose/src/agents/tom_extension.rs | Deleted (expected to be moved under platform extensions). |
added 2 commits
February 13, 2026 15:25
jamadeo
approved these changes
Feb 13, 2026
michaelneale
added a commit
that referenced
this pull request
Feb 16, 2026
* origin/main: (42 commits) fix: use dynamic port for Tetrate auth callback server (#7228) docs: removing LLM Usage admonitions (#7227) feat(otel): respect standard OTel env vars for exporter selection (#7144) fix: fork session (#7219) Bump version numbers for 1.24.0 release (#7214) Move platform extensions into their own folder (#7210) fix: ignore deprecated skills extension (#7139) Add a goosed over HTTP integration test, and test the developer tool PATH (#7178) feat: add onFallbackRequest handler to McpAppRenderer (#7208) feat: add streaming support for Claude Code CLI provider (#6833) fix: The detected filetype is PLAIN_TEXT, but the provided filetype was HTML (#6885) Add prompts (#7212) Add testing instructions for speech to text (#7185) Diagnostic files copying (#7209) fix: allow concurrent tool execution within the same MCP extension (#7202) fix: handle missing arguments in MCP tool calls to prevent GUI crash (#7143) Filter Apps page to only show standalone Goose Apps (#6811) opt: use static for Regex (#7205) nit: show dir in title, and less... jank (#7138) feat(gemini-cli): use stream-json output and re-use session (#7118) ...
tlongwell-block
added a commit
that referenced
this pull request
Feb 17, 2026
* origin/main: docs: playwright CLI skill tutorial (#7261) install node in goose dir (#7220) fix: relax test_basic_response assertion for providers returning reasoning_content (#7249) fix: handle reasoning_content for Kimi/thinking models (#7252) feat: sandboxing for macos (#7197) fix(otel): use monotonic_counter prefix and support temporality env var (#7234) Streaming markdown (#7233) Improve compaction messages to enable better post-compaction agent behavior (#7259) fix: avoid shell-escaping special characters except quotes (#7242) fix: use dynamic port for Tetrate auth callback server (#7228) docs: removing LLM Usage admonitions (#7227) feat(otel): respect standard OTel env vars for exporter selection (#7144) fix: fork session (#7219) Bump version numbers for 1.24.0 release (#7214) Move platform extensions into their own folder (#7210) fix: ignore deprecated skills extension (#7139) # Conflicts: # Cargo.lock # Cargo.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor for the sake of it, because sometimes you have to