Add a goosed over HTTP integration test, and test the developer tool PATH by jamadeo · Pull Request #7178 · block/goose

jamadeo · 2026-02-12T14:56:57Z

A test that starts goosed an issues HTTP requests to it using the generated typescript SDK

The prompt was

I want to set up a new test suite. It will test the 'goosed' binary in the rust project, but it will do so via the client API in ui/desktop. Can you set this up for me? I'd imagine it would be a new run target in package.json, and I'll write tests in typescript that issue requets directly to a running goosed process

jamadeo · 2026-02-12T15:00:19Z

ui/desktop/tests/integration/README.md

+
+  // ... tests
+});
+```


there's a bunch of unnecessary content in the README, I'll clean that up

Copilot

Pull request overview

This PR scaffolds integration tests for the goosed binary, enabling HTTP requests via the auto-generated TypeScript API client. The test suite spawns a real goosed process, waits for it to be ready, and issues requests to verify the server works correctly end-to-end.

Changes:

Created a new Vitest integration config for tests that spawn real processes
Implemented test setup utilities for spawning and managing goosed processes
Added initial integration tests covering status, configuration, and provider endpoints
Added comprehensive README documentation for writing integration tests
Added npm scripts for running integration tests

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
ui/desktop/vitest.integration.config.ts	Separate Vitest config for integration tests using Node environment with 30s timeouts
ui/desktop/tests/integration/setup.ts	Test utilities for spawning goosed, managing process lifecycle, and creating authenticated API clients
ui/desktop/tests/integration/goosed.test.ts	Initial integration tests covering status, config, and provider endpoints
ui/desktop/tests/integration/README.md	Documentation for writing integration tests, including setup instructions and examples
ui/desktop/package.json	Added npm scripts for running integration tests in different modes

ui/desktop/tests/integration/setup.ts

ui/desktop/tests/integration/README.md

DOsinga

great. I think we can delete the README since it is more about the goose plan and then setup.ts could use more of main.ts, but other than that, this is very good

DOsinga · 2026-02-12T15:01:15Z

ui/desktop/tests/integration/setup.ts

@@ -0,0 +1,178 @@
+/**


this could re-use a lot from main (and by way of that, also test it), like starting goosed etc

goose made a little bit of a mess of this on first try, but I think it's in a good place now. Now the only bits specific to the test setup are the temp root and config creation, everything else is used from goosed.ts

DOsinga · 2026-02-12T15:01:48Z

ui/desktop/tests/integration/setup.ts

+let portCounter = 13100;
+
+function getNextPort(): number {
+  return portCounter++;


in main I think we actually find a free port?

…on-tests

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 8 comments.

Comments suppressed due to low confidence (1)

ui/desktop/src/utils/tests/parameterSubstitution.test.ts:5

The outer describe('providerUtils', ...) no longer matches the module under test (now parameterSubtitution/substituteParameters); updating the describe label will make failures easier to interpret.

ui/desktop/tests/integration/goosed.test.ts

Copilot · 2026-02-12T16:53:05Z

ui/desktop/tests/integration/setup.ts

+  const possiblePaths = [
+    path.join(process.cwd(), 'src', 'bin', 'goosed'),
+    path.join(process.cwd(), 'bin', 'goosed'),
+    path.join(process.cwd(), '..', '..', 'target', 'debug', 'goosed'),
+    path.join(process.cwd(), '..', '..', 'target', 'release', 'goosed'),
+  ];


findGoosedBinary() only checks for goosed (no extension), so it will fail on Windows where the binary is typically goosed.exe; consider appending .exe when process.platform === 'win32' (or checking both variants for each candidate path).

ui/desktop/src/components/OllamaSetup.test.tsx

ui/desktop/tests/integration/goosed.test.ts

Copilot · 2026-02-12T16:53:06Z

ui/desktop/tests/integration/setup.ts

+      goosedProcess.kill('SIGTERM');
+
+      // Force kill after timeout
+      setTimeout(() => {
+        if (!goosedProcess.killed) {
+          goosedProcess.kill('SIGKILL');
+        }


goosedProcess.kill('SIGTERM')/SIGKILL are not supported consistently on Windows and can cause cleanup to hang; consider using a platform-specific termination strategy (e.g., kill() without a signal on Windows, or taskkill) similar to ui/desktop/src/goosed.ts.

ui/desktop/src/utils/parameterSubstitution.ts

ui/desktop/vitest.integration.config.ts

ui/desktop/tests/integration/goosed.test.ts

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

ui/desktop/tests/integration/goosed.test.ts

ui/desktop/src/components/OllamaSetup.test.tsx

.github/workflows/pr-smoke-test.yml

ui/desktop/src/goosed.ts

-  PATH: string;
-  GOOSE_PORT: string;
-  GOOSE_SERVER__SECRET_KEY?: string;
+// Configuration for external goosed server


Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.

Copilot · 2026-02-12T19:32:08Z

ui/desktop/tests/integration/setup.ts

+  const goosedProcess = spawn(goosedPath, ['agent'], {
+    env: { ...process.env, ...env },
+    stdio: ['pipe', 'pipe', 'pipe'],
+  });


spawn(goosedPath, ...) will crash if goosedPath is null; handle the not-found case explicitly (e.g., throw with a helpful message listing searched paths / the override env var).

ui/desktop/tests/integration/setup.ts

ui/desktop/src/goosed.ts

Copilot · 2026-02-12T19:32:09Z

ui/desktop/src/goosed.ts

-  if (isWindows && goosedProcess.unref) {
-    goosedProcess.unref();
-  }
+  const goosedProcess = spawn(goosedPath, [], spawnOptions);


goosed requires the agent subcommand (see crates/goose-server/src/main.rs), but this spawns it with no args, so it will exit immediately with a usage error; pass ['agent'] here to actually start the HTTP server.

Suggested change

const goosedProcess = spawn(goosedPath, [], spawnOptions);

const goosedProcess = spawn(goosedPath, ['agent'], spawnOptions);

Copilot · 2026-02-12T19:32:10Z

ui/desktop/src/goosed-app.ts

+    }
+
+    try {
+      await status({ client });


status({ client }) won’t throw on non-2xx responses unless throwOnError: true is set, so this can report the server as “ready” even if /status is returning an error payload; pass throwOnError: true (or explicitly check response.ok) inside the polling loop.

Suggested change

await status({ client });

await status({ client, throwOnError: true });

ui/desktop/tests/integration/setup.ts

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

crates/goose-server/src/state.rs

This reverts commit 80fdc0d.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

ui/desktop/tests/integration/setup.ts

ui/desktop/vitest.integration.config.ts

ui/desktop/tests/integration/setup.ts

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 7 comments.

ui/desktop/src/goosed.ts

ui/desktop/tests/integration/goosed.test.ts

ui/desktop/tests/integration/setup.ts

ui/desktop/src/goosed.ts

Copilot · 2026-02-13T17:00:29Z

ui/desktop/src/main.ts

+  app.on('will-quit', async () => {
+    log.info('App quitting, terminating goosed server');
+    await goosedResult.cleanup();
+  });


The app.on('will-quit') handler is registered inside createChat, which can be called multiple times (once per window). This will register multiple cleanup handlers that all try to kill the same goosed process. Consider tracking goosed processes globally and cleaning them up once, or deregistering old handlers when new ones are added.

Copilot · 2026-02-13T17:00:29Z

ui/desktop/tests/integration/setup.ts

+  const serverReady = await checkServerStatus(client, errorLog);
+  if (!serverReady) {
+    baseCleanup();
+    console.error('Server stderr:', errorLog.join('\n'));
+    throw new Error('Failed to start goosed');
+  }


If checkServerStatus fails at line 97, baseCleanup is called at line 99 but tempDir is not removed. This leaves temporary directories behind on test failures. Consider wrapping the cleanup in a try-finally or calling the full cleanup function instead of just baseCleanup.

…ntext * 'main' of github.com:block/goose: Move platform extensions into their own folder (#7210) fix: ignore deprecated skills extension (#7139) Add a goosed over HTTP integration test, and test the developer tool PATH (#7178)

* origin/main: (42 commits) fix: use dynamic port for Tetrate auth callback server (#7228) docs: removing LLM Usage admonitions (#7227) feat(otel): respect standard OTel env vars for exporter selection (#7144) fix: fork session (#7219) Bump version numbers for 1.24.0 release (#7214) Move platform extensions into their own folder (#7210) fix: ignore deprecated skills extension (#7139) Add a goosed over HTTP integration test, and test the developer tool PATH (#7178) feat: add onFallbackRequest handler to McpAppRenderer (#7208) feat: add streaming support for Claude Code CLI provider (#6833) fix: The detected filetype is PLAIN_TEXT, but the provided filetype was HTML (#6885) Add prompts (#7212) Add testing instructions for speech to text (#7185) Diagnostic files copying (#7209) fix: allow concurrent tool execution within the same MCP extension (#7202) fix: handle missing arguments in MCP tool calls to prevent GUI crash (#7143) Filter Apps page to only show standalone Goose Apps (#6811) opt: use static for Regex (#7205) nit: show dir in title, and less... jank (#7138) feat(gemini-cli): use stream-json output and re-use session (#7118) ...

Scaffold a goosed integration test

6050d39

Copilot AI review requested due to automatic review settings February 12, 2026 14:56

Copilot started reviewing on behalf of jamadeo February 12, 2026 14:57 View session

jamadeo commented Feb 12, 2026

View reviewed changes

Copilot AI reviewed Feb 12, 2026

View reviewed changes

ui/desktop/tests/integration/setup.ts Outdated Show resolved Hide resolved

ui/desktop/tests/integration/README.md Outdated Show resolved Hide resolved

ui/desktop/tests/integration/README.md Outdated Show resolved Hide resolved

clean up readme

50bced7

DOsinga approved these changes Feb 12, 2026

View reviewed changes

jamadeo added 5 commits February 12, 2026 10:15

reply tests

4463f17

Nearly there

90f8440

Add a test for developer $PATH

4cd2b40

Merge remote-tracking branch 'origin/main' into goosed-http-integrati…

d4b1980

…on-tests

Read it straight from the $SHELL

a1d049e

Copilot AI review requested due to automatic review settings February 12, 2026 16:48

Copilot started reviewing on behalf of jamadeo February 12, 2026 16:49 View session

don't need that

52b9a47

Copilot AI reviewed Feb 12, 2026

View reviewed changes

Add to CI

700d873

jamadeo changed the title ~~Scaffold a goosed integration test~~ Add a goosed over HTTP integration test, and test the developer tool PATH Feb 12, 2026

jamadeo added 2 commits February 12, 2026 12:14

typo

82862f4

Move to pr-smoke-test because we need a live provider

9464447

Copilot AI review requested due to automatic review settings February 12, 2026 17:36

Copilot started reviewing on behalf of jamadeo February 12, 2026 17:37 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

ui/desktop/tests/integration/goosed.test.ts Outdated Show resolved Hide resolved

ui/desktop/src/components/OllamaSetup.test.tsx Show resolved Hide resolved

.github/workflows/pr-smoke-test.yml Show resolved Hide resolved

.github/workflows/pr-smoke-test.yml Show resolved Hide resolved

jamadeo added 3 commits February 12, 2026 13:42

it's a different binary of course

7b16b16

more reuse

f0dc5f4

add the key, and print response mismatches

dba81c7

Copilot AI review requested due to automatic review settings February 12, 2026 19:26

Copilot started reviewing on behalf of jamadeo February 12, 2026 19:27 View session

github-advanced-security bot found potential problems Feb 12, 2026

View reviewed changes

ui/desktop/src/goosed.ts

PATH: string;

GOOSE_PORT: string;

GOOSE_SERVER__SECRET_KEY?: string;

// Configuration for external goosed server

Check failure

Code scanning / Semgrep OSS

Command Injection via child_process Error

Command Injection via child_process

Copilot AI reviewed Feb 12, 2026

View reviewed changes

Copilot AI reviewed Feb 13, 2026

View reviewed changes

crates/goose-server/src/state.rs Outdated Show resolved Hide resolved

jamadeo and others added 8 commits February 12, 2026 21:13

Revert "REVERT ME: let's make sure this fails"

a2f730f

This reverts commit 80fdc0d.

paths

028b2fd

clean up

e32ffb0

More clean up

9c7ffd7

more clean up

ec3ac0b

External backend

5c2b511

Missing windows bits

33c1c79

Apply suggestions from code review

ee437b9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 13, 2026 15:25

Copilot started reviewing on behalf of jamadeo February 13, 2026 15:26 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

ui/desktop/tests/integration/setup.ts Outdated Show resolved Hide resolved

ui/desktop/vitest.integration.config.ts Show resolved Hide resolved

ui/desktop/tests/integration/setup.ts Outdated Show resolved Hide resolved

jamadeo added 5 commits February 13, 2026 11:00

simplify more

c433ca9

no port

0eac3b7

Use sdk type for /reply

08d5f6f

more cleanup

2ced089

better cleanup

38d8df6

Copilot AI review requested due to automatic review settings February 13, 2026 16:55

Copilot started reviewing on behalf of jamadeo February 13, 2026 16:55 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

jamadeo added 3 commits February 13, 2026 14:15

Keep this, it's useful

e249f30

Improve types

bc3813e

run the full cleanup on error

50eb213

jamadeo added this pull request to the merge queue Feb 13, 2026

Merged via the queue into main with commit 5ba5b98 Feb 13, 2026
19 checks passed

jamadeo deleted the goosed-http-integration-tests branch February 13, 2026 19:51

github-actions bot mentioned this pull request Feb 17, 2026

chore(release): release version 1.25.0 (minor) #7263

Open

	const goosedProcess = spawn(goosedPath, [], spawnOptions);
	const goosedProcess = spawn(goosedPath, ['agent'], spawnOptions);

	await status({ client });
	await status({ client, throwOnError: true });

Conversation

jamadeo commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jamadeo Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DOsinga left a comment

Choose a reason for hiding this comment

Uh oh!

DOsinga Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

jamadeo Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

DOsinga Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check failure

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

jamadeo commented Feb 12, 2026 •

edited

Loading