-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telegram Web causes crash #56
Comments
I don't have Telegram so I can't replicate or bisect this. @aeiouaeiouaeiouaeiouaeiouaeiou It would be great to know whether this is also happening in the equivalent version of Chrome Canary, and/or if it's happening in the latest stable version of Chromium Legacy. The presence of CoreText's |
As of April 2, 2022, it looks like this crash can also be triggered on https://www.rottentomatoes.com/m/the_french_dispatch (see #48). This only happens on Mountain Lion, not Lion or Mavericks. Unlike #2 (which I keep expecting to eventually reappear on Lion and/or Mountain Lion), this doesn't appear to be a use-after-free bug. Interposing The problem also does not disappear when I launch Chromium with |
OK, confirmed with 10.8, too. |
As a temporary workaround, removing Notably, installing a newer version of the emoji font from Big Sur did not resolve the crash. |
Ah, gotcha! Chromium seems to be able to render rottentomatoes without crashing for now. |
Off topic, but I can't help it, this image is making me squirm! Consider updating your emoji font to get rid of all those empty squares! See for instance: https://github.com/Wowfunhappy/Updated-Mavericks-Emojis/releases (It says Mavericks, but I tested Mountain Lion just now and it seems to work fine. If you want to be conservative, install only the font and ignore |
* Voice search - FeedReliabilityLogger is plumbed down into TasksSurfaceMediator for this. * Omnibox focused - FeedReliabilityLogger is added as an omnibox focus change listener for this. * Navigate away - We detect this when the user does any navigation from Start Surface (except for feed card taps and background tabs). * Navigate back - Detected in onBackPressed() just before mController handles the back press. (cherry picked from commit 74a2a5b) Bug: 1195940,1326142 Change-Id: Idb015603fd766baab5c7f978b52aa702b83824f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3618351 Reviewed-by: Xi Han <hanxi@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1003407} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3650953 Auto-Submit: Ian Wells <iwells@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/branch-heads/5060@{#56} Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
In this CL, the following changes are made: 1. Change text of the header from one line to two lines. 2. Add two strings for each line. 3. Update the text styles. Screenshot: https://drive.google.com/file/d/1r_P5fxoswjp1Ni4Ex4xv9-fiD106_tbi/view?usp=sharing (cherry picked from commit 978c032) Bug: 1347074,1347177 Change-Id: I8c4774dd0ed349730c4d998f8987e9d6ae59a04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3785384 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by: Hao Dong <spdonghao@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1027913} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3785242 Cr-Commit-Position: refs/branch-heads/5195@{#56} Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
… group count Based on discussions with product and UX, we want to change the tab stack button count from "tab group count + non-tab group count" to "total tab count irrespective of groups" (cherry picked from commit efc42e9) Bug: 1353171 Change-Id: I7ca05c7f99cbecf0358fac38f3235afbd9a5330f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827359 Reviewed-by: Theresa Sullivan <twellington@chromium.org> Commit-Queue: Sirisha Kavuluru <skavuluru@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1037984} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3852941 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5249@{#56} Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
BUG=1370239 (cherry picked from commit 2425e1f) Change-Id: I18f924cabd28318b8abebe4c57d8b334b2df0a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3946131 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1058990} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3961210 Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/branch-heads/5359@{#56} Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
This CL adds calls to CredentialManager setCurrentAutofillAccount() for non signed-in users with UPM flag set to enabled. For these users sync service did not reported status changes after PasswordManager initialisation which resulted in not informing CredentialManager about the initial sync status. After this CL, CredentialManager will always be informed on Chrome startup. Sync status should not change after the sync service is initialised, so for signed in users there is still only one call but it's performed earlier. This should not change any user-visible behaviour and only affects metrics collected on the GMS ChromeSync side. (cherry picked from commit 0671c87) Bug: 1402964 Change-Id: Ia3618cf007eb9987ea431b4bbd236036cf59800b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4120437 Reviewed-by: Maria Kazinova <kazinova@google.com> Commit-Queue: Maxim Anufriev <maxan@google.com> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1086367} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4122349 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Maxim Anufriev <maxan@google.com> Cr-Commit-Position: refs/branch-heads/5481@{#56} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
…out users" This reverts commit 48876b4. Reason for revert: Possibly causes crash go/paste/6166598166511616 Original change's description: > [UPM] Report sync status to the CredentialManager for signed out users > > This CL adds calls to CredentialManager setCurrentAutofillAccount() > for non signed-in users with UPM flag set to enabled. For these users > sync service did not reported status changes after PasswordManager > initialisation which resulted in not informing CredentialManager about > the initial sync status. After this CL, CredentialManager will always > be informed on Chrome startup. Sync status should not change after the > sync service is initialised, so for signed in users there is still > only one call but it's performed earlier. > > This should not change any user-visible behaviour and only affects > metrics collected on the GMS ChromeSync side. > > (cherry picked from commit 0671c87) > > Bug: 1402964 > Change-Id: Ia3618cf007eb9987ea431b4bbd236036cf59800b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4120437 > Reviewed-by: Maria Kazinova <kazinova@google.com> > Commit-Queue: Maxim Anufriev <maxan@google.com> > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Original-Commit-Position: refs/heads/main@{#1086367} > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4122349 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Auto-Submit: Maxim Anufriev <maxan@google.com> > Cr-Commit-Position: refs/branch-heads/5481@{#56} > Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008} Bug: 1402964 Change-Id: Idf8b13f6b02c55e2784db55b46a2b8ad5e8da518 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4122226 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/branch-heads/5481@{#60} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
Show a managed dialog popup when the user attempts to reset to classic chrome or change to the themes page if background image is restricted by the admin policy. screenshot: screenshot/BbZbsfGLJmgiLcj (cherry picked from commit 6dd982a) Bug: 1401485 Change-Id: I7acd8137475341a9ab7c613ed430839e584599d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4198002 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Riley Tatum <rtatum@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1097676} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4206207 Reviewed-by: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/branch-heads/5563@{#56} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
…12.0.5615.7-r1 to 112-5563.31-1677502748-benchmark-112.0.5615.8-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I442479e8d57bf01b8f27dc2686072593b3c6c57e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4296191 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5615@{#56} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
(cherry picked from commit 631155a) Bug: 1427457 Change-Id: I9a83434a3193b9bee9a2d9c707d60bc7c35bf4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370726 Auto-Submit: Anthony Vallée-Dubois <anthonyvd@chromium.org> Commit-Queue: Alison Gale <agale@chromium.org> Reviewed-by: Alison Gale <agale@chromium.org> Reviewed-by: Eshwar Stalin <estalin@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1121986} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4375617 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5672@{#56} Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
This changes shows "Google Password Manager" instead of "Password Manager" in chrome://settings/autofill to match the naming in Chrome menu. (cherry picked from commit bcfe9c2) Fixed: 1440748 Change-Id: I3d15a197306f71e1f51783d17abe9c24affd0fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4482443 Reviewed-by: Andrii Natiahlyi <natiahlyi@google.com> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Commit-Queue: Andrii Natiahlyi <natiahlyi@google.com> Auto-Submit: Viktor Semeniuk <vsemeniuk@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1136582} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4489353 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/branch-heads/5735@{#56} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Describe the bug
Telegram Web keeps crashing every time when I try to use it in Chromium Legacy.
To Reproduce
Steps to reproduce the behavior:
Screenshots
Desktop (please complete the following information):
Logs
Crash log (cleared up redundant information at the end)
The text was updated successfully, but these errors were encountered: