New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation on ProjectionFactorPPPC #1004

Merged

varunagrawal merged 3 commits into develop from fix/projection-factor-pppc-documentation

Jan 3, 2022

Contributor

dwisth commented Jan 3, 2022

A couple of small changes to ProjectionFactorPPPC:

Remove excess constructor, use default arguments instead
Fix construction documentation
Make some variables const where possible

dwisth added 3 commits

January 3, 2022 16:40


          remove unnessecary constructor - use default arguments instead

b166985


          fix constructor documentation

c86e42e


          change a couple of variables to const

25c82c9

dwisth requested a review from varunagrawal

January 3, 2022 05:45

varunagrawal approved these changes

View reviewed changes

Collaborator

varunagrawal left a comment

LGTM

varunagrawal merged commit 6bfad39 into develop

varunagrawal deleted the fix/projection-factor-pppc-documentation branch

January 3, 2022 14:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet