-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in gtsam to support hybrid branches #1055
Conversation
@@ -340,4 +340,11 @@ namespace gtsam { | |||
return f.apply(g, op); | |||
} | |||
|
|||
/// unzip a DecisionTree if its leaves are `std::pair` | |||
template<typename L, typename T1, typename T2> | |||
std::pair<DecisionTree<L, T1>, DecisionTree<L, T2> > unzip(const DecisionTree<L, std::pair<T1, T2> > &input) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, @ProfFan , this should probably have been a static method and be called Unzip
. Or a method, and then it would not take an argument, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, just looking for consensus, I think I would change it to static.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I see now it is neither: it is a free function :-/ Which is correctly named, so never mind! Will re-format is all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to reopen CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll just do the required one and merge
Killed CI while deciding about Unzip |
# Conflicts: # gtsam/discrete/DecisionTreeFactor.cpp
I think this is ready to merge if I can get an approving review from @ProfFan or @varunagrawal |
Sorry I was out the entire afternoon. I'll review in the next 30 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Merge whenever.
I can't merge because there is some CI waiting to be reported. Any ideas? |
I reopened the PR, now it should start to build. @dellaert |
@dellaert CI is ready :) |
This PR collect a number of commits to files made in the hybrid development branches.
I made the commits below descriptive.
@varunagrawal we can re-target the PRs or just wait until this is merged.